Re: [PATCH] gnu: Add python-contextlib2

[Chris Marusich <cmmarusich@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

Hi,

On 12/6/15, Ludovic Courtès <ludo@gnu.org> wrote:
> Yes, could you adjust it and send an updated patch?
>

I've attached the new patch here. I've shortened a few lines,
including the one requested.

In particular, I've shortened every line of the description to 70
columns. Because of that, it looks like the first line of the
description will wind up being significantly shorter than 70 chars.
Are the newlines in the description significant? Or is there some
reformatting that happens when the description is printed to the
terminal, e.g. via "guix package --search=foo"? I'm just curious
because one might find it aesthetically displeasing if the first line
is cut short simply because we had to format to 70 columns the code
where the package description happened to be defined. It's totally
minor, though.

I'm also not sure why my emacs did not automatically wrap the lines to
70 chars in the first place, since I do see that the fill-column
variable was set to 70.  I guess I'll have to look into that, but for
now I was able to wrap it to 70 chars myself.

> I must I was a bit confused, partly due to the reply-on-top, which made
> it more difficult for me to see what you were referring to.  Okay, I was
> also late for other reasons ;-), but still, I think it’d be great if you
> could avoid top-posting.

Thanks for pointing this out; I'll reply on the bottom from now on!

Chris

[-- Attachment #2: 0001-gnu-Add-python-contextlib2.patch --]
[-- Type: application/octet-stream, Size: 1804 bytes --]

From 4089b10f384b389999576dfc8766c661a5787a4b Mon Sep 17 00:00:00 2001
From: Chris Marusich <cmmarusich@gmail.com>
Date: Mon, 7 Dec 2015 21:07:40 -0800
Subject: [PATCH] gnu: Add python-contextlib2.

* gnu/packages/python.scm (python-contextlib2, python2-contextlib2):
  New variables.
---
 gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index d01c1d3..c70fdd0 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6565,3 +6565,34 @@ of the SSL peer.")
     (arguments `(#:python ,python-2))
     (propagated-inputs
      `(("python2-pyopenssl" ,python2-pyopenssl)))))
+
+(define-public python-contextlib2
+  (package
+    (name "python-contextlib2")
+    (version "0.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "contextlib2" version))
+       (sha256
+        (base32
+         "0cmp131dlh0d0zvw0aza1zd13glvngzk8lb4avks0hm7yxwdr9am"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _ (zero?
+                      (system*
+                       "python" "test_contextlib2.py", "-v")))))))
+    (home-page "http://contextlib2.readthedocs.org/")
+    (synopsis "Tools for decorators and context managers")
+    (description "This module is primarily a backport of the Python
+3.2 contextlib to earlier Python versions.  Like contextlib, it
+provides utilities for common tasks involving decorators and context
+managers.  It also contains additional features that are not part of
+the standard library.")
+    (license psfl)))
+
+(define-public python2-contextlib2
+  (package-with-python2 python-contextlib2))
-- 
2.5.0