From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: java: switch to icedtea-8 as default JDK Date: Fri, 24 Nov 2017 12:46:33 +0100 Message-ID: References: <87375czhqj.fsf@elephly.net> <873756herx.fsf@gmail.com> <87y3myv7k9.fsf@elephly.net> <873756xn3m.fsf@gmail.com> <87efooc79n.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c0b8a92bc45f6055eb91a81" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eICRL-0004tG-N5 for guix-devel@gnu.org; Fri, 24 Nov 2017 06:46:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eICRH-0000vh-BW for guix-devel@gnu.org; Fri, 24 Nov 2017 06:46:39 -0500 Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]:44409) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eICRH-0000vB-5M for guix-devel@gnu.org; Fri, 24 Nov 2017 06:46:35 -0500 Received: by mail-io0-x231.google.com with SMTP id w127so29301450iow.11 for ; Fri, 24 Nov 2017 03:46:34 -0800 (PST) In-Reply-To: <87efooc79n.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel --94eb2c0b8a92bc45f6055eb91a81 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, I just made a branch, basically only changing that single line in java.scm. It's base on current core-updates. You can clone from: https://github.com/Boskovits/guix.git branch: change-default-icedtea-8. How do we know where you need further assistance with that? As first step it is not needed to remove #:jdk icedtea-8 references, because I think that simply becomes a noop. Am I right here? That can be done as the last step before merging, I guess. 2017-11-24 11:15 GMT+01:00 Ricardo Wurmus : > > Hi G=C3=A1bor, > > > I guess we could just flip that to icedtea-8, and check what still work= s. > > That would flip the version in the build system also, as it uses > "icedtea". > > Exactly. The call for help is really about dealing with the fallout > from this change. I=E2=80=99ve attempted this some time ago when we stil= l had > a much smaller set of Java packages, but it=E2=80=99s too much to check a= ll of > the packages by myself. > > > Should I check which packages are affected in advance, or just go with > the > > build and see what does not work? > > For some packages it=E2=80=99s feasible to do this immediately before pus= hing. > It=E2=80=99s also good to review the weird hacks that were sometimes nece= ssary, > and check if they are still needed. > > We also need to confirm that the generated build.xml files have the > appropriate =E2=80=9Csource=E2=80=9D and =E2=80=9Ctarget=E2=80=9D version= specifiers. > > But mostly we can just change the default =E2=80=9Cicedtea=E2=80=9D and r= emove =E2=80=9C#:jdk > ,icedtea-8=E2=80=9D from all packages. I=E2=80=99d like to avoid having = to add =E2=80=9C#:jdk > ,icedtea-7=E2=80=9D to any of the packages; finding fixes would be prefer= rable. > > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net > > > --94eb2c0b8a92bc45f6055eb91a81 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, I just made a branch, basically only changing tha= t single line in java.scm.
It's base on current core-updates.=

branch:= change-default-icedtea-8.

How do we know where you = need further assistance with that?

As first step i= t is not needed to remove #:jdk icedtea-8 references, because I think that = simply becomes a noop. Am I right here?
That can be done as the l= ast step before merging, I guess.
2017-11-24 11:15 GMT+01:00 Ricardo Wurmus <re= kado@elephly.net>:

Hi G=C3=A1bor,

> I guess we could just flip that to icedtea-8, and check what still wor= ks.
> That would flip the version in the build system also, as it uses "= ;icedtea".

Exactly.=C2=A0 The call for help is really about dealing with the fa= llout
from this change.=C2=A0 I=E2=80=99ve attempted this some time ago when we s= till had
a much smaller set of Java packages, but it=E2=80=99s too much to check all= of
the packages by myself.

> Should I check which packages are affected in advance, or just go with= the
> build and see what does not work?

For some packages it=E2=80=99s feasible to do this immediately befor= e pushing.
It=E2=80=99s also good to review the weird hacks that were sometimes necess= ary,
and check if they are still needed.

We also need to confirm that the generated build.xml files have the
appropriate =E2=80=9Csource=E2=80=9D and =E2=80=9Ctarget=E2=80=9D version s= pecifiers.

But mostly we can just change the default =E2=80=9Cicedtea=E2=80=9D and rem= ove =E2=80=9C#:jdk
,icedtea-8=E2=80=9D from all packages.=C2=A0 I=E2=80=99d like to avoid havi= ng to add =E2=80=9C#:jdk
,icedtea-7=E2=80=9D to any of the packages; finding fixes would be preferra= ble.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6=C2=A0 2150 197A 5888 235F ACAC
https:= //elephly.net



--94eb2c0b8a92bc45f6055eb91a81--