From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Status of Submitted Patches Date: Sun, 20 May 2018 12:47:20 +0200 Message-ID: References: <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net> <871sfxev9w.fsf@elephly.net> <7626275c-3eee-bb05-ab9d-4c88ec6f0329@swecha.net> <87r2nvjte6.fsf@elephly.net> <5ab51417-b635-9725-9f48-3bc3f9b61fdf@swecha.net> <87tvsko2wd.fsf@elephly.net> <7290013c-990d-3f7d-d8db-38e090ed766a@swecha.net> <87zi28kt82.fsf@elephly.net> <8573e97d-d107-cde6-cd17-35f4ef6d2de3@swecha.net> <87k1takumm.fsf@elephly.net> <87o9hycwl6.fsf@elephly.net> <87r2mhdeap.fsf@elephly.net> <618c131c-6ba6-e525-aefc-72acca1c910f@swecha.net> <87a7suwtp7.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e2a4d8056ca0e891" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKLs7-0006bs-5R for guix-devel@gnu.org; Sun, 20 May 2018 06:47:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKLs5-00007m-Rc for guix-devel@gnu.org; Sun, 20 May 2018 06:47:27 -0400 In-Reply-To: <87a7suwtp7.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: Sahitihi , Guix-devel --000000000000e2a4d8056ca0e891 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-05-20 11:40 GMT+02:00 Ricardo Wurmus : > > Hi Sahithi, > > >> While this achieves the goal for a single character it does not > >> constitute a custom port. Have you read the documentation for > >> =E2=80=9Cmake-custom-port=E2=80=9D in the Guile manual? > > > > I have tried with the following code for, G=C3=A1bor helped me in proce= ss [=E2=80=A6] > > Oh, I haven=E2=80=99t seen those emails on the mailing list. Please keep= the > discussion on the mailing list so that all mentors and the community can > comment. > > The discussion was on IRC in a 1:1 conversation. The task Sahitihi wanted to achieve was to create a soft-port capitalizing all text sent to it. I helped her to achieve that. I was thinking about mailing you the details, but it was only a few lines of code. I will also make sure to keep you in the circuit in the future. > > the description for that goes this way.... > > > > The input taken from input port is read and stored in variable "s". > > This variable is passed to make-soft-port. The variable s is > > capitalized by locale conversion then binded with color. the result is > > displayed when called. > > Please try to be a little more precise with the descriptions. You > defined a new port with =E2=80=9Cmake-soft-port=E2=80=9D. The new port h= as two > important procedures: one that takes a single character, and another > that takes a string. In the case of a single character you just pass it > through to the current output port. In the case of a string, you > colorize it first and then write it to the output port. > > The result is a port that will print a coloured string whenever you pass > it a string. > > How would you use this in =E2=80=9C(guix store)=E2=80=9D? Note that we d= on=E2=80=99t want to > apply colour to any and all strings there. We want only certain > messages to be coloured. Can you please prepare a patch to =E2=80=9C(gui= x > store)=E2=80=9D that shows us how you would use this new port? > > As a first change, could you please add the relevant parts of =E2=80=9C(i= ce-9 > colorized)=E2=80=9D to a module in Guix? We probably don=E2=80=99t want = to depend on > having users install this module separately. We also don=E2=80=99t need = all of > it. Please prepare a patch that adds only the relevant parts to =E2=80= =9C(guix > ui)=E2=80=9D and update the copyright headers. > > > I have tried the other process using escape codes however failed with > > the result i will come with this implementation and procedure in my nex= t > > mail > > I have not received this email. Have you worked on this yet? > > When you have problems with code please always provide the relevant > parts of your code with the error messages, so that we can help you. > > I think that we need to start moving forward at a slighter higher > speed. Thanks! > > -- > Ricardo > > > --000000000000e2a4d8056ca0e891 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -05-20 11:40 GMT+02:00 Ricardo Wurmus <rekado@elephly.net>:=

Hi Sahithi,

>> While this achieves the goal for a single character it does not >> constitute a custom port.=C2=A0 Have you read the documentation fo= r
>> =E2=80=9Cmake-custom-port=E2=80=9D in the Guile manual?
>
> I have tried with the following code for, G=C3=A1bor helped me = in process [=E2=80=A6]

Oh, I haven=E2=80=99t seen those emails on the mailing list.=C2=A0 Please k= eep the
discussion on the mailing list so that all mentors and the community can comment.


The discussion= was on IRC in a 1:1 conversation. The task Sahitihi wanted
to ac= hieve was to create a soft-port capitalizing all text sent to it. I helped = her
to achieve that. I was thinking about mailing you the details= , but it was only a
few lines of code. I will also make sure to k= eep you in the circuit in the future.=C2=A0=C2=A0
=C2=A0
> the description for that goes this way....
>
> The input taken from input port is read and stored in variable "s= ".
> This variable is passed to make-soft-port. The variable s is
> capitalized by locale conversion then binded with color. the result is=
> displayed when called.

Please try to be a little more precise with the descriptions.=C2=A0 = You
defined a new port with =E2=80=9Cmake-soft-port=E2=80=9D.=C2=A0 The new por= t has two
important procedures: one that takes a single character, and another
that takes a string.=C2=A0 In the case of a single character you just pass = it
through to the current output port.=C2=A0 In the case of a string, you
colorize it first and then write it to the output port.

The result is a port that will print a coloured string whenever you pass it a string.

How would you use this in =E2=80=9C(guix store)=E2=80=9D?=C2=A0 Note that w= e don=E2=80=99t want to
apply colour to any and all strings there.=C2=A0 We want only certain
messages to be coloured.=C2=A0 Can you please prepare a patch to =E2=80=9C(= guix
store)=E2=80=9D that shows us how you would use this new port?

As a first change, could you please add the relevant parts of =E2=80=9C(ice= -9
colorized)=E2=80=9D to a module in Guix?=C2=A0 We probably don=E2=80=99t wa= nt to depend on
having users install this module separately.=C2=A0 We also don=E2=80=99t ne= ed all of
it.=C2=A0 Please prepare a patch that adds only the relevant parts to =E2= =80=9C(guix
ui)=E2=80=9D and update the copyright headers.

> I have tried the other process using escape codes however failed with<= br> > the result i will come with this implementation and procedure in my ne= xt
> mail

I have not received this email.=C2=A0 Have you worked on this yet?
When you have problems with code please always provide the relevant
parts of your code with the error messages, so that we can help you.

I think that we need to start moving forward at a slighter higher
speed.=C2=A0 Thanks!

--
Ricardo



--000000000000e2a4d8056ca0e891--