From: "Gábor Boskovits" <boskovits@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: proposal: with-file-writeable
Date: Fri, 16 Feb 2018 07:35:46 +0100 [thread overview]
Message-ID: <CAE4v=pj6x6op_bJtT2BuAjzRyBq8pzy-o=-Sd_fKW97zWpbX1A@mail.gmail.com> (raw)
In-Reply-To: <878tbuwd6y.fsf@fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
2018-02-15 15:16 GMT+01:00 Marius Bakke <mbakke@fastmail.com>:
> Gábor Boskovits <boskovits@gmail.com> writes:
>
> > Ok, the keep it this way. Another question, this came up, as
> > I was trying to find a nice solution to reset-gzip-timestamps failing.
> > I got different pieces of advice if I should reset the permissions after
> > resetting the timestamp, but I'm still not sure. It seems that the
> easiest
> > way to this would be to just add a call to make-file-writable to the
> phase
> > at the beginning, as we finally end up with a read-only one in the store
> > anyway. I feel that reseting the permissions is unneccesary additional
> > complexity. WDYT?
>
> In the "strip" phase we already call "make-file-writeable"
> unconditionally, so doing it in reset-gzip-permissions as well should be
> okay I think.
>
Ok, thanks, I will prepare a patch.
[-- Attachment #2: Type: text/html, Size: 1372 bytes --]
next prev parent reply other threads:[~2018-02-16 6:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 21:50 proposal: with-file-writeable Gábor Boskovits
2018-02-14 13:51 ` Ludovic Courtès
2018-02-14 19:13 ` Leo Famulari
2018-02-14 19:38 ` Gábor Boskovits
2018-02-14 23:28 ` Ludovic Courtès
2018-02-15 7:25 ` Gábor Boskovits
2018-02-15 13:22 ` Ludovic Courtès
2018-02-15 13:53 ` Gábor Boskovits
2018-02-15 14:16 ` Marius Bakke
2018-02-16 6:35 ` Gábor Boskovits [this message]
2018-02-16 8:40 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4v=pj6x6op_bJtT2BuAjzRyBq8pzy-o=-Sd_fKW97zWpbX1A@mail.gmail.com' \
--to=boskovits@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).