From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy) Date: Wed, 21 Mar 2018 20:44:37 +0100 Message-ID: References: <87fu5pch36.fsf@elephly.net> <87h8pfy56s.fsf@elephly.net> <87tvtdthda.fsf@elephly.net> <87k1u8uccr.fsf@elephly.net> <87in9qdcws.fsf@elephly.net> <20180321083549.GA20703@macbook41> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114491d2dbf8c80567f16b47" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyjf6-00089d-U8 for guix-devel@gnu.org; Wed, 21 Mar 2018 15:44:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyjf5-000281-8F for guix-devel@gnu.org; Wed, 21 Mar 2018 15:44:40 -0400 Received: from mail-io0-x229.google.com ([2607:f8b0:4001:c06::229]:33525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyjf5-00027X-0e for guix-devel@gnu.org; Wed, 21 Mar 2018 15:44:39 -0400 Received: by mail-io0-x229.google.com with SMTP id l3so8070111iog.0 for ; Wed, 21 Mar 2018 12:44:38 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Vijayalakshmi Vedantham Cc: Guix-devel --001a114491d2dbf8c80567f16b47 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-03-21 18:03 GMT+01:00 Vijayalakshmi Vedantham : > Thank you so much to everyone who replied. This project truly has the > kindest and most polite people. > > I wanted to know what kind of system most people work on. My ubuntu is > giving me Locale errors so I was thinking of creating a virtual environme= nt > and working on that. Do you think that will work out? > > Most of the time I use a laptop with Ubuntu as a host system, and GuixSD running in a KVM/qemu virtual machine. It works fine for me. > Also, has the patch been applied yet? > > Yes, I see that the patch has been applied already. > Thanks, > Vijayalakshmi > > On Wed, Mar 21, 2018 at 2:05 PM, Efraim Flashner > wrote: > >> On Tue, Mar 20, 2018 at 08:45:02PM +0530, Vijayalakshmi Vedantham wrote: >> > Hi, >> > >> > I'm really sorry about the effort you had to put into this patch. I'll >> try >> > not to do it again. >> > >> > I had to append =E2=80=9C.zip=E2=80=9D because Pypi didn=E2=80=99t hav= e a =E2=80=9C.tar.gz=E2=80=9D file for the >> > > sources, so the uri >> > > field now is: >> > > >> > > (pypi-uri "logwrap" version ".zip") >> > > >> > >> > Did you do this because only .zip is available here ( >> > https://pypi.python.org/pypi/logwrap#downloads)? >> > >> >> $ guix import pypi logwrap >> >> Starting download of /tmp/guix-file.BdwXcD >> From https://pypi.python.org/packages/b3/17/c7d450ce6a1ce82e14585 >> 2895509fddc9468225d2aa312a772bb9c188a73/logwrap-3.2.1.zip... >> =E2=80=A63.2.1.zip 241KiB 869KiB/s 00:00 [##########= ########] >> 100.0% >> >> In this case the importer grabbed a zip file, so I guess it falls into >> tribal knowledge, definately something that should be documented better. >> >> > >> > > >> > > I also noticed that the sources include files that were generated wi= th >> > > Cython. Instead of reusing those, we build them from source. Lucki= ly >> > > all we have to do in this case is to add =E2=80=9Cpython-cython=E2= =80=9D to the >> > > native-inputs field. >> > > >> > >> > Can I know how you knew this? >> >> For files that are generated by Cython they generally have a line at the >> top that reads: "Generated by Cython 0.x.y" or something along those >> lines. If you unzip the downloaded source and run 'grep Cython . -R' >> inside the folder it'll show any files generated by Cython. >> >> > >> > >> > > Finally, the tests. At first the tests wouldn=E2=80=99t run. So I l= ooked up >> the >> > > error message online and found that I need to use >> =E2=80=9Cpython-pytest-runner=E2=80=9D >> > > in addition to =E2=80=9Cpython-pytest=E2=80=9D. This allows the tes= ts to run up to a >> > > point until it wants to do coverage tests. For those I needed to ad= d >> > > =E2=80=9Cpython-pytest-cov=E2=80=9D. >> > > >> > > I changed the description, because I think it wasn=E2=80=99t quite c= orrect. >> > > >> > >> > Again, I'm sorry. >> >> No worries, the test suite wasn't so easy. The release tarball/zip >> didn't include good directions for running the test suite, I had to go >> to the actual repository and see how the tests were run with 'tox' and >> then try recreating the commands; I wasn't successful. >> >> As far as the description goes, it's my least favorite part :). >> >> > >> > >> > Have you been able to build Guix already and try building the >> package >> > using =E2=80=9C./pre-inst-env guix build=E2=80=9D? >> > >> > No, I tried last night but I faced some issues, I'll try again tonight= . >> > >> > Thanks, >> > Vijayalakshmi >> >> -- >> Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7= =9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 >> GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 >> Confidentiality cannot be guaranteed on emails sent or received >> unencrypted >> > > --001a114491d2dbf8c80567f16b47 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -03-21 18:03 GMT+01:00 Vijayalakshmi Vedantham <vijimay12@gmail.com&= gt;:
Thank y= ou so much to everyone who replied. This project truly has the kindest and = most polite people.

I wanted to know what kind of system = most people work on. My ubuntu is giving me Locale errors so I was thinking= of creating a virtual environment and working on that. Do you think that w= ill work out?


Most of t= he time I use a laptop with Ubuntu as a host system, and GuixSD running in = a KVM/qemu virtual machine. It works fine for me.
=C2=A0
Also, has the = patch been applied yet?

Yes, I see that the patch has been applied already.
= =C2=A0
Thanks,
Vijayalakshmi
<= div class=3D"h5">

= On Wed, Mar 21, 2018 at 2:05 PM, Efraim Flashner <efraim@flashner.co.i= l> wrote:
On Tue, Mar= 20, 2018 at 08:45:02PM +0530, Vijayalakshmi Vedantham wrote:
> Hi,
>
> I'm really sorry about the effort you had to put into this patch. = I'll try
> not to do it again.
>
> I had to append =E2=80=9C.zip=E2=80=9D because Pypi didn=E2=80=99t hav= e a =E2=80=9C.tar.gz=E2=80=9D file for the
> > sources, so the uri
> > field now is:
> >
> >=C2=A0 =C2=A0 (pypi-uri "logwrap" version ".zip&quo= t;)
> >
>
> Did you do this because only .zip is available here (
> https://pypi.python.org/pypi/logwrap#downloa= ds)?
>

$ guix import pypi logwrap

Starting download of /tmp/guix-file.BdwXcD
>From https://pypi.python.org/packages/b3/17/c7d450ce= 6a1ce82e145852895509fddc9468225d2aa312a772bb9c188a73/logwrap-3.2.= 1.zip...
=C2=A0=E2=80=A63.2.1.zip=C2=A0 241KiB=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0869KiB/s 00:00 [##################] 100.0%
In this case the importer grabbed a zip file, so I guess it falls into
tribal knowledge, definately something that should be documented better.
>
> >
> > I also noticed that the sources include files that were generated= with
> > Cython.=C2=A0 Instead of reusing those, we build them from source= .=C2=A0 Luckily
> > all we have to do in this case is to add =E2=80=9Cpython-cython= =E2=80=9D to the
> > native-inputs field.
> >
>
> Can I know how you knew this?

For files that are generated by Cython they generally have a line at= the
top that reads: "Generated by Cython 0.x.y" or something along th= ose
lines. If you unzip the downloaded source and run 'grep Cython . -R'= ;
inside the folder it'll show any files generated by Cython.

>
>
> > Finally, the tests. At first the tests wouldn=E2=80=99t run.=C2= =A0 So I looked up the
> > error message online and found that I need to use =E2=80=9Cpython= -pytest-runner=E2=80=9D
> > in addition to =E2=80=9Cpython-pytest=E2=80=9D.=C2=A0 This allows= the tests to run up to a
> > point until it wants to do coverage tests.=C2=A0 For those I need= ed to add
> > =E2=80=9Cpython-pytest-cov=E2=80=9D.
> >
> > I changed the description, because I think it wasn=E2=80=99t quit= e correct.
> >
>
> Again, I'm sorry.

No worries, the test suite wasn't so easy. The release tarball/z= ip
didn't include good directions for running the test suite, I had to go<= br> to the actual repository and see how the tests were run with 'tox' = and
then try recreating the commands; I wasn't successful.

As far as the description goes, it's my least favorite part :).

>
>
>=C2=A0 =C2=A0 =C2=A0 Have you been able to build Guix already and try b= uilding the package
> using =E2=80=9C./pre-inst-env guix build=E2=80=9D?
>
> No, I tried last night but I faced some issues, I'll try again ton= ight.
>
> Thanks,
> Vijayalakshmi

--
Efraim Flashner=C2=A0 =C2=A0<efraim@flashner.co.il>=C2=A0 =C2=A0=D7=90=D7=A4=D7= =A8=D7=99=D7=9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D=C2=A0 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted=


--001a114491d2dbf8c80567f16b47--