From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: java: switch to icedtea-8 as default JDK Date: Fri, 5 Jan 2018 17:01:09 +0100 Message-ID: References: <87o9n3gz43.fsf@gmail.com> <20171213103248.GA12880@macbook41> <877etlo2fq.fsf@elephly.net> <87y3lzgmy1.fsf@gmail.com> <877etiz7uu.fsf@elephly.net> <87incg48ed.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113c00d69c3a900562098ed4" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXUQj-0006Ni-Ta for guix-devel@gnu.org; Fri, 05 Jan 2018 11:01:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXUQi-0003Ta-LE for guix-devel@gnu.org; Fri, 05 Jan 2018 11:01:13 -0500 Received: from mail-it0-x234.google.com ([2607:f8b0:4001:c0b::234]:35107) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eXUQi-0003Ss-CQ for guix-devel@gnu.org; Fri, 05 Jan 2018 11:01:12 -0500 Received: by mail-it0-x234.google.com with SMTP id f143so2147831itb.0 for ; Fri, 05 Jan 2018 08:01:11 -0800 (PST) In-Reply-To: <87incg48ed.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel --001a113c00d69c3a900562098ed4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-01-05 16:44 GMT+01:00 Ricardo Wurmus : > > G=C3=A1bor Boskovits writes: > > > If I understand well, then the check phase in ant-build-system > > runs without make-flags. > > In the definition of java-asm we configure the build with make-flags, s= o > > the build system > > does not complain about missing configuration. > > This configuration is still needed for the test target, so building tha= t > > fails. > > > > We could do two things: > > 1. Patch build.xml to not perform these checks. (Then we can also remov= e > > the make-flags all togethet) > > 2. Do something, so that we can pass make-flags to check phase, maybe b= y > > introducing test-make-flags, or something like that to > > ant-build-system. > > You could also replace the check phase to run ant with the make-flags. > > Fine, will do that then. It seems the cleanest solution... Thanks > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net > > > --001a113c00d69c3a900562098ed4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -01-05 16:44 GMT+01:00 Ricardo Wurmus <rekado@elephly.net>:=

G=C3=A1bor Boskovits <boskovits@g= mail.com> writes:

> If I understand well, then the check phase in ant-build-system
> runs without make-flags.
> In the definition of java-asm we configure the build with make-flags, = so
> the build system
> does not complain about missing configuration.
> This configuration is still needed for the test target, so building th= at
> fails.
>
> We could do two things:
> 1. Patch build.xml to not perform these checks. (Then we can also remo= ve
> the make-flags all togethet)
> 2. Do something, so that we can pass make-flags to check phase, maybe = by
> introducing test-make-flags, or something like that to
> ant-build-system.

You could also replace the check phase to run ant with the make-flag= s.

Fine, will do that then. It seems the cleanest solution...
T= hanks
=C2=A0
--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6=C2=A0 2150 197A 5888 235F ACAC
https:= //elephly.net



--001a113c00d69c3a900562098ed4--