From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Cleaning up make clean's behavior Date: Sat, 2 Jun 2018 18:54:05 +0200 Message-ID: References: <87a7sd17jz.fsf@ITSx01.pdp10.guru> <20180602164624.zagmwhw5oilreumm@abyayala> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000066e567056dab8c25" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP9n6-0000lP-3r for guix-devel@gnu.org; Sat, 02 Jun 2018 12:54:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP9n4-0004x1-VZ for guix-devel@gnu.org; Sat, 02 Jun 2018 12:54:08 -0400 Received: from mail-ua0-x235.google.com ([2607:f8b0:400c:c08::235]:45378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fP9n4-0004w3-Q6 for guix-devel@gnu.org; Sat, 02 Jun 2018 12:54:06 -0400 Received: by mail-ua0-x235.google.com with SMTP id k14-v6so2723281uao.12 for ; Sat, 02 Jun 2018 09:54:06 -0700 (PDT) In-Reply-To: <20180602164624.zagmwhw5oilreumm@abyayala> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jeremiah@pdp10.guru, Guix-devel --00000000000066e567056dab8c25 Content-Type: text/plain; charset="UTF-8" 2018-06-02 18:46 GMT+02:00 Nils Gillmann : > Hi Jeremiah, > > Jeremiah@pdp10.guru transcribed 946 bytes: > > As running make clean breaks the bootstrap script. > > I propose we leverage git's shallow clones (git clone --depth 1 $URL) > > and include the .git directory with the repo such that we could simply > > have make clean check for git and if it exists run git clean -xdf and > > then only if git fails to exist, fallback to the existing broken form; > > which needs to be corrected. > > > > per discussion with g_bor[m] about the default automake clean rules > > being used currently; and per their suggestion bringing this question to > > this distribution list for further discussion. > > Where did this discussion take place? Would be good to read some > details if possible. > > ng0 > > > Additional wouldn't one want to pack the .git in the tarball to enable a > > simplified update method. > > > > jlicht pointed out that this would not be a problem yet for guix, but it > > does seem unconventional. It would not make sense for some bigger-repo > projects (e.g. emacs) for sure though > > > > Given that discussion background does anyone have any problems, concerns > > or issues with the change proposed? > > > > It was on #guix. Currently I have found what causes the problem with make clean. I'm working on an alternative fix, but the idea outlined here seems to worth discussing. --00000000000066e567056dab8c25 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2018-06-02 18:46 GMT+02:00 Nils Gillmann <ng0@n0.is>:
Hi Jeremiah,

Jeremiah@pdp10.guru transcribed 946 bytes:
> As running make clean breaks the bootstrap script. > I propose we leverage git's shallow clones (git clone --depth 1 $U= RL)
> and include the .git directory with the repo such that we could simply=
> have make clean check for git and if it exists run git clean -xdf and<= br> > then only if git fails to exist, fallback to the existing broken form;=
> which needs to be corrected.
>
> per discussion with g_bor[m] about the default automake clean rules > being used currently; and per their suggestion bringing this question = to
> this distribution list for further discussion.

Where did this discussion take place? Would be good to read some
details if possible.

ng0

> Additional wouldn't one want to pack the .git in the tarball to en= able a
> simplified update method.
>
> jlicht pointed out that this would not be a problem yet for guix, but = it
>=C2=A0 does seem unconventional. It would not make sense for some bigge= r-repo projects (e.g. emacs) for sure though
>
> Given that discussion background does anyone have any problems, concer= ns
> or issues with the change proposed?
>

It was on #guix. Currently I have found what= causes the problem with make clean. I'm working on an alternative fix,= but the idea outlined here seems to worth discussing.
--00000000000066e567056dab8c25--