From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Maintaining GNU Jami package for Guix Date: Mon, 4 Nov 2019 11:02:59 +0100 Message-ID: References: <20191018205608.45b264dc@kompiuter> <20191101132929.72495778@interia.pl> <87v9s3775l.fsf@ambrevar.xyz> <20191102001630.7bcfe9d9@interia.pl> <87y2wxi7tv.fsf@ambrevar.xyz> <20191103115420.6221e83b@interia.pl> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005d1c4d0596826ccd" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:48927) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRZCb-0006Db-Uz for guix-devel@gnu.org; Mon, 04 Nov 2019 05:03:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRZCa-0005wm-L3 for guix-devel@gnu.org; Mon, 04 Nov 2019 05:03:13 -0500 Received: from mail-vs1-xe2d.google.com ([2607:f8b0:4864:20::e2d]:44922) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRZCa-0005wa-Ga for guix-devel@gnu.org; Mon, 04 Nov 2019 05:03:12 -0500 Received: by mail-vs1-xe2d.google.com with SMTP id j85so10588494vsd.11 for ; Mon, 04 Nov 2019 02:03:12 -0800 (PST) In-Reply-To: <20191103115420.6221e83b@interia.pl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jan Wielkiewicz Cc: Guix-devel --0000000000005d1c4d0596826ccd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Jan, Jan Wielkiewicz ezt =C3=ADrta (id=C5= =91pont: 2019. nov. 3., V, 22:20): > Dnia 2019-11-03, o godz. 11:15:56 > Pierre Neidhardt napisa=C5=82(a): > > > Can you share the complete recipe? > > > > Yes. I guess you want a patch of my entire work so far, because > pjproject-jami is meaningless without changes in jami, so I'm attaching > the whole patch. Also the commit messages are messy, any advice how > should they look? > > Thanks for working on this. I can share some recommendations on the commit messages and structuring changes. While developing, feel free to do however it is convenient for you= . Then before sumitting: If I see it correctly, then three packages are involved, so this should be three commits. When adding a new package make that a separate commit. Make it one commit, the final version. (You can squash commits together to make it one.) The commit message there should be in the form: gnu: Add . When updating a package, you can make that a single commit. Commit message should be: gnu: : Update to . If anything else is done besides updating the version, mention that in the commit message. You can find examples in the git log of guix, like for commit: af561664b8191e2a34570176422f4d500d5fd4fb One further thing: If you order the patches, then the earlier patches can make it to upstream before the rest of the series. For example libresample could be incorporated eariler, reducing the amount of code on the branch. Thanks so much for working on Jami, and happy hacking! > Jan Wielkiewicz > Best regards, g_bor --=20 OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21 --0000000000005d1c4d0596826ccd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Jan,

Jan Wielkiewicz <= tona_kosmicznego_smi= ecia@interia.pl> ezt =C3=ADrta (id=C5=91pont: 2019. nov. 3., V, 22:2= 0):
Dnia 2019-11= -03, o godz. 11:15:56
Pierre Neidhardt <mail@ambrevar.xyz> napisa=C5=82(a):

> Can you share the complete recipe?
>

Yes. I guess you want a patch of my entire work so far, because
pjproject-jami is meaningless without changes in jami, so I'm attaching=
the whole patch. Also the commit messages are messy, any advice how
should they look?


Thanks for working on this. I can shar= e some recommendations on the commit messages and structuring
cha= nges. While developing, feel free to do however it is convenient for you.
Then before sumitting:
If I see it correctly, then three= packages are involved, so this should be three commits.
When= adding a new package make that a separate commit.
Make it one co= mmit, the final version. (You can squash commits together to make it one.)<= /div>
The commit message there should be in the form:
gnu: Ad= d <package>.
=C2=A0When updating a package, you can mak= e that a single commit.
Commit message should be:
gnu: = <package>: Update to <version>.

If any= thing else is done besides updating the version, mention that in the commit= message.
You can find examples in the git log of guix, like for = commit: af561664b8191e2a34570176422f4d500d5fd4fb

O= ne further thing: If you order the patches, then the earlier patches can ma= ke it to upstream before the rest of the series.
For example libr= esample could be incorporated eariler, reducing the amount of code on the b= ranch.

Thanks so much for working on Jami, and hap= py hacking!


Jan Wielkiewicz

Best regards,
g_b= or
--
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:C= F63:0B21
--0000000000005d1c4d0596826ccd--