From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Patch file for colorize module Date: Sun, 27 May 2018 17:49:42 +0200 Message-ID: References: <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net> <7290013c-990d-3f7d-d8db-38e090ed766a@swecha.net> <87zi28kt82.fsf@elephly.net> <8573e97d-d107-cde6-cd17-35f4ef6d2de3@swecha.net> <87k1takumm.fsf@elephly.net> <87o9hycwl6.fsf@elephly.net> <87r2mhdeap.fsf@elephly.net> <618c131c-6ba6-e525-aefc-72acca1c910f@swecha.net> <87a7suwtp7.fsf@elephly.net> <149bfb8c-22b5-797d-e88a-ca4077b0a4cc@swecha.net> <87d0xmok8e.fsf@elephly.net> <87k1rsb9ex.fsf@elephly.net> <3e099b0b-e3ec-2bbb-6d10-5b7e48c4dff6@swecha.net> <300fd917-6742-3ef1-044d-4b0f38a44250@swecha.net> <87a7sm4v5j.fsf@elephly.net> <3d5eca09-7730-bd38-265b-7942d0ea16ed@swecha.net> <878t864i59.fsf@elephly.net> <929437a3-bd56-9098-2577-c69f69b01a28@swecha.net> <877enq3yhx.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000177fac056d31f356" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMxvW-0007EK-RY for guix-devel@gnu.org; Sun, 27 May 2018 11:49:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMxvW-000328-1z for guix-devel@gnu.org; Sun, 27 May 2018 11:49:46 -0400 In-Reply-To: <877enq3yhx.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: Sahithi , Guix-devel --000000000000177fac056d31f356 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-05-26 23:20 GMT+02:00 Ricardo Wurmus : > > Hi Sahithi, > > > I went wrong in squashing. Please check the current attachment. > > Thank you. > > I=E2=80=99ve made a couple of minor changes and pushed it to the branch > =E2=80=9Cwip-sahithi=E2=80=9D. Nice, so now here is a branch where we can see this work. Thanks! I am happy that Sahithi is making progress. > These are some of the changes: > > * Removed whitespace changes and trailing whitespace. > * Moved the docstring of =E2=80=9Ccolorize-string=E2=80=9D to the correct= position. > * Changed the author of the commit from =E2=80=9Croot=E2=80=9D to you. > > You can run =E2=80=9Cgit fetch origin=E2=80=9D and then base your next wo= rk on > =E2=80=9Corigin/wip-sahithi=E2=80=9D. > > If you have any questions about the next steps please feel free to ask > us. > > -- > Ricardo > > > --000000000000177fac056d31f356 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -05-26 23:20 GMT+02:00 Ricardo Wurmus <rekado@elephly.net>:=

Hi Sahithi,

> I went wrong in squashing. Please check the current attachment.

Thank you.

I=E2=80=99ve made a couple of minor changes and pushed it to the branch
=E2=80=9Cwip-sahithi=E2=80=9D.=C2=A0

Nice,= so now here is a branch where we can see this work. Thanks!

=
I am happy that=C2=A0Sahithi is making= progress.
=C2=A0
Thes= e are some of the changes:

* Removed whitespace changes and trailing whitespace.
* Moved the docstring of =E2=80=9Ccolorize-string=E2=80=9D to the correct p= osition.
* Changed the author of the commit from =E2=80=9Croot=E2=80=9D to you.

You can run =E2=80=9Cgit fetch origin=E2=80=9D and then base your next work= on
=E2=80=9Corigin/wip-sahithi=E2=80=9D.

If you have any questions about the next steps please feel free to ask
us.

--
Ricardo



--000000000000177fac056d31f356--