From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Subject: Re: Restarting 'staging' Date: Sat, 16 Jun 2018 20:59:54 +0200 Message-ID: References: <87zhzzqyys.fsf@fastmail.com> <877en0uvz7.fsf@elephly.net> <87lgbf58rb.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000281cc0056ec6f0e0" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUGQX-000697-74 for guix-devel@gnu.org; Sat, 16 Jun 2018 14:59:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUGQW-0007jH-7d for guix-devel@gnu.org; Sat, 16 Jun 2018 14:59:57 -0400 Received: from mail-it0-x234.google.com ([2607:f8b0:4001:c0b::234]:52416) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUGQW-0007iW-22 for guix-devel@gnu.org; Sat, 16 Jun 2018 14:59:56 -0400 Received: by mail-it0-x234.google.com with SMTP id m194-v6so7010803itg.2 for ; Sat, 16 Jun 2018 11:59:55 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: Guix-devel --000000000000281cc0056ec6f0e0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-06-16 12:58 GMT+02:00 G=C3=A1bor Boskovits : > > > Ricardo Wurmus ezt =C3=ADrta (id=C5=91pont: 2018. j= =C3=BAn. 16., > Szo 12:25): > >> >> Hi G=C3=A1bor, >> >> > Ricardo Wurmus ezt =C3=ADrta (id=C5=91pont: 2018.= j=C3=BAn. 15., >> P >> > 21:20): >> > >> >> >> >> Hi Marius, >> >> >> >> > Now that 'core-updates' is merged, it's time to get 'staging' rolli= ng >> >> > again. We have lots of minor updates this round, mostly on the >> >> > graphical side. Is there anything we're missing that's eligible >> (<1200 >> >> > rebuilds)? >> >> >> >> The ant-build-system needs to be modified to raise an exception on te= st >> >> failures. Currently it uses the old (zero? (system* =E2=80=A6)) idio= m, which >> >> causes failing tests to be ignored. >> >> >> >> This will cause all Java packages and packages depending on them to b= e >> >> rebuilt. >> [=E2=80=A6] >> > >> > I intend to have a look at that. I've already figured out how to modif= y >> the >> > timestamps phase, the rest should be similar. I'm under the impression >> > however that this could be done on master. All java is around 160 >> packages. >> >> I have just made these changes to the ant-build-system (see attached >> patch). Can you combine this with your changes and push them to >> =E2=80=9Cstaging=E2=80=9D? >> >> It is true that all of Java in Guix is only about 160 packages, but this >> affects the three JDK packages, which take a long time to build. It >> also re-enables tests for packages whose test failures were previously >> ignored by accident. >> >> So I expect some minor breakage, which I would like to leave out of >> master. >> >> >> >> -- >> Ricardo >> > > Ok will do later today. > >> Done. Actually you had all the modifications, so I pushed this as is. Please update me if breakage occurs. Ludo also noted that (utime jar 0 0) is most probably not needed in strip-jar-timestamps. Should we remove that? --000000000000281cc0056ec6f0e0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -06-16 12:58 GMT+02:00 G=C3=A1bor Boskovits <boskovits@gmail.com&g= t;:

Ricardo= Wurmus <rekado@= elephly.net> ezt =C3=ADrta (id=C5=91pont: 2018. j=C3=BAn. 16., Szo 1= 2:25):

Hi G=C3=A1bor,

> Ricardo Wurmus <rekado@elephly.net> ezt =C3=ADrta (id=C5=91p= ont: 2018. j=C3=BAn. 15., P
> 21:20):
>
>>
>> Hi Marius,
>>
>> > Now that 'core-updates' is merged, it's time to g= et 'staging' rolling
>> > again.=C2=A0 We have lots of minor updates this round, mostly= on the
>> > graphical side.=C2=A0 Is there anything we're missing tha= t's eligible (<1200
>> > rebuilds)?
>>
>> The ant-build-system needs to be modified to raise an exception on= test
>> failures.=C2=A0 Currently it uses the old (zero? (system* =E2=80= =A6)) idiom, which
>> causes failing tests to be ignored.
>>
>> This will cause all Java packages and packages depending on them t= o be
>> rebuilt.
[=E2=80=A6]
>
> I intend to have a look at that. I've already figured out how to m= odify the
> timestamps phase, the rest should be similar. I'm under the impres= sion
> however that this could be done on master. All java is around 160 pack= ages.

I have just made these changes to the ant-build-system (see attached
patch).=C2=A0 Can you combine this with your changes and push them to
=E2=80=9Cstaging=E2=80=9D?

It is true that all of Java in Guix is only about 160 packages, but this affects the three JDK packages, which take a long time to build.=C2=A0 It also re-enables tests for packages whose test failures were previously
ignored by accident.

So I expect some minor breakage, which I would like to leave out of
master.



--
Ricardo

Ok will do later today.

Done. Actually you = had all the modifications, so I pushed this as is.
Please update me if breakage occurs. Ludo also noted that=C2=A0
(utime jar 0 0) is most probably not needed in= strip-jar-timestamps. Should we remove that?

--000000000000281cc0056ec6f0e0--