From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 02/13] gnu: python: Add sqlite input. Date: Fri, 21 Nov 2014 07:11:25 -0600 Message-ID: References: <1416548468-28421-1-git-send-email-bavier@member.fsf.org> <1416548468-28421-3-git-send-email-bavier@member.fsf.org> <8761e89a2v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=bcaec51b1805a3904505085e2e11 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrnzo-0000VJ-Ej for guix-devel@gnu.org; Fri, 21 Nov 2014 08:11:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xrnzi-0008Mx-Jz for guix-devel@gnu.org; Fri, 21 Nov 2014 08:11:32 -0500 In-Reply-To: <8761e89a2v.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: Guix-devel , Eric Bavier --bcaec51b1805a3904505085e2e11 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Nov 21, 2014 at 3:28 AM, Ludovic Court=C3=A8s wrote: > Eric Bavier skribis: > > > * gnu/packages/patches/python-sqlite-3.8.4-test-fix.patch, > > gnu/packages/patches/python2-sqlite-3.8.4-test-fix.patch: New patches= . > > * gnu-system.am (dist_patch_DATA): Add them. > > * gnu/packages/python.scm (python-2)[source]: Add patch. > > [inputs]: Add sqlite. > > (python)[source]: Add patch. > > [...] > > > @@ -167,6 +171,7 @@ > > `(("bzip2" ,bzip2) > > ("gdbm" ,gdbm) > > ("libffi" ,libffi) ; for ctypes > > + ("sqlite" ,(@ (gnu packages databases) sqlite)) ; prevent > circular refs > > Unfortunately, that doesn=E2=80=99t prevent anything: it=E2=80=99s roughl= y equivalent to > having #:use-module (gnu packages databases). > Interesting, ok. I thought I'd seem some other such comment elsewhere, but maybe I'm mistaken. > However, maybe the circular dependency is not a problem here. Does > =E2=80=9Cmake clean-go && make=E2=80=9D succeed? > It does succeed, yes. So maybe it isn't a problem. I'll remove that bit. Thanks. `~Eric --=20 Please avoid sending me Word or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html --bcaec51b1805a3904505085e2e11 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Nov 21, 2014 at 3:28 AM, Ludovic Court=C3=A8s <ludo@gnu.org>= wrote:
Eric Bavier <ericbavier@gmail.com> skribis:

> * gnu/packages/patches/python-sqlite-3.8.4-test-fix.patch,
>=C2=A0 =C2=A0gnu/packages/patches/python2-sqlite-3.8.4-test-fix.patch: = New patches.
> * gnu-system.am= (dist_patch_DATA): Add them.
> * gnu/packages/python.scm (python-2)[source]: Add patch.
>=C2=A0 =C2=A0[inputs]: Add sqlite.
>=C2=A0 =C2=A0(python)[source]: Add patch.

[...]

> @@ -167,6 +171,7 @@
>=C2=A0 =C2=A0 =C2=A0 =C2=A0`(("bzip2" ,bzip2)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0("gdbm" ,gdbm)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0("libffi" ,libffi)=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0; for ctypes
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("sqlite" ,(@ (gnu packages data= bases) sqlite)) ; prevent circular refs

Unfortunately, that doesn=E2=80=99t prevent anything: it=E2=80=99s r= oughly equivalent to
having #:use-module (gnu packages databases).

Interesting, ok.=C2=A0 I thought I'd seem some other such commen= t elsewhere, but maybe I'm mistaken.
=C2=A0
However, maybe the circular dependency is not a problem here.=C2=A0 Does =E2=80=9Cmake clean-go && make=E2=80=9D succeed?

It does succeed, yes.=C2=A0 So may= be it isn't a problem.=C2=A0 I'll remove that bit.=C2=A0 Thanks.
`~Eric

--
Please avoid = sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-= word-attachments.html
--bcaec51b1805a3904505085e2e11--