Re: [PATCH] gnu: Add perl-parallel-forkmanager.

[Ra <ilpuccio.febo@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 4208 bytes --]

Hi Marius,

On Thu, Jan 12, 2017 at 9:27 PM Marius Bakke <mbakke@fastmail.com> wrote:

> Ra <ilpuccio.febo@gmail.com> writes:
>
> >     * gnu/packages/perl.scm (perl-parallel-forkmanager): New variable.
>
> Thanks! This looks mostly good, see comments below. Can you send an
> updated patch that also includes copyright information? Thanks in
> advance!
>
> > ---
> >  gnu/packages/perl.scm | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
> > index 8f103ec..532e360 100644
> > --- a/gnu/packages/perl.scm
> > +++ b/gnu/packages/perl.scm
> > @@ -7770,3 +7770,29 @@ interface to File::Find::Object.")
> >    (description "Test::TrailingSpace tests for trailing spaces
> >  in Perl source files.")
> >    (license x11)))
> > +
> > +(define-public perl-parallel-forkmanager
>
> There is a pledge at the top of perl.scm asking to add packages in
> alphabetic order. Can you adjust the location of this expression
> accordingly?
>
> > +  (package
> > +    (name "perl-parallel-forkmanager")
> > +    (version "1.19")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (string-append
> > +
>  "mirror://cpan/authors/id/Y/YA/YANICK/Parallel-ForkManager-"
> > +             version
> > +             ".tar.gz"))
> > +       (sha256
> > +        (base32
> > +         "0wm4wp6p3ah5z212jl12728z68nmxmfr0f03z1jpvdzffnc2xppi"))))
> > +    (build-system perl-build-system)
> > +    (native-inputs
> > +     `(("perl-test-warn" ,perl-test-warn)))
> > +    (home-page
> > +     "http://search.cpan.org/dist/Parallel-ForkManager")
> > +    (synopsis
> > +     "A simple parallel processing fork manager")
>
> Synopsis should not start with an article. `guix lint` will complain
> about this ;-)
>
> Also, the line breaks after home-page and synopsis are not necessary.
>
> > +  (description "Parallel::ForkManager is intended for use in
>                    ^^^
>                    Please use @code{Parallel::ForkManager} here.
>
> > +operations that can be done in parallel where the number of
> > +processes to be forked off should be limited.")
> > +  (license (package-license perl))))
>
> Otherwise LGTM!
>
Thanks for helping me in creating a right patch.
I think I did everything, below and attached the patch.

* gnu/packages/perl.scm (perl-parallel-forkmanager): New variable.
---
 gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 8f103ec..4e8ed9a 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
 ;;; Copyright © 2016 Ben Woodcroft <donttrustben@gmail.com>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
+;;; Copyright @ 2017 Raoul J.P. Bonnal <ilpuccio.febo@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5014,6 +5015,30 @@ show those variables which are in scope at the point
of the call.  PadWalker
 is particularly useful for debugging.")
     (license (package-license perl))))

+(define-public perl-parallel-forkmanager
+  (package
+    (name "perl-parallel-forkmanager")
+    (version "1.19")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/Y/YA/YANICK/Parallel-ForkManager-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0wm4wp6p3ah5z212jl12728z68nmxmfr0f03z1jpvdzffnc2xppi"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-warn" ,perl-test-warn)))
+    (home-page "http://search.cpan.org/dist/Parallel-ForkManager")
+    (synopsis "Simple parallel processing fork manager")
+    (description "@code{Parallel::ForkManager} is intended for use in
+operations that can be done in parallel where the number of
+processes to be forked off should be limited.")
+  (license (package-license perl))))
+
 (define-public perl-params-util
   (package
     (name "perl-params-util")
--
1.9.1

Ciao
--
Ra

[-- Attachment #1.2: Type: text/html, Size: 7217 bytes --]

[-- Attachment #2: 0001-gnu-Add-perl-parallel-forkmanager.patch --]
[-- Type: application/octet-stream, Size: 1970 bytes --]

From 86dbdc6d5097115b393d9df2fbb2139fc7ae48b0 Mon Sep 17 00:00:00 2001
From: Raoul Jean Pierre Bonnal <ilpuccio.febo@gmail.com>
Date: Fri, 13 Jan 2017 00:29:23 +0100
Subject: [PATCH] gnu: Add perl-parallel-forkmanager.

* gnu/packages/perl.scm (perl-parallel-forkmanager): New variable.
---
 gnu/packages/perl.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 8f103ec..4e8ed9a 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
 ;;; Copyright © 2016 Ben Woodcroft <donttrustben@gmail.com>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
+;;; Copyright @ 2017 Raoul J.P. Bonnal <ilpuccio.febo@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5014,6 +5015,30 @@ show those variables which are in scope at the point of the call.  PadWalker
 is particularly useful for debugging.")
     (license (package-license perl))))
 
+(define-public perl-parallel-forkmanager
+  (package
+    (name "perl-parallel-forkmanager")
+    (version "1.19")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/Y/YA/YANICK/Parallel-ForkManager-"
+             version
+             ".tar.gz"))
+       (sha256
+        (base32
+         "0wm4wp6p3ah5z212jl12728z68nmxmfr0f03z1jpvdzffnc2xppi"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-test-warn" ,perl-test-warn)))
+    (home-page "http://search.cpan.org/dist/Parallel-ForkManager")
+    (synopsis "Simple parallel processing fork manager")
+    (description "@code{Parallel::ForkManager} is intended for use in
+operations that can be done in parallel where the number of
+processes to be forked off should be limited.")
+  (license (package-license perl))))
+
 (define-public perl-params-util
   (package
     (name "perl-params-util")
-- 
1.9.1