From mboxrd@z Thu Jan  1 00:00:00 1970
From: huang ying <huang.ying.caritas@gmail.com>
Subject: Re: [PATCH -v2 2/2] guix: profiles: create fonts.dir/scale for all
	fonts directories
Date: Wed, 8 Mar 2017 15:44:47 +0800
Message-ID: <CAC=cRTPtPu0Te-Gzeb7F1rNOuyd1+t7N5LFSQ4t_nBdAqAY9Xg@mail.gmail.com>
References: <20170307110749.31614-1-huang.ying.caritas@gmail.com>
	<20170307110749.31614-2-huang.ying.caritas@gmail.com>
	<20170307212452.2ddda246@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46880)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <huang.ying.caritas@gmail.com>) id 1clWHB-0006Ms-4r
	for guix-devel@gnu.org; Wed, 08 Mar 2017 02:44:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <huang.ying.caritas@gmail.com>) id 1clWHA-0003Va-8D
	for guix-devel@gnu.org; Wed, 08 Mar 2017 02:44:49 -0500
Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:32991)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <huang.ying.caritas@gmail.com>)
	id 1clWHA-0003VW-3f
	for guix-devel@gnu.org; Wed, 08 Mar 2017 02:44:48 -0500
Received: by mail-qk0-x22a.google.com with SMTP id y76so50842787qkb.0
	for <guix-devel@gnu.org>; Tue, 07 Mar 2017 23:44:47 -0800 (PST)
In-Reply-To: <20170307212452.2ddda246@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

On Wed, Mar 8, 2017 at 4:24 AM, Danny Milosavljevic
<dannym@scratchpost.org> wrote:
> Hi,
>
>> +                            (with-directory-excursion dir
>> +                              (and (file-exists? fonts-scale-file)
>> +                                   (delete-file fonts-scale-file))
>> +                              (and (file-exists? fonts-dir-file)
>> +                                   (delete-file fonts-dir-file))
>> +                              (system* mkfontscale)
>> +                              (system* mkfontdir)
>
> Please do not throw away the status code here (result of system*). You can check for okayness by (zero? (system* ...)).

Then what is the intended behavior?  abort the build process with
message and non-zero exit code?  Usually we will raise a exception or
just display some message and exit?

Best Regards,
Huang, Ying