From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id C0PGN9lfeWAkfQAAgWs5BA (envelope-from ) for ; Fri, 16 Apr 2021 11:58:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id g0hiLdlfeWDSVAAAB5/wlQ (envelope-from ) for ; Fri, 16 Apr 2021 09:58:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7601B1E785 for ; Fri, 16 Apr 2021 11:58:49 +0200 (CEST) Received: from localhost ([::1]:47250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXLFQ-0007Fd-7j for larch@yhetil.org; Fri, 16 Apr 2021 05:58:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXLFI-0007FV-3w for guix-devel@gnu.org; Fri, 16 Apr 2021 05:58:40 -0400 Received: from mail-vk1-xa30.google.com ([2607:f8b0:4864:20::a30]:38777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXLFF-0004uy-Tp for guix-devel@gnu.org; Fri, 16 Apr 2021 05:58:39 -0400 Received: by mail-vk1-xa30.google.com with SMTP id x4so5843372vkx.5 for ; Fri, 16 Apr 2021 02:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HoAJEsHkPiloOOzY76Wrwd0QxN62TfSJL8yBNJ3DIxA=; b=OB0XXU9qSsrGnf9qKSTLcNSgjwd0QaEP7W0IcGgK/Y2VgCABuHVSM+lXuUPfqFILEu FEU/qNGd8Re3lcqoKd0Ma2k6gb0Q5GfZoqx3/HUCgZoWFiqACDvUFANcVedOIviIj271 h9ULoskN1kNYlZMo8qIV1NeanTzZQos9xDa0t5n4tbknRGNoTtB0io2FjFQMKgR8EJBI EElX5YS1KcpNvbPrjyzuwyZDMF/74Ky7PzyjwqDfRPBbPVnS5v/2Np8nuuT/X2kQHpmz S43wqTVAAJxBx/V4QrM+aIQfLKOEtAHsKF6Vp5OK7jnHgMWaLSCqxgpVn5y4RYzzv2db v+Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HoAJEsHkPiloOOzY76Wrwd0QxN62TfSJL8yBNJ3DIxA=; b=g2M/i1RVid0A1RNUJJh8vhPfTm4yPR3DyWY0HewXpVM/PQavbRAnV31gKz74NPNVf/ ItOmd01aTZsYWp2AoUewLwwu1VNXKl1jcgCmRxusVdiplbsZo8wEJ63G9CsWacFTYU8b IqZtcnctTDQKMC3AhqgMNRB9gI8Q+wucnbh5E7qoZUc4yBCJn6KpZlkmsjBEfglWl/kz pyoj08C+8eDBixjCWGAWf4+CC7KymwRfpJ9k63fV8/+OaIYHA94qYEIRngwl3xxCUxqI P3OxwalxOi0Ukvxryjg4h9+fge1ICncuxeB3UmMremNgShrdGpqkKixJ2GeAqdc4tzXJ AEIQ== X-Gm-Message-State: AOAM532K+5uEkHYObDz52f6aCg+BCATw6ZUIb8zrlT5YdDv1MKL8D33p ota9cNr7P16RAd0ak902aCbIH+s7ZQU2Aw+mH20= X-Google-Smtp-Source: ABdhPJyiEkEzVizlU3W2ytQw8TB8T8zcsl2OhCZeRZ76qCEioPpA1VEAnvzJyMQOkv2tmzXELRwob5MWmaTRV8eurnc= X-Received: by 2002:a1f:c507:: with SMTP id v7mr5772517vkf.12.1618567116636; Fri, 16 Apr 2021 02:58:36 -0700 (PDT) MIME-Version: 1.0 References: <79d3d2e5c1386b1e162f1ba8380562720131856d.camel@telenet.be> <87tuo7xljp.fsf@cbaines.net> In-Reply-To: <87tuo7xljp.fsf@cbaines.net> From: Canan Talayhan Date: Fri, 16 Apr 2021 12:58:00 +0300 Message-ID: Subject: Re: [Outreachy] - Guix Data Service - Set a more informative page title To: Christopher Baines Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::a30; envelope-from=canan.t.talayhan@gmail.com; helo=mail-vk1-xa30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618567129; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HoAJEsHkPiloOOzY76Wrwd0QxN62TfSJL8yBNJ3DIxA=; b=MWtJWKXfXcsqydiQH3qdrypKvP3PPEwQzB5X4W7PbnaQaqu4kMhG4DAMNidde5YtpoYUlU snKiXEVqIediUIjXgRFJautTgXgfE5LJbNXqK2mWsjVBFCJDf8QxJ2W1HdXQZoN7iVaVa0 yiRYKuT/mIMFYC9XOrSPF/APnlkVvr63rVYPzwOf/oVFWJzaMCvdNV7/kZrESMWDtQssfT eutBGwqvqBxOWENQ/0BI0czX+Johs0Kw9oGfkChQxZ4kcl05/artLvS0nDqCWFSmwOfGjo UtrwGRh+vb6zrsvBfp6idzc3Aa7lG60+6VL/fAb0u3pw6tXGasnvU8AuG3ZVOw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618567129; a=rsa-sha256; cv=none; b=SL9zrTgb3m1li0ebMAmNv4un3HQNMLQKRz2H8q6pNciK8aTmcZTzNR0u/v0bqDQ9XIWuvu Ro3D2bETIgsBnhOy6iwR+F7Gt/tyAnNz80b1WmRs4nORNU7SP3aX/z82MzgxtWEapFNt3C XO2mutHn+6qwUfCNe/lR2QE4weF2fNlAYhDYIx2vDCNjhQX14r8vxKo+g3PZjqKku0GAsA 72z0bnONxqDpLJEbg1Uak+NK704Clz5CTKmiRgDd+o4jQ8Lm+bTMll1sslCFiZDK/s+ZAB DNFKMFPGa+W7Pl5NxKqI3nSdd4eWBISlSF5DkhmsXZJirD9p5s8DHSFzMGXqcw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=OB0XXU9q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.14 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=OB0XXU9q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 7601B1E785 X-Spam-Score: -3.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: z8BOdhoaeZiW Hi again, @Chris After your suggestions, I've fixed the patch. But for the revision part, I have a question. You said "I'd put "Channel News Entries" first, then the Revision bit second." There are so many titles like this structure in Revision views. For example : ->System tests Revision c7d0441 or ->Revision c7d0441 System tests Should I fix all of them this way? Or just for Channel News Entries? I've set the rule for 80 chars. Thanks. :) On Fri, Apr 16, 2021 at 12:52 AM Christopher Baines wrote: > > > Canan Talayhan writes: > > > Hi team, > > > > Thanks for your help. > > > > @Chris > > After all the modifications that I've made according to your comments, > > I've created the latest version of my patch. > > Could you please review the patch attached and share your ideas? > > > > Please note that a few parts are left. After your confirmation, I can > > handle it shortly. > > Thanks Canan, I've had a quick look: > > > +(define page-header "Dumps") > > + > > (define (view-dumps available-dumps) > > (layout > > + #:title > > + page-header > > #:body > > `(,(header) > > (div > > @@ -31,7 +35,7 @@ > > (@ (class "row")) > > (div > > (@ (class "col-sm-12")) > > - (h1 "Database dumps"))) > > + (h1 ,page-header))) > > I'd generally stick with more descriptive titles, "Database dumps" is > far clearer than "Dumps" in this case. > > > + (define page-header "Recent Events") > > + > > (layout > > + #:title > > + page-header > > #:body > > `(,(header) > > (div > > @@ -200,7 +208,7 @@ > > (@ (class "col-sm-12")) > > (a (@ (href "/jobs")) > > (h3 "Jobs")) > > - (h1 "Recent events"))) > > + (h1 ,page-header))) > > The capitalisation used here "events" rather than "Events" is > intentional, I wouldn't change it while looking at the titles at least. > > > (define (view-job job-id query-parameters log) > > + (define page-header "Job") > > + > > (layout > > + #:title > > + (string-append page-header " " job-id) > > #:body > > `(,(header) > > (div > > @@ -339,7 +356,7 @@ > > (@ (class "row")) > > (div > > (@ (class "col-sm-12")) > > - (h1 "Job " ,job-id))) > > + (h1 ,page-header ," " ,job-id))) > > I'd be tempted to combine the Job string and the job-id then use it for > both the #:title and h1 element. > > > + (string-append page-header " " (string-take commit-hash 7) " Channel News Entries") > > This title looks good, I'd put the more specific bits nearer the start > though, so I'd put "Channel News Entries" first, then the Revision bit > second. Also, watch out for the line length, I'd indent this so it's not > longer than 80 lines.