From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hashe Subject: Re: [PATCH] gnu: Add exempi and eog. Date: Wed, 15 Jul 2015 23:28:42 -0500 Message-ID: References: <87d1zttn0q.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=e89a8ff1cac8a06ada051af681db Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFams-000528-VP for guix-devel@gnu.org; Thu, 16 Jul 2015 00:28:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFamp-0004wt-Oe for guix-devel@gnu.org; Thu, 16 Jul 2015 00:28:46 -0400 Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:36066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFamp-0004wN-97 for guix-devel@gnu.org; Thu, 16 Jul 2015 00:28:43 -0400 Received: by pdjr16 with SMTP id r16so37095437pdj.3 for ; Wed, 15 Jul 2015 21:28:42 -0700 (PDT) In-Reply-To: <87d1zttn0q.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org --e89a8ff1cac8a06ada051af681db Content-Type: multipart/alternative; boundary=e89a8ff1cac8a06ad2051af681d9 --e89a8ff1cac8a06ad2051af681d9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks to everyone for the reviews! I got boost working and changed everything that was requested. I've attached updated patches for both. Thanks, David On Wed, Jul 15, 2015 at 11:15 AM, Mark H Weaver wrote: > David Hashe writes: > > > The attached patches add Eye of GNOME and one of its dependencies, > > exempi. The Eye of GNOME (eog) patch depends on the exempi patch. > > I agree with the comments by Ricardo and =E5=AE=8B=E6=96=87=E6=AD=A6, and= have a few > additional comments: > > > From cf0f69390f00852b9971e88e5e817ca540264d88 Mon Sep 17 00:00:00 2001 > > From: David Hashe > > Date: Wed, 15 Jul 2015 01:02:02 -0500 > > Subject: [PATCH] gnu: Add exempi. > > > > * gnu/packages/freedesktop.scm (exempi): New variable. > > --- > > gnu/packages/freedesktop.scm | 45 > ++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > > > diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.sc= m > > index eeb97cd..93a4470 100644 > > --- a/gnu/packages/freedesktop.scm > > +++ b/gnu/packages/freedesktop.scm > > @@ -4,6 +4,7 @@ > > ;;; Copyright =C2=A9 2015 Andy Wingo > > ;;; Copyright =C2=A9 2015 Ludovic Court=C3=A8s > > ;;; Copyright =C2=A9 2015 Ricardo Wurmus > > +;;; Copyright =C2=A9 2015 David Hashe > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -40,6 +41,7 @@ > > #:use-module (gnu packages xdisorg) > > #:use-module (gnu packages xorg) > > #:use-module (gnu packages doxygen) > > + #:use-module (gnu packages compression) > > #:use-module (gnu packages libffi)) > > > > (define-public xdg-utils > > @@ -232,3 +234,46 @@ display server running on Linux kernel modesetting > and evdev input devices, an X > > application, or a wayland client itself. The clients can be tradition= al > > applications, X servers (rootless or fullscreen) or other display > servers.") > > (license license:x11))) > > + > > +(define-public exempi > > + (package > > + (name "exempi") > > + (version (string-append "2.2.2")) > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url " > http://anongit.freedesktop.org/git/exempi.git") > > + (commit version))) > > + (sha256 > > + (base32 > > + > "1z25wij89fn86bm38d9ahhzfq8a2sgxaphdc4lrpyq87dgb766q9")) > > + (file-name (string-append name "-" version)))) > > If we had used the git checkout, the file-name should end with > "-checkout", but we should use the release tarball instead. > > > + (build-system gnu-build-system) > > + (arguments > > + ;; FIXME: tests depend on boost, but unable to find headers wh= en > > + ;; used as an input > > + `(#:configure-flags '("--disable-unittest") > > + #:phases (alist-cons-after > > + 'unpack 'fix-autogen > > + (lambda _ > > + (substitute* "autogen.sh" > > + ;; autogen.sh tries to run configure before we > > + ;; are able to patch it > > + (("^.*topsrcdir/configure.*$") ""))) > > + (alist-cons-before > > + 'configure 'autogen > > + (lambda _ > > + (zero? (system* "./autogen.sh"))) > > + %standard-phases)))) > > Autogen/autoreconf/bootstrap phases should always go after 'unpack' (or > in this case, after 'fix-autogen'), *not* before 'configure'. The > reason is that there are some other phases (patch-usr-bin-file and > patch-source-shebangs) which should have access to the generated files. > For example, letting 'patch-usr-bin-file' patch the generated > 'configure' is important on some platforms. > > However, this is moot because you should use the release tarball. > > Can you send updated patches? > > Thanks, > Mark > On Wed, Jul 15, 2015 at 11:15 AM, Mark H Weaver wrote: > David Hashe writes: > > > The attached patches add Eye of GNOME and one of its dependencies, > > exempi. The Eye of GNOME (eog) patch depends on the exempi patch. > > I agree with the comments by Ricardo and =E5=AE=8B=E6=96=87=E6=AD=A6, and= have a few > additional comments: > > > From cf0f69390f00852b9971e88e5e817ca540264d88 Mon Sep 17 00:00:00 2001 > > From: David Hashe > > Date: Wed, 15 Jul 2015 01:02:02 -0500 > > Subject: [PATCH] gnu: Add exempi. > > > > * gnu/packages/freedesktop.scm (exempi): New variable. > > --- > > gnu/packages/freedesktop.scm | 45 > ++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > > > diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.sc= m > > index eeb97cd..93a4470 100644 > > --- a/gnu/packages/freedesktop.scm > > +++ b/gnu/packages/freedesktop.scm > > @@ -4,6 +4,7 @@ > > ;;; Copyright =C2=A9 2015 Andy Wingo > > ;;; Copyright =C2=A9 2015 Ludovic Court=C3=A8s > > ;;; Copyright =C2=A9 2015 Ricardo Wurmus > > +;;; Copyright =C2=A9 2015 David Hashe > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -40,6 +41,7 @@ > > #:use-module (gnu packages xdisorg) > > #:use-module (gnu packages xorg) > > #:use-module (gnu packages doxygen) > > + #:use-module (gnu packages compression) > > #:use-module (gnu packages libffi)) > > > > (define-public xdg-utils > > @@ -232,3 +234,46 @@ display server running on Linux kernel modesetting > and evdev input devices, an X > > application, or a wayland client itself. The clients can be tradition= al > > applications, X servers (rootless or fullscreen) or other display > servers.") > > (license license:x11))) > > + > > +(define-public exempi > > + (package > > + (name "exempi") > > + (version (string-append "2.2.2")) > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url " > http://anongit.freedesktop.org/git/exempi.git") > > + (commit version))) > > + (sha256 > > + (base32 > > + > "1z25wij89fn86bm38d9ahhzfq8a2sgxaphdc4lrpyq87dgb766q9")) > > + (file-name (string-append name "-" version)))) > > If we had used the git checkout, the file-name should end with > "-checkout", but we should use the release tarball instead. > > > + (build-system gnu-build-system) > > + (arguments > > + ;; FIXME: tests depend on boost, but unable to find headers wh= en > > + ;; used as an input > > + `(#:configure-flags '("--disable-unittest") > > + #:phases (alist-cons-after > > + 'unpack 'fix-autogen > > + (lambda _ > > + (substitute* "autogen.sh" > > + ;; autogen.sh tries to run configure before we > > + ;; are able to patch it > > + (("^.*topsrcdir/configure.*$") ""))) > > + (alist-cons-before > > + 'configure 'autogen > > + (lambda _ > > + (zero? (system* "./autogen.sh"))) > > + %standard-phases)))) > > Autogen/autoreconf/bootstrap phases should always go after 'unpack' (or > in this case, after 'fix-autogen'), *not* before 'configure'. The > reason is that there are some other phases (patch-usr-bin-file and > patch-source-shebangs) which should have access to the generated files. > For example, letting 'patch-usr-bin-file' patch the generated > 'configure' is important on some platforms. > > However, this is moot because you should use the release tarball. > > Can you send updated patches? > > Thanks, > Mark > --e89a8ff1cac8a06ad2051af681d9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks to everyone for the reviews!

I got boost working and changed everything that was requested. I'= ve attached updated patches for both.

Thanks,
David

On We= d, Jul 15, 2015 at 11:15 AM, Mark H Weaver <mhw@netris.org> wro= te:
David Hashe <david.hashe@dhashe.com> writes= :

> The attached patches add Eye of GNOME and one of its dependencies,
> exempi. The Eye of GNOME (eog) patch depends on the exempi patch.

I agree with the comments by Ricardo and =E5=AE=8B=E6=96=87=E6=AD=A6= , and have a few
additional comments:

> From cf0f69390f00852b9971e88e5e817ca540264d88 Mon Sep 17 00:00:00 2001=
> From: David Hashe <david.= hashe@dhashe.com>
> Date: Wed, 15 Jul 2015 01:02:02 -0500
> Subject: [PATCH] gnu: Add exempi.
>
> * gnu/packages/freedesktop.scm (exempi): New variable.
> ---
>=C2=A0 gnu/packages/freedesktop.scm | 45 ++++++++++++++++++++++++++++++= ++++++++++++++
>=C2=A0 1 file changed, 45 insertions(+)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.s= cm
> index eeb97cd..93a4470 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -4,6 +4,7 @@
>=C2=A0 ;;; Copyright =C2=A9 2015 Andy Wingo <wingo@pobox.com>
>=C2=A0 ;;; Copyright =C2=A9 2015 Ludovic Court=C3=A8s <ludo@gnu.org>
>=C2=A0 ;;; Copyright =C2=A9 2015 Ricardo Wurmus <rekado@elephly.net>
> +;;; Copyright =C2=A9 2015 David Hashe <david.hashe@dhashe.com>
>=C2=A0 ;;;
>=C2=A0 ;;; This file is part of GNU Guix.
>=C2=A0 ;;;
> @@ -40,6 +41,7 @@
>=C2=A0 =C2=A0 #:use-module (gnu packages xdisorg)
>=C2=A0 =C2=A0 #:use-module (gnu packages xorg)
>=C2=A0 =C2=A0 #:use-module (gnu packages doxygen)
> +=C2=A0 #:use-module (gnu packages compression)
>=C2=A0 =C2=A0 #:use-module (gnu packages libffi))
>
>=C2=A0 (define-public xdg-utils
> @@ -232,3 +234,46 @@ display server running on Linux kernel modesettin= g and evdev input devices, an X
>=C2=A0 application, or a wayland client itself.=C2=A0 The clients can b= e traditional
>=C2=A0 applications, X servers (rootless or fullscreen) or other displa= y servers.")
>=C2=A0 =C2=A0 =C2=A0 (license license:x11)))
> +
> +(define-public exempi
> +=C2=A0 =C2=A0 (package
> +=C2=A0 =C2=A0 =C2=A0 (name "exempi")
> +=C2=A0 =C2=A0 =C2=A0 (version (string-append "2.2.2"))
> +=C2=A0 =C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fe= tch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-refe= rence
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(url "http://anongit.freedesktop.org/git/ex= empi.git")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(commit version)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"1= z25wij89fn86bm38d9ahhzfq8a2sgxaphdc4lrpyq87dgb766q9"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (st= ring-append name "-" version))))

If we had used the git checkout, the file-name should end with
"-checkout", but we should use the release tarball instead.

> +=C2=A0 =C2=A0 =C2=A0 (build-system gnu-build-system)
> +=C2=A0 =C2=A0 =C2=A0 (arguments
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; FIXME: tests depend on boost, but unab= le to find headers when
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; used as an input
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0`(#:configure-flags '("--disable-= unittest")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases (alist-cons-after
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0'unpack 'fix-autogen
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(lambda _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(substitute* "autogen.sh"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 ;; autogen.sh tries to run configure before we
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 ;; are able to patch it
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (("^.*topsrcdir/configure.*$") "")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (alist-cons-before
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= 'configure 'autogen
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (lambda _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(zero? (system* "./autogen.sh")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0%standard-phases))))

Autogen/autoreconf/bootstrap phases should always go after 'unpa= ck' (or
in this case, after 'fix-autogen'), *not* before 'configure'= ;.=C2=A0 The
reason is that there are some other phases (patch-usr-bin-file and
patch-source-shebangs) which should have access to the generated files.
For example, letting 'patch-usr-bin-file' patch the generated
'configure' is important on some platforms.

However, this is moot because you should use the release tarball.

Can you send updated patches?

=C2=A0 =C2=A0 =C2=A0Thanks,
=C2=A0 =C2=A0 =C2=A0 =C2=A0Mark

<= br>
On Wed, Jul 15, 2015 at 11:15 AM, Mark H Weav= er <mhw@netris.org> wrote:
David Hashe <da= vid.hashe@dhashe.com> writes:

> The attached patches add Eye of GNOME and one of its dependencies,
> exempi. The Eye of GNOME (eog) patch depends on the exempi patch.

I agree with the comments by Ricardo and =E5=AE=8B=E6=96=87=E6=AD=A6= , and have a few
additional comments:

> From cf0f69390f00852b9971e88e5e817ca540264d88 Mon Sep 17 00:00:00 2001=
> From: David Hashe <david.= hashe@dhashe.com>
> Date: Wed, 15 Jul 2015 01:02:02 -0500
> Subject: [PATCH] gnu: Add exempi.
>
> * gnu/packages/freedesktop.scm (exempi): New variable.
> ---
>=C2=A0 gnu/packages/freedesktop.scm | 45 ++++++++++++++++++++++++++++++= ++++++++++++++
>=C2=A0 1 file changed, 45 insertions(+)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.s= cm
> index eeb97cd..93a4470 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -4,6 +4,7 @@
>=C2=A0 ;;; Copyright =C2=A9 2015 Andy Wingo <wingo@pobox.com>
>=C2=A0 ;;; Copyright =C2=A9 2015 Ludovic Court=C3=A8s <ludo@gnu.org>
>=C2=A0 ;;; Copyright =C2=A9 2015 Ricardo Wurmus <rekado@elephly.net>
> +;;; Copyright =C2=A9 2015 David Hashe <david.hashe@dhashe.com>
>=C2=A0 ;;;
>=C2=A0 ;;; This file is part of GNU Guix.
>=C2=A0 ;;;
> @@ -40,6 +41,7 @@
>=C2=A0 =C2=A0 #:use-module (gnu packages xdisorg)
>=C2=A0 =C2=A0 #:use-module (gnu packages xorg)
>=C2=A0 =C2=A0 #:use-module (gnu packages doxygen)
> +=C2=A0 #:use-module (gnu packages compression)
>=C2=A0 =C2=A0 #:use-module (gnu packages libffi))
>
>=C2=A0 (define-public xdg-utils
> @@ -232,3 +234,46 @@ display server running on Linux kernel modesettin= g and evdev input devices, an X
>=C2=A0 application, or a wayland client itself.=C2=A0 The clients can b= e traditional
>=C2=A0 applications, X servers (rootless or fullscreen) or other displa= y servers.")
>=C2=A0 =C2=A0 =C2=A0 (license license:x11)))
> +
> +(define-public exempi
> +=C2=A0 =C2=A0 (package
> +=C2=A0 =C2=A0 =C2=A0 (name "exempi")
> +=C2=A0 =C2=A0 =C2=A0 (version (string-append "2.2.2"))
> +=C2=A0 =C2=A0 =C2=A0 (source (origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fe= tch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-refe= rence
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(url "http://anongit.freedesktop.org/git/ex= empi.git")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(commit version)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"1= z25wij89fn86bm38d9ahhzfq8a2sgxaphdc4lrpyq87dgb766q9"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (st= ring-append name "-" version))))

If we had used the git checkout, the file-name should end with
"-checkout", but we should use the release tarball instead.

> +=C2=A0 =C2=A0 =C2=A0 (build-system gnu-build-system)
> +=C2=A0 =C2=A0 =C2=A0 (arguments
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; FIXME: tests depend on boost, but unab= le to find headers when
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; used as an input
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0`(#:configure-flags '("--disable-= unittest")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases (alist-cons-after
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0'unpack 'fix-autogen
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(lambda _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(substitute* "autogen.sh"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 ;; autogen.sh tries to run configure before we
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 ;; are able to patch it
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (("^.*topsrcdir/configure.*$") "")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (alist-cons-before
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= 'configure 'autogen
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (lambda _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(zero? (system* "./autogen.sh")))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0%standard-phases))))

Autogen/autoreconf/bootstrap phases should always go after 'unpa= ck' (or
in this case, after 'fix-autogen'), *not* before 'configure'= ;.=C2=A0 The
reason is that there are some other phases (patch-usr-bin-file and
patch-source-shebangs) which should have access to the generated files.
For example, letting 'patch-usr-bin-file' patch the generated
'configure' is important on some platforms.

However, this is moot because you should use the release tarball.

Can you send updated patches?

=C2=A0 =C2=A0 =C2=A0Thanks,
=C2=A0 =C2=A0 =C2=A0 =C2=A0Mark

--e89a8ff1cac8a06ad2051af681d9-- --e89a8ff1cac8a06ada051af681db Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-Add-exempi.patch" Content-Disposition: attachment; filename="0001-gnu-Add-exempi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ic5oun0y0 RnJvbSAwNzVmZDdkODE0MDU2MWFmZTAzYWJhOGVlYjgxMzUwMDFlMGVkODM2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBIYXNoZSA8ZGF2aWQuaGFzaGVAZGhhc2hlLmNvbT4K RGF0ZTogV2VkLCAxNSBKdWwgMjAxNSAyMzoxNTo0NSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogQWRkIGV4ZW1waS4KCiogZ251L3BhY2thZ2VzL2ZyZWVkZXNrdG9wLnNjbSAoZXhlbXBpKTog TmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9mcmVlZGVza3RvcC5zY20gfCA0NSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDQ1IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZnJlZWRlc2t0b3Au c2NtIGIvZ251L3BhY2thZ2VzL2ZyZWVkZXNrdG9wLnNjbQppbmRleCBlZWI5N2NkLi5iNGMzNzBm IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvZnJlZWRlc2t0b3Auc2NtCisrKyBiL2dudS9wYWNr YWdlcy9mcmVlZGVza3RvcC5zY20KQEAgLTQsNiArNCw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIw MTUgQW5keSBXaW5nbyA8d2luZ29AcG9ib3guY29tPgogOzs7IENvcHlyaWdodCDCqSAyMDE1IEx1 ZG92aWMgQ291cnTDqHMgPGx1ZG9AZ251Lm9yZz4KIDs7OyBDb3B5cmlnaHQgwqkgMjAxNSBSaWNh cmRvIFd1cm11cyA8cmVrYWRvQGVsZXBobHkubmV0PgorOzs7IENvcHlyaWdodCDCqSAyMDE1IERh dmlkIEhhc2hlIDxkYXZpZC5oYXNoZUBkaGFzaGUuY29tPgogOzs7CiA7OzsgVGhpcyBmaWxlIGlz IHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTM5LDYgKzQwLDggQEAKICAgIzp1c2UtbW9kdWxl IChnbnUgcGFja2FnZXMgZ2xpYikgICAgICAgICAgICAgICAgO2ludGx0b29sCiAgICM6dXNlLW1v ZHVsZSAoZ251IHBhY2thZ2VzIHhkaXNvcmcpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2Vz IHhvcmcpCisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGJvb3N0KQorICAjOnVzZS1tb2R1 bGUgKGdudSBwYWNrYWdlcyBjb21wcmVzc2lvbikKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgZG94eWdlbikKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgbGliZmZpKSkKIApAQCAt MjMyLDMgKzIzNSw0NSBAQCBkaXNwbGF5IHNlcnZlciBydW5uaW5nIG9uIExpbnV4IGtlcm5lbCBt b2Rlc2V0dGluZyBhbmQgZXZkZXYgaW5wdXQgZGV2aWNlcywgYW4gWAogYXBwbGljYXRpb24sIG9y IGEgd2F5bGFuZCBjbGllbnQgaXRzZWxmLiAgVGhlIGNsaWVudHMgY2FuIGJlIHRyYWRpdGlvbmFs CiBhcHBsaWNhdGlvbnMsIFggc2VydmVycyAocm9vdGxlc3Mgb3IgZnVsbHNjcmVlbikgb3Igb3Ro ZXIgZGlzcGxheSBzZXJ2ZXJzLiIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTp4MTEpKSkKKworKGRl ZmluZS1wdWJsaWMgZXhlbXBpCisgIChwYWNrYWdlCisgICAgKG5hbWUgImV4ZW1waSIpCisgICAg KHZlcnNpb24gIjIuMi4yIikKKyAgICAoc291cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAobWV0 aG9kIHVybC1mZXRjaCkKKyAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kCisgICAgICAg ICAgICAgICAgICAgImh0dHA6Ly9saWJvcGVucmF3LmZyZWVkZXNrdG9wLm9yZy9kb3dubG9hZC8i CisgICAgICAgICAgICAgICAgICAgbmFtZSAiLSIgdmVyc2lvbiAiLnRhci5iejIiKSkKKyAgICAg ICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICIw MXZjZDFtZm4yczBpaXEyY2p5emd2bnh4NmtjcTljd3JhMWlpcGlqaHMwdnd2angweWhmIikpKSkK KyAgICAoYnVpbGQtc3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCisgICAgKGFyZ3VtZW50cworICAg ICBgKCM6Y29uZmlndXJlLWZsYWdzIChsaXN0IChzdHJpbmctYXBwZW5kICItLXdpdGgtYm9vc3Q9 IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhc3NvYy1yZWYgJWJ1aWxkLWlucHV0 cyAiYm9vc3QiKSkpCisgICAgICAgIzpwaGFzZXMgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBo YXNlcworICAgICAgICAgICAgICAgICAoYWRkLWFmdGVyCisgICAgICAgICAgICAgICAgICAndW5w YWNrICdmaXgtYXV0b2dlbgorICAgICAgICAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAg ICAgICAgICAgKHN1YnN0aXR1dGUqICJhdXRvZ2VuLnNoIgorICAgICAgICAgICAgICAgICAgICA7 OyBhdXRvZ2VuLnNoIHRyaWVzIHRvIHJ1biBjb25maWd1cmUgYmVmb3JlIHdlCisgICAgICAgICAg ICAgICAgICAgIDs7IGFyZSBhYmxlIHRvIHBhdGNoIGl0CisgICAgICAgICAgICAgICAgICAgICgo Il4uKnRvcHNyY2Rpci9jb25maWd1cmUuKiQiKSAiIikpKSkKKyAgICAgICAgICAgICAgICAgKGFk ZC1hZnRlcgorICAgICAgICAgICAgICAgICAgJ2ZpeC1hdXRvZ2VuICdhdXRvZ2VuCisgICAgICAg ICAgICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAgICAgICAoemVybz8gKHN5c3RlbSog InNoIiAiLi9hdXRvZ2VuLnNoIikpKSkpKSkKKyAgICAobmF0aXZlLWlucHV0cworICAgICBgKCgi YXV0b2NvbmYiICxhdXRvY29uZikKKyAgICAgICAoImF1dG9tYWtlIiAsYXV0b21ha2UpCisgICAg ICAgKCJsaWJ0b29sIiAsbGlidG9vbCkKKyAgICAgICAoImJvb3N0IiAsYm9vc3QpKSkKKyAgICAo aW5wdXRzCisgICAgIGAoKCJleHBhdCIgLGV4cGF0KQorICAgICAgICgiemxpYiIgLHpsaWIpKSkK KyAgICAoaG9tZS1wYWdlICJodHRwczovL3dpa2kuZnJlZWRlc2t0b3Aub3JnL2xpYm9wZW5yYXcv RXhlbXBpIikKKyAgICAoc3lub3BzaXMgIlhNUCBtZXRhZGF0YSBoYW5kbGluZyBsaWJyYXJ5IikK KyAgICAoZGVzY3JpcHRpb24gIkV4ZW1waSBpcyBhbiBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgRXh0 ZW5zaWJsZSBNZXRhZGF0YQorUGxhdGZvcm0gKFhNUCksIHdoaWNoIGVuYWJsZXMgZW1iZWRkaW5n IG1ldGFkYXRhIGluIFBERiBhbmQgaW1hZ2UgZm9ybWF0cy4iKQorICAgIChsaWNlbnNlIGxpY2Vu c2U6YnNkLTMpKSkKLS0gCjEuOS4xCgo= --e89a8ff1cac8a06ada051af681db Content-Type: text/x-patch; charset=US-ASCII; name="0002-gnu-Add-eog.patch" Content-Disposition: attachment; filename="0002-gnu-Add-eog.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ic5ousis1 RnJvbSAzOGRmYWQ0OTMxYTI5MDIyNjgyMjQ4OTQ4YTM4MjBhYzNmNDUwMjdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBIYXNoZSA8ZGF2aWQuaGFzaGVAZGhhc2hlLmNvbT4K RGF0ZTogV2VkLCAxNSBKdWwgMjAxNSAyMjo1MjoyMiAtMDUwMApTdWJqZWN0OiBbUEFUQ0ggMi8y XSBnbnU6IEFkZCBlb2cuCgoqIGdudS9wYWNrYWdlcy9nbm9tZS5zY20gKGVvZyk6IE5ldyB2YXJp YWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvZ25vbWUuc2NtIHwgNTEgKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA1MSBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2dub21lLnNjbSBiL2dudS9wYWNr YWdlcy9nbm9tZS5zY20KaW5kZXggODc5YzI3ZS4uYWM5MDIzMSAxMDA2NDQKLS0tIGEvZ251L3Bh Y2thZ2VzL2dub21lLnNjbQorKysgYi9nbnUvcGFja2FnZXMvZ25vbWUuc2NtCkBAIC02MSw2ICs2 MSw3IEBACiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGx1YSkKICAgIzp1c2UtbW9kdWxl IChnbnUgcGFja2FnZXMgaW1hZ2UpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBlcmwp CisgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHBob3RvKQogICAjOnVzZS1tb2R1bGUgKGdu dSBwYWNrYWdlcyBwa2ctY29uZmlnKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBwdWxz ZWF1ZGlvKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBweXRob24pCkBAIC0zMDAxLDMg KzMwMDIsNTMgQEAgd2hpY2ggY2FuIHJlYWQgYSBsYXJnZSBudW1iZXIgb2YgZmlsZSBmb3JtYXRz LiIpCiAgICAoZGVzY3JpcHRpb24gIlJoeXRobWJveCBpcyBhIG11c2ljIHBsYXlpbmcgYXBwbGlj YXRpb24gZm9yIEdOT01FLiAgSXQKIHN1cHBvcnRzIHBsYXlsaXN0cywgc29uZyByYXRpbmdzLCBh bmQgYW55IGNvZGVjcyBpbnN0YWxsZWQgdGhyb3VnaCBnc3RyZWFtZXIuIikKICAgIChsaWNlbnNl IGxpY2Vuc2U6Z3BsMispKSkKKworKGRlZmluZS1wdWJsaWMgZW9nCisgKHBhY2thZ2UKKyAgIChu YW1lICJlb2ciKQorICAgKHZlcnNpb24gIjMuMTYuMiIpCisgICAoc291cmNlIChvcmlnaW4KKyAg ICAgICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgKHVyaSAoc3RyaW5nLWFw cGVuZCAibWlycm9yOi8vZ25vbWUvc291cmNlcy8iIG5hbWUgIi8iCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICh2ZXJzaW9uLW1ham9yK21pbm9yIHZlcnNpb24pICIvIgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBuYW1lICItIiB2ZXJzaW9uICIudGFyLnh6IikpCisg ICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgKGJhc2UzMgorICAgICAgICAgICAgICAi MGZydzFiNWppeDlwZmZ6bmF2NXM3YWpqeDkxYThydjVsZjRzanZqdjNmdzY1bWJuaGJ3MCIpKSkp CisgICAoYnVpbGQtc3lzdGVtIGdsaWItb3ItZ3RrLWJ1aWxkLXN5c3RlbSkKKyAgIChhcmd1bWVu dHMKKyAgICBgKCM6cGhhc2VzCisgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2Vz CisgICAgICAgIChhZGQtYWZ0ZXIKKyAgICAgICAgICdpbnN0YWxsICd3cmFwLWVvZworICAgICAg ICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAg ICAobGV0ICgob3V0ICAgICAgICAgICAgICAgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkKKyAg ICAgICAgICAgICAgICAgKGdpLXR5cGVsaWItcGF0aCAgIChnZXRlbnYgIkdJX1RZUEVMSUJfUEFU SCIpKSkKKyAgICAgICAgICAgICAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5kIG91dCAiL2Jp bi9lb2ciKQorICAgICAgICAgICAgICAgYCgiR0lfVFlQRUxJQl9QQVRIIiAiOiIgcHJlZml4ICgs Z2ktdHlwZWxpYi1wYXRoKSkpKQorICAgICAgICAgICAjdCkpKSkpCisgICAocHJvcGFnYXRlZC1p bnB1dHMKKyAgICBgKCgiZGNvbmYiICxkY29uZikpKQorICAgKG5hdGl2ZS1pbnB1dHMKKyAgICBg KCgiaW50bHRvb2wiICxpbnRsdG9vbCkKKyAgICAgICgiZ2xpYiIgLGdsaWIgImJpbiIpCisgICAg ICAoImdvYmplY3QtaW50cm9zcGVjdGlvbiIgLGdvYmplY3QtaW50cm9zcGVjdGlvbikKKyAgICAg ICgicGtnLWNvbmZpZyIgLHBrZy1jb25maWcpKSkKKyAgIChpbnB1dHMKKyAgICBgKCgiZ25vbWUt ZGVza3RvcCIgLGdub21lLWRlc2t0b3ApCisgICAgICAoInNoYXJlZC1taW1lLWluZm8iICxzaGFy ZWQtbWltZS1pbmZvKQorICAgICAgKCJpdHN0b29sIiAsaXRzdG9vbCkKKyAgICAgICgiYWR3YWl0 YS1pY29uLXRoZW1lIiAsYWR3YWl0YS1pY29uLXRoZW1lKQorICAgICAgKCJleGVtcGkiICxleGVt cGkpCisgICAgICAoImxjbXMiICxsY21zKQorICAgICAgKCJsaWJleGlmIiAsbGliZXhpZikKKyAg ICAgICgibGlicGVhcyIgLGxpYnBlYXMpCisgICAgICAoImxpYmpwZWciICxsaWJqcGVnKQorICAg ICAgKCJsaWJyc3ZnIiAsbGlicnN2ZykKKyAgICAgICgiZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1h cyIgLGdzZXR0aW5ncy1kZXNrdG9wLXNjaGVtYXMpCisgICAgICAoImd0aysiICxndGsrKSkpCisg ICAoaG9tZS1wYWdlICJodHRwczovL3dpa2kuZ25vbWUub3JnL0FwcHMvRXllT2ZHbm9tZSIpCisg ICAoc3lub3BzaXMgIkdOT01FIGltYWdlIHZpZXdlciIpCisgICAoZGVzY3JpcHRpb24gIkV5ZSBv ZiBHTk9NRSBpcyB0aGUgR05PTUUgaW1hZ2Ugdmlld2VyLiAgSXQKK3N1cHBvcnRzIGltYWdlIGNv bnZlcnNpb24sIHJvdGF0aW9uLCBhbmQgc2xpZGVzaG93cy4iKQorICAgKGxpY2Vuc2UgbGljZW5z ZTpncGwyKykpKQotLSAKMS45LjEKCg== --e89a8ff1cac8a06ada051af681db--