From: David Hashe <david.hashe@dhashe.com>
To: 宋文武 <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add gtksourceview.
Date: Sun, 8 Nov 2015 11:16:48 -0600 [thread overview]
Message-ID: <CAAn-YqFEsesmXDfJMG6njtgi2uZzwSOdDhYLtGSXrMjS_Sbuog@mail.gmail.com> (raw)
In-Reply-To: <87wptsvgt9.fsf@member.fsf.org>
[-- Attachment #1.1: Type: text/plain, Size: 2444 bytes --]
On Sun, Nov 8, 2015 at 6:03 AM, 宋文武 <iyzsong@member.fsf.org> wrote:
> David Hashe <david.hashe@dhashe.com> writes:
>
> > * gnu/packages/gnome.scm (gtksourceview): New variable.
> > ---
> > gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++
> > 1 file changed, 34 insertions(+)
> >
> > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> > index 5440433..9bd1c31 100644
> > --- a/gnu/packages/gnome.scm
> > +++ b/gnu/packages/gnome.scm
> > @@ -3659,3 +3659,37 @@ environment that allows users to view, unpack,
> and create compressed archives
> > such as gzip tarballs.")
> > (home-page "http://fileroller.sourceforge.net/")
> > (license license:gpl2+)))
> > +
> > +(define-public gtksourceview
> > + (package
> > + (name "gtksourceview")
> > + (version "3.16.1")
> Why not use the latest stable 3.18.x?
>
Changed to 3.18.1.
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append "mirror://gnome/sources/" name "/"
> > + (version-major+minor version) "/"
> > + name "-" version ".tar.xz"))
> > + (sha256
> > + (base32
> > + "030v7x1dmx5blqi9jcknsjd91jppbpl7f4z69k8c8kklr939i7k6"))))
> > + (build-system glib-or-gtk-build-system)
> > + (arguments
> > + '(#:tests? #f)) ; Tries to open graphical display during testing
> and fails
> > + (native-inputs
> > + `(("intltool" ,intltool)
> > + ("itstool", itstool)
> > + ("gobject-introspection" ,gobject-introspection)
> > + ("pkg-config" ,pkg-config)))
> > + (inputs
> > + `(("glib" ,glib)
> > + ("gtk+" ,gtk+)
> > + ("libxml2" ,libxml2)
> > + ("pango" ,pango)
> > + ("gdk-pixbuf" ,gdk-pixbuf)
> > + ("vala" ,vala)))
> > + (home-page "https://wiki.gnome.org/Projects/GtkSourceView ")
> extra space ^
> > + (synopsis "GNOME source code widget")
> > + (description "GtkSourceView is a text widget that extends the
> standard
> > +GTK+ text widget GtkTextView. It improves GtkTextView by implementing
> syntax
> We use two spaces after period ^
>
Fixed.
> > +highlighting and other features typical of a source code editor.")
> > + (license license:lgpl2.1+)))
>
>
Thanks for the feedback! I've attached an updated patch.
[-- Attachment #1.2: Type: text/html, Size: 4031 bytes --]
[-- Attachment #2: 0001-gnu-Add-gtksourceview.patch --]
[-- Type: text/x-patch, Size: 2023 bytes --]
From 06f8964dc426acd4edb70d31132982e0c1d5dca9 Mon Sep 17 00:00:00 2001
From: David Hashe <david.hashe@dhashe.com>
Date: Sat, 7 Nov 2015 22:38:09 -0600
Subject: [PATCH 1/3] gnu: Add gtksourceview.
* gnu/packages/gnome.scm (gtksourceview): New variable.
---
gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 5440433..9c4b182 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3659,3 +3659,37 @@ environment that allows users to view, unpack, and create compressed archives
such as gzip tarballs.")
(home-page "http://fileroller.sourceforge.net/")
(license license:gpl2+)))
+
+(define-public gtksourceview
+ (package
+ (name "gtksourceview")
+ (version "3.18.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1rpdg8rcjlqv8yk13vsh5148mads0zbfih8cak3hm7wb0spmzsbv"))))
+ (build-system glib-or-gtk-build-system)
+ (arguments
+ '(#:tests? #f)) ; Tries to open graphical display during testing and fails
+ (native-inputs
+ `(("intltool" ,intltool)
+ ("itstool", itstool)
+ ("gobject-introspection" ,gobject-introspection)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("libxml2" ,libxml2)
+ ("pango" ,pango)
+ ("gdk-pixbuf" ,gdk-pixbuf)
+ ("vala" ,vala)))
+ (home-page "https://wiki.gnome.org/Projects/GtkSourceView ")
+ (synopsis "GNOME source code widget")
+ (description "GtkSourceView is a text widget that extends the standard
+GTK+ text widget GtkTextView. It improves GtkTextView by implementing syntax
+highlighting and other features typical of a source code editor.")
+ (license license:lgpl2.1+)))
--
1.9.1
next prev parent reply other threads:[~2015-11-08 17:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 5:18 [PATCH 1/2] gnu: Add gtksourceview David Hashe
2015-11-08 5:18 ` [PATCH 2/2] gnu: Add gedit David Hashe
2015-11-08 12:06 ` 宋文武
2015-11-08 17:20 ` David Hashe
2015-11-08 20:07 ` David Hashe
2015-11-09 6:48 ` 宋文武
2015-11-08 12:03 ` [PATCH 1/2] gnu: Add gtksourceview 宋文武
2015-11-08 17:16 ` David Hashe [this message]
2015-11-08 17:47 ` John Darrington
2015-11-08 17:53 ` Efraim Flashner
2015-11-08 20:05 ` David Hashe
2015-11-09 5:59 ` 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAn-YqFEsesmXDfJMG6njtgi2uZzwSOdDhYLtGSXrMjS_Sbuog@mail.gmail.com \
--to=david.hashe@dhashe.com \
--cc=guix-devel@gnu.org \
--cc=iyzsong@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).