From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hashe Subject: Re: [PATCH 1/2] gnu: Add freealut. Date: Mon, 21 Mar 2016 16:44:40 -0500 Message-ID: References: <1458370575-388-1-git-send-email-david.hashe@dhashe.com> <87egb334ol.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a114386ac30becb052e960263 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai7dG-0006D1-KB for guix-devel@gnu.org; Mon, 21 Mar 2016 17:45:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai7dF-0000rm-0z for guix-devel@gnu.org; Mon, 21 Mar 2016 17:45:02 -0400 Received: from mail-vk0-x243.google.com ([2607:f8b0:400c:c05::243]:35920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai7dE-0000rh-Pu for guix-devel@gnu.org; Mon, 21 Mar 2016 17:45:00 -0400 Received: by mail-vk0-x243.google.com with SMTP id z68so5361616vkg.3 for ; Mon, 21 Mar 2016 14:45:00 -0700 (PDT) In-Reply-To: <87egb334ol.fsf@mdc-berlin.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --001a114386ac30becb052e960263 Content-Type: multipart/alternative; boundary=001a114386ac30bec5052e960261 --001a114386ac30bec5052e960261 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Mar 21, 2016 at 4:24 PM, Ricardo Wurmus < ricardo.wurmus@mdc-berlin.de> wrote: > > David Hashe writes: > > >> I see that Arch and Fedora both use the tarball from here: > >> > >> > >> > http://pkgs.fedoraproject.org/repo/pkgs/freealut/freealut-1.1.0.tar.gz/e0= 89b28a0267faabdb6c079ee173664a/freealut-1.1.0.tar.gz > >> > >> The advantage of that tarball is that it doesn=E2=80=99t require boots= trapping, > >> so you can do without the additional =E2=80=9Cautogen=E2=80=9D phase a= nd without the > >> three native inputs. > >> > > > > Done. By the way, where exactly do you find what tarball Arch and Fedor= a > > use for a given package? I couldn't seem to find that information on a > > cursory glance. > > I looked at the PKGBUILD of the Arch package. > > >> Does Freealut itself have a home page? It doesn=E2=80=99t seem right = to me to > >> declare the website of OpenAL as the home page, when the package is > >> really just one implemenatation of the standard published on the OpenA= L > >> website. > >> > >> > > I agree, but it doesn't seem to have a separate home page. Debian simpl= y > > lists the home page as "http://www.openal.org/", for instance. I could > set > > the field to #f, but guix lint complains about that and it looks like > only > > the bootstrap-binaries actually do that. For now, I've added a comment > > clarifying the situation. > > That=E2=80=99s good, thanks. > > The patch looks pretty good to me now, except maybe for this > > + (uri > + (let ((name-version-tar > + (string-append name "-" version ".tar.gz"))) > + (string-append > + "http://pkgs.fedoraproject.org/repo/pkgs/" name "/" > + name-version-tar "/" > + "e089b28a0267faabdb6c079ee173664a/" > + name-version-tar))) > > I find the let binding a bit too ... much :) But if nobody else has a > problem with this, I wouldn=E2=80=99t complain. > Yeah... I wasn't sure if it made things better or worse. I've gone ahead and removed it, since it might be a bit more readable that way. > > Thanks! > > ~~ Ricardo > - David --001a114386ac30bec5052e960261 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Mon, Mar 21, 2016 at 4:24 PM, Ricardo Wurmus <<= a href=3D"mailto:ricardo.wurmus@mdc-berlin.de" target=3D"_blank">ricardo.wu= rmus@mdc-berlin.de> wrote:
=
David Hashe <david.hashe@dhash= e.com> writes:

>> I see that Arch and Fedora both use the tarball from here:
>>
>>
>> http://pkgs.fedoraproject.org/repo/pkgs/f= reealut/freealut-1.1.0.tar.gz/e089b28a0267faabdb6c079ee173664a/freealut-1.1= .0.tar.gz
>>
>> The advantage of that tarball is that it doesn=E2=80=99t require b= ootstrapping,
>> so you can do without the additional =E2=80=9Cautogen=E2=80=9D pha= se and without the
>> three native inputs.
>>
>
> Done. By the way, where exactly do you find what tarball Arch and Fedo= ra
> use for a given package? I couldn't seem to find that information = on a
> cursory glance.

I looked at the PKGBUILD of the Arch package.

>> Does Freealut itself have a home page?=C2=A0 It doesn=E2=80=99t se= em right to me to
>> declare the website of OpenAL as the home page, when the package i= s
>> really just one implemenatation of the standard published on the O= penAL
>> website.
>>
>>
> I agree, but it doesn't seem to have a separate home page. Debian = simply
> lists the home page as "http://www.openal.org/", for instan= ce. I could set
> the field to #f, but guix lint complains about that and it looks like = only
> the bootstrap-binaries actually do that. For now, I've added a com= ment
> clarifying the situation.

That=E2=80=99s good, thanks.

The patch looks pretty good to me now, except maybe for this

+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (uri
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(let ((name-version= -tar
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 (string-append name "-" version ".tar.gz")))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(string-appe= nd
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "http://pkgs.fedoraproject.org/repo/pkgs/" name "/= "
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 name-versio= n-tar "/"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "e089b= 28a0267faabdb6c079ee173664a/"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 name-versio= n-tar)))

I find the let binding a bit too ... much :)=C2=A0 But if nobody else has a=
problem with this, I wouldn=E2=80=99t complain.

Yeah... I wasn't sure if it made things better or worse. I'= ;ve gone ahead and removed it, since it might be a bit more readable that w= ay.
=C2=A0

Thanks!

~~ Ricardo

- Dav= id
--001a114386ac30bec5052e960261-- --001a114386ac30becb052e960263 Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-Add-freealut.patch" Content-Disposition: attachment; filename="0001-gnu-Add-freealut.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_im2iru790 RnJvbSAzOGJkZWM3MGQ0Y2IzY2RjM2U4MTBlZWE3YzNjNDc1YTI4OWUzY2Q0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBIYXNoZSA8ZGF2aWQuaGFzaGVAZGhhc2hlLmNvbT4K RGF0ZTogU2F0LCAxOSBNYXIgMjAxNiAwMDo1Njo1NSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogQWRkIGZyZWVhbHV0LgoKKiBnbnUvcGFja2FnZXMvYXVkaW8uc2NtIChmcmVlYWx1dCk6IE5l dyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2FnZXMvYXVkaW8uc2NtIHwgMjggKysrKysrKysrKysr KysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKykKCmRpZmYg LS1naXQgYS9nbnUvcGFja2FnZXMvYXVkaW8uc2NtIGIvZ251L3BhY2thZ2VzL2F1ZGlvLnNjbQpp bmRleCBjYTQzOGY4Li5jYmFhZDExIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvYXVkaW8uc2Nt CisrKyBiL2dudS9wYWNrYWdlcy9hdWRpby5zY20KQEAgLTQsNiArNCw3IEBACiA7OzsgQ29weXJp Z2h0IMKpIDIwMTUgQW5kcmVhcyBFbmdlIDxhbmRyZWFzQGVuZ2UuZnI+CiA7OzsgQ29weXJpZ2h0 IMKpIDIwMTUgQWxleCBLb3N0IDxhbGV6b3N0QGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkg MjAxNSwgMjAxNiBNYXJrIEggV2VhdmVyIDxtaHdAbmV0cmlzLm9yZz4KKzs7OyBDb3B5cmlnaHQg wqkgMjAxNiBEYXZpZCBIYXNoZSA8ZGF2aWQuaGFzaGVAZGhhc2hlLmNvbT4KIDs7OwogOzs7IFRo aXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0xNTA0LDYgKzE1MDUsMzMgQEAg YnVmZmVycywgYW5kIGF1ZGlvIGNhcHR1cmUuIikKICAgICAoaG9tZS1wYWdlICJodHRwOi8va2Nh dC5zdHJhbmdlc29mdC5uZXQvb3BlbmFsLmh0bWwiKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6bGdw bDIuMCspKSkKIAorKGRlZmluZS1wdWJsaWMgZnJlZWFsdXQKKyAgKHBhY2thZ2UKKyAgICAobmFt ZSAiZnJlZWFsdXQiKQorICAgICh2ZXJzaW9uICIxLjEuMCIpCisgICAgKHNvdXJjZSAob3JpZ2lu CisgICAgICAgICAgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJpIChz dHJpbmctYXBwZW5kCisgICAgICAgICAgICAgICAgICAgICJodHRwOi8vcGtncy5mZWRvcmFwcm9q ZWN0Lm9yZy9yZXBvL3BrZ3MvIiBuYW1lICIvIgorICAgICAgICAgICAgICAgICAgICBuYW1lICIt IiB2ZXJzaW9uICIudGFyLmd6LyIKKyAgICAgICAgICAgICAgICAgICAgImUwODliMjhhMDI2N2Zh YWJkYjZjMDc5ZWUxNzM2NjRhLyIKKyAgICAgICAgICAgICAgICAgICAgbmFtZSAiLSIgdmVyc2lv biAiLnRhci5neiIpKQorICAgICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFz ZTMyCisgICAgICAgICAgICAgICAgIjBremxpbDYxMTJ4MjQyOW53Nm15Y21pZjh5NmJ4cjJjd2pj dnAxOHZoNnM3ZzYzeW1sYjAiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3Rl bSkKKyAgICAoaW5wdXRzCisgICAgIGAoKCJvcGVuYWwiICxvcGVuYWwpKSkKKyAgICA7OyBUaGlz IGlzIHRoZSBob21lIHBhZ2UgZm9yIHRoZSBzcGVjaWZpY2F0aW9uLCBidXQgdGhlcmUgaXMgbm8K KyAgICA7OyBwcm9qZWN0LXNwZWNpZmljIGhvbWVwYWdlLgorICAgIChob21lLXBhZ2UgImh0dHBz Oi8vd3d3Lm9wZW5hbC5vcmcvIikKKyAgICAoc3lub3BzaXMgIkltcGxlbWVudGF0aW9uIG9mIHRo ZSBPcGVuQUwgVXRpbGl0eSBUb29sa2l0IChBTFVUKSIpCisgICAgKGRlc2NyaXB0aW9uICJGcmVl YWx1dCBpcyBhIGZyZWUgaW1wbGVtZW50YXRpb24gb2YgT3BlbkFMJ3MgQUxVVCBzdGFuZGFyZC4K K0FMVVQgaXMgdGhlIE9wZW5BTCBlcXVpdmFsZW50IHRvIEdMVVQgZm9tIE9wZW5HTCBhbmQgaGFz IGFuIGludGVudGlvbmFsbHkKK3NpbWlsYXIgQVBJLiAgSXQgaXMgaW50ZW5kZWQgdG8gYWxsb3cg ZGV2ZWxvcGVycyB0byBxdWlja2x5IGxlYXJuIE9wZW5BTCB3aGlsZQorYWJzdHJhY3RpbmcgYXdh eSBkZXRhaWxzIHN1Y2ggYXMgbG9hZGluZyBzb3VuZCBzYW1wbGVzIGZyb20gZGlzay4iKQorICAg IChsaWNlbnNlIGxpY2Vuc2U6bGdwbDIuMCspKSkKKwogKGRlZmluZS1wdWJsaWMgcGF0Y2hhZ2UK ICAgKHBhY2thZ2UKICAgICAobmFtZSAicGF0Y2hhZ2UiKQotLSAKMS45LjEKCg== --001a114386ac30becb052e960263--