From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SMxpJ9k97l8DEQAA0tVLHw (envelope-from ) for ; Thu, 31 Dec 2020 21:08:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WF0dI9k97l8HbgAAbx9fmQ (envelope-from ) for ; Thu, 31 Dec 2020 21:08:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C7589404D5 for ; Thu, 31 Dec 2020 21:08:41 +0000 (UTC) Received: from localhost ([::1]:53188 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kv5BY-00008d-7N for larch@yhetil.org; Thu, 31 Dec 2020 16:08:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kv01k-0001bT-J9 for guix-devel@gnu.org; Thu, 31 Dec 2020 10:38:12 -0500 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]:40051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kv01j-0004aR-0M for guix-devel@gnu.org; Thu, 31 Dec 2020 10:38:12 -0500 Received: by mail-io1-xd35.google.com with SMTP id r9so17414638ioo.7 for ; Thu, 31 Dec 2020 07:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FV9OiJIKnoy1ORE95oI96zVw/cOkeyuAfH2FW1Acy9U=; b=t1PaxsS9EYBlzU0Lg9UcnOKpcLW0vv6gBSEOQCfeQa5wyhLP7uXX9nL1pCU85zLlxt AYZX0tywIwekMOAExs9o9sTA1VM0Hi5JGmN8Jix84rqFYtL2j5dZE4UdJA2QdzOr9hil ws8nZuKuzbCB/CHqdpsG6Hvd0gsTcmOZpC2GlPjQjAW+0Z8Mrgn7ZpkOgUiot5rn6JiD ukzDV47Jw1X4EQGj7LkjteDTbfvP2XyIWYT4rNmEqzUCfWsBS8t4NT5Ly2kX1VQspAqF kWOagB1dCRZdOfT6MFmnacWvoiQZx98XQUZOs7vdFbHYGpJR1AE3BTaUUBhAe8QBP4HL tWiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FV9OiJIKnoy1ORE95oI96zVw/cOkeyuAfH2FW1Acy9U=; b=lVYoN1MmCuSTTVmTYP/vMa2XUa3+6zkvE+1ty0Dxa3bBW9slz96dF8BnQ1sBNO6qF2 k6qa9+ZlzNdCfOjVmfpcNguMQfknY2OAuI9LcPdai7u7vDIwepnUxSYpPKysXK7nEaWk ucbDzchjBzT7BNJAtWnSedb3IRhoKpeNw1FtWrDZySboEKo3J9oy+JSBVf/8Z8atDOmS f7sFn7v/fXRrFX/kHutgwg7XEaleV2rCaj7GK8DV2Ko1QJlpgTNI9z2i6GD6LEE4Glxd w8w97ITVcJf3QwKk9AkswF2Rpjw+HbEhV4Na2UHP5e5a9ks2Kr4iO0Y9Kxo/KN7iZU3J NfxQ== X-Gm-Message-State: AOAM532MoxzWwdJBJoGLbXg9vdk/ANxoEVJtlND3cBWdoHmEdeowluJP cr0+s1aS+MFf8a8TZ6YVi54r7cOYihOaAPZb2nHWTGd5H6s= X-Google-Smtp-Source: ABdhPJyLbINjmBcZRJRI5tnYY2RaVEM4Ap3VS9V00Varm/4ww03jS1ALGqgS8IlgZNVDSaAXfeG1XVbmVOxnH6aXkfo= X-Received: by 2002:a6b:f202:: with SMTP id q2mr46505337ioh.87.1609429089242; Thu, 31 Dec 2020 07:38:09 -0800 (PST) MIME-Version: 1.0 References: <424245f9f30e2418942a8eec27019864294550cd.camel@student.tugraz.at> In-Reply-To: <424245f9f30e2418942a8eec27019864294550cd.camel@student.tugraz.at> From: Rovanion Luckey Date: Thu, 31 Dec 2020 16:37:43 +0100 Message-ID: Subject: Re: [RFC] Package of Nomacs To: Leo Prikler Content-Type: multipart/alternative; boundary="00000000000027d5ce05b7c46935" Received-SPF: pass client-ip=2607:f8b0:4864:20::d35; envelope-from=rovanion.luckey@gmail.com; helo=mail-io1-xd35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 31 Dec 2020 16:08:31 -0500 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.03 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=t1PaxsS9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 3C7589404D5 X-Spam-Score: -3.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: nPZvl6pBaEB6 --00000000000027d5ce05b7c46935 Content-Type: text/plain; charset="UTF-8" Hi Leo and thank you for your comments. The nomacs package should probably go to gnu/packages/image- > viewers.scm. > Yup. > Use git-fetch instead and don't recurse into submodules. You will > likely encounter some errors, because it doesn't seem as though nomacs > expects you to have its inputs properly packages. *sigh* > Hmm, this one I'm not sure I understand the reasoning behind. I think I read in some packaging guidelines that url-fetch was preferred if possible. > Instead of adding the path to the source directory, try `(cd > "ImageLounge")` in a phase after 'unpack. > I'm told that cd is an unbound variable when I try that :/ #:phases (modify-phases %standard-phases (add-after 'unpack 'cd-to-source-dir (lambda _ (call-with-output-string (cd "ImageLounge"))))) Try to sort them alphabetically, also don't put too much effort into > making the tails align. > Check. > One thing that's missing is the plugins that are developed in a > > separate git repository [0] and not included in the source tarballs > > of the main repository [1]. Ideas on how to make them available in > > the `plugins` directory during build time are welcome. > A trick that's often used in Guix is > (inputs > `(("extra-source-package" > ,(origin ...))) > [other inputs]) > You can then (copy-recursively (assoc-ref inputs "extra-source- > package") destination) in a phase between 'unpack and 'configure. > Thank you! And thank you for the rest of the comments too. Happy new year! --00000000000027d5ce05b7c46935 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Leo and thank you for your comments.

=
Use git-fetch instead and don't recurse into submodules.=C2=A0 You will=
likely encounter some errors, because it doesn't seem as though nomacs<= br> expects you to have its inputs properly packages.=C2=A0 *sigh*
Hmm, this one I'm not sure I understand the reasoning behind. = I think I read in some packaging guidelines that url-fetch was preferred if= possible.
=C2=A0
Instead of adding the path to the source directory, try `(cd
"ImageLounge")` in a phase after 'unpack.
I'm told that cd is an unbound variable when I try th= at :/

=C2=A0 =C2=A0 =C2=A0=C2=A0 #:phases (modify-= phases %standard-phases
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 (add-after 'unpack 'cd-to-source-dir
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda _ (call= -with-output-string (cd "ImageLounge")))))

<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex"> Try to sort them alphabetically, also don't put too much effort into making the tails align.
Check.

> One thing that's missing is the plugins that are developed in a > separate git repository [0] and not included in the source tarballs > of the main repository [1]. Ideas on how to make them available in
> the `plugins` directory during build time are welcome.
A trick that's often used in Guix is
(inputs
=C2=A0`(("extra-source-package"
=C2=A0 =C2=A0 ,(origin ...)))
=C2=A0 =C2=A0[other inputs])
You can then (copy-recursively (assoc-ref inputs "extra-source-
package") destination) in a phase between 'unpack and 'configu= re.
=C2=A0Thank you! And thank you for the rest of the commen= ts too.

Happy new year!
--00000000000027d5ce05b7c46935--