From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +A4sMWVJU2I69wAAgWs5BA (envelope-from ) for ; Sun, 10 Apr 2022 23:17:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IEWjLmVJU2LOZgAA9RJhRA (envelope-from ) for ; Sun, 10 Apr 2022 23:17:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 675F796F9 for ; Sun, 10 Apr 2022 23:17:25 +0200 (CEST) Received: from localhost ([::1]:60240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndew0-0004DK-DH for larch@yhetil.org; Sun, 10 Apr 2022 17:17:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndevj-0004D8-Da for guix-devel@gnu.org; Sun, 10 Apr 2022 17:17:07 -0400 Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]:35497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndevh-0000rt-Hu for guix-devel@gnu.org; Sun, 10 Apr 2022 17:17:07 -0400 Received: by mail-yb1-xb36.google.com with SMTP id t67so7455485ybi.2 for ; Sun, 10 Apr 2022 14:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heykimo-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6ZOgkvrwwtUj642Ub7eL7zNPqu7LbyTddrdkSxa/p8w=; b=6AJbT4CVmiVpj0Wz5h6iBBvHqmjna7a0Atq6JKR3aVKft2RhnWhW1tAfTHjXU82XJi 6UF5CbhvdFL/YgZa2/6eTfjrZ0VdHsfUPapf725MB2bExbgPHD/5sWq3g8FtXxn31geA a52X1g/cXIj0pMowjK8G9oE9ndk8CVsYPHXyGKE2SrCkEq7NUPskj+TtEcTuFB9bmw+A D4XGJe7IbhcpQg84e6sqqBs2Qm3QZqSQ3shuxOpMwlEYt5c0gz9/MXCgBpFMhZLHDYDh TMtSfouIMTsnD5A1rxgIKNF1/EZ6Vr1iQAsuT05rwcgwA5f987G8ob13FmCX9foqootk sg0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6ZOgkvrwwtUj642Ub7eL7zNPqu7LbyTddrdkSxa/p8w=; b=HmAbnd/ZBksCKJGKnaMrnhAyZTi2QNwA/xDWyAn4bpr3wCoSAMqKaBkd438Xq7t8C0 1+DDZik6mERHL+46eVcXYV5NL0yuJQmfttBHv2FPl81BYLbqO82NSmrSS7X11a0PA5oT rn3R3ZzxoY1HrfvVgiLkeRZl6JmIzgiCWl4q4u/X2TbYMHsxq29guDeCYunAzTk4z1W9 oytOlxWlW2p/hRNsuJb0Rf4L6QB5DRu32g0X5pC/Y23o1C9Exqztsh0sCuMFTQJ4r5dI AL6F2subiOyWkxELbMU6W8TX7c8I8zMI1O9UuTYEAxn2UhABGQpinN3orgiaawc1GZWQ ov2Q== X-Gm-Message-State: AOAM531DiqUQUFhXW3R11CeIvbcR5I+WVKLqQjC9VqyR2jnJFMKGFH5d VAd8J5rHtGFge3VAhhbGtnUBMf01i9sTpn+CRevldm6izu/dbcUx X-Google-Smtp-Source: ABdhPJztkQ/tCZKeKLdNbswAQOpTNddWbViSoN/3TuG6hhIHaMZ+QzWkMXXBOj3HYtFtLfadJO2FVWvZ5VKomNoNJoM= X-Received: by 2002:a5b:dc8:0:b0:624:a898:dea6 with SMTP id t8-20020a5b0dc8000000b00624a898dea6mr19794742ybr.600.1649625423978; Sun, 10 Apr 2022 14:17:03 -0700 (PDT) MIME-Version: 1.0 References: <87k0bw4qh8.fsf@gnu.org> In-Reply-To: <87k0bw4qh8.fsf@gnu.org> From: Pier-Hugues Pellerin Date: Sun, 10 Apr 2022 17:16:53 -0400 Message-ID: Subject: Re: Updating from Go 1.17 to 1.18 To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="00000000000068b74c05dc535932" Received-SPF: none client-ip=2607:f8b0:4864:20::b36; envelope-from=ph@heykimo.com; helo=mail-yb1-xb36.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649625445; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6ZOgkvrwwtUj642Ub7eL7zNPqu7LbyTddrdkSxa/p8w=; b=Org1asOHUHLJ3sUXmI8no/rBUyWwwKhpp4WVGHCBtBKbK7UJbTXe1Ii7Sa4Pd3EY2xRy7i oh64IVvuZB/2M2CCAqMpL5UGWX6bLdjsuHDxBOvaZZ9R5cJrqrvGemcaY0RTf+xZGhJee7 OGNvmYJb9x0h6KAFQU1RPiLiIbnQ+YTZH0Zuvo3wMizwXoKyk8qECtmZdjRF1Ra8TuvhcD yjejp9y9JOdMt73smZ/eisPkd3AWcCHcaTR/CnTYaOaKFU0pnxf3e1W1jPZs2WS/LwjS9f rEvLb5gat8TIfouPg4s26/zveliSnU6pYE632eHt+BynEAIlKWCfOyTD2VswUQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649625445; a=rsa-sha256; cv=none; b=kqiRbA4QACIBEyOW4Gf/HYD332Bn0MyCtVd9zEJbTbqFLMZmn+CxUCb7Txoj2k2dX4xxrE XJjamfzesgZdkOzzooZHHCUCcKW5g5Gdjb5lqI6FDuIgdGaNzt8ZJtzEg3p15rbtWv8EaV slvCosIorYxHDK8sFBlX253HlRjmSDPWMoaY+UFBgjqLC4lC6Kv8svmM5ArgjI1QkBMx/1 0A85pOVC4Io7nUn1awL8t9klmbeRZMfmkdhC4cZduJMzktZ/nvQW8vQ5xVrn5d6GFFZM1d 33Wfdz1hgwDMdoTJnxXaJym+5wjpgUVFxHz7XF/d5vwxJRNlRkZQSCEuBJO9qg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=heykimo-com.20210112.gappssmtp.com header.s=20210112 header.b=6AJbT4CV; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.07 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=heykimo-com.20210112.gappssmtp.com header.s=20210112 header.b=6AJbT4CV; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 675F796F9 X-Spam-Score: -5.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZXpokf4B+5TM --00000000000068b74c05dc535932 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I think it makes sense, looking at the number of impacted packages and from my experience working in go, even if the contract is the same, sometimes it does break on minor. One more thing, should I do it in two patches like this? 1. Add go 1.18 inheriting from 1.17, allowing people to use 1.18 sooner? 2. Move to the default Go to 1.18 with (define-public go go-1.17) and create the testing branch from that? Thanks for the `refresh` tips. On Sun, Apr 10, 2022 at 4:45 PM Ludovic Court=C3=A8s wrote: > Hi, > > Pier-Hugues Pellerin skribis: > > > I am trying to update Go to 1.18, I do have a *working* patch that > defines > > a package that inherits from 1.17 and that adjusts the inputs. > > Nice! > > > However, I have a few questions: > > > > 1. Is inheriting the way to do that? The package's build system appears > to > > be the same from 1.17. > > 2. How can I rebuild dependents packages to ensure they are still > building > > correctly? > > 3. Anything I should look into or test more for these kinds of packages= ? > > You can define Go 1.18 inheriting from 1.17; that=E2=80=99ll allow us to = have > both versions, and eventually we=E2=80=99ll remove the older one. > > Note that, to actually migrate Go packages to 1.18, you=E2=80=99ll need t= o > additionally change this line: > > (define-public go go-1.17) > > =E2=80=98guix refresh -l go@1.17=E2=80=99 shows the =E2=80=9Ccontour=E2= =80=9D of the set of packages > that currently depend on Go 1.17. These are all the packages that need > to be rebuilt if you change the line above. Since that=E2=80=99s a lot o= f them, > we could set up a dedicated branch and have it built by ci.guix. We=E2= =80=99d > merge it once problems have been resolved. > > Does that make sense? > > Thanks, > Ludo=E2=80=99. > --=20 ph, http://heykimo.com --00000000000068b74c05dc535932 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I think it makes sens= e, looking at the number of impacted packages and from my experience workin= g
in go, even if the contract is the same, sometimes it does brea= k on minor.

One more thing, should I do it in = two patches like this?

1. Add go 1.18 inheriting f= rom 1.17, allowing people to use 1.18 sooner?
2. Move to the = default Go to 1.18 with (define-public go go-1.17) and create the testing b= ranch from that?

Thanks for the `refresh` tips= .


On Sun, Apr 10, 2022 at 4:45 PM Ludovic Court=C3= =A8s <ludo@gnu.org> wrote:
Hi,

Pier-Hugues Pellerin <ph@heykimo.com> skribis:

> I am trying to update Go to 1.18, I do have a *working* patch that def= ines
> a package that inherits from 1.17 and that adjusts the inputs.

Nice!

> However, I have a few questions:
>
> 1. Is inheriting the way to do that? The package's build system ap= pears to
> be the same from 1.17.
> 2. How can I rebuild dependents packages to ensure they are still buil= ding
> correctly?
> 3. Anything I should look into or test more for these kinds of package= s?

You can define Go 1.18 inheriting from 1.17; that=E2=80=99ll allow us to ha= ve
both versions, and eventually we=E2=80=99ll remove the older one.

Note that, to actually migrate Go packages to 1.18, you=E2=80=99ll need to<= br> additionally change this line:

=C2=A0 (define-public go go-1.17)

=E2=80=98guix refresh -l go@1.17=E2=80=99 shows the =E2=80=9Ccontour=E2=80= =9D of the set of packages
that currently depend on Go 1.17.=C2=A0 These are all the packages that nee= d
to be rebuilt if you change the line above.=C2=A0 Since that=E2=80=99s a lo= t of them,
we could set up a dedicated branch and have it built by ci.guix.=C2=A0 We= =E2=80=99d
merge it once problems have been resolved.

Does that make sense?

Thanks,
Ludo=E2=80=99.


--
--00000000000068b74c05dc535932--