From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QPX4K1zw5WWLPgAAqHPOHw:P1 (envelope-from ) for ; Mon, 04 Mar 2024 17:01:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QPX4K1zw5WWLPgAAqHPOHw (envelope-from ) for ; Mon, 04 Mar 2024 17:01:32 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=greghogan-com.20230601.gappssmtp.com header.s=20230601 header.b=bCi+IKoZ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709568092; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=VbZiEJTSPbzWQ8uZOAGMzlsq4ceUabiiKPEF+AemJ7I=; b=Cv0YwriRyt54Bev8vgpFdGi+XTHxaPCK9GPON25Zy+tst6Td/cxIDDQNq+SEuhPXy74IlZ 9hP5sOx64ve80V6L+RNYEjuDJoxrE4wdaR9HEuzLDkHaf7KDSS0paP6bAzpeMES3qcdCIF KBVuzwq9umOSaeFOHbKSGzCWkH7FCkfXdAOPzC9BuoAo0Iyo4A5ubM/i2k3L/i71PD7SiQ hhz7oJqNDK0Gz1F1LTFv7imOnr7KXRP5Toiy+TeSTKf9RIH6Xq7qlwazWPstpT8FUsL/oV YJ8iO/I7ryCBzBkqP/Cde9N22td1APs8PclcRxGEjAYfTHhNbrbYu7Kp7OIjmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=greghogan-com.20230601.gappssmtp.com header.s=20230601 header.b=bCi+IKoZ; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709568092; a=rsa-sha256; cv=none; b=S2MZO+p3zqD3NDXO0nH+Yz5yi//YhMKhiE7qHUxOU//2GNcE0hiWwN9SgATlLjhn0XKIG+ 7Gi8oCE0G5mCk0ECie3vbhEDO8k18cdyu+zgu85QmxWbJfnnF4JQIVCWNisepH6W7p4M2G FiIrVBxOdGoZkMllPNgAbZQwBLagpSbwunHgKtQ/EHNXuEd2NQ6wwAvzqD0hjq4UQiINFF vs1IgcwHq+71KE9E9kvANX6mQaN+ULLtRpdbb5L1Jdo7f/elZYX2RnGCp6tsaHx3TGfiX9 hLi8600tppiC5EIT1FTkUjFYg547R0f11vk4UGBjdZqCYAcryNZpSgCFUIm1VA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6DF5762212 for ; Mon, 4 Mar 2024 17:01:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhAkR-0002iP-Sn; Mon, 04 Mar 2024 11:01:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhAkQ-0002iE-WD for guix-devel@gnu.org; Mon, 04 Mar 2024 11:01:03 -0500 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhAkO-0005ER-Uz for guix-devel@gnu.org; Mon, 04 Mar 2024 11:01:02 -0500 Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6e4dec6f672so777702a34.1 for ; Mon, 04 Mar 2024 08:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1709568059; x=1710172859; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VbZiEJTSPbzWQ8uZOAGMzlsq4ceUabiiKPEF+AemJ7I=; b=bCi+IKoZFQrSaNXvNeldhSxfcUN+MpWt2DPTZzKFD62PEPafAhpWoczUdEaQHkBC9A AX5Y5A2W8GFe18mBWDWb2q2P4iMnxLL7VvXIYJokwtlGPBtARGJisUEp9gtrwc2oqYPa ddWcklVtkibrXJNsVudSkqt1t9tbMyr/ofsNH4Rlvlx0HAFTn4VRZ2BK/GUzKfMfb5TL 8R28c/G+qFCxRJ6p1OjshdAKhhn4ePih8sOGCSLrgF4EWSgvAVHC0F+0ZrZJsUXRPKk0 JqWksoGRknS6mJ/GRnJPs0Rhaj2KJsgUOzv2uvVf1iD796uN29yDO6M0883OY5APEjyu xisA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709568059; x=1710172859; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VbZiEJTSPbzWQ8uZOAGMzlsq4ceUabiiKPEF+AemJ7I=; b=xH+bHlT9e8+fuMsVWCOReEd5E8DsYm4w7B6BBHPzK0dHkGFONiZmA0LSiLqz0hXwmB MCm0eNnnbIYS98Ob4Z0RwEx1w3fVgV8dPyjxlI/vL7hcy1DpnK45+k1uOF+pBQrdiZaR ilSslvtOno2F751NgM+yjrfThCdA+wjSCyMp7QMJPoqFsso2QPN2Htzpgvmztw+24iOZ ysxpnefS8+X47+t471U5EB+hGDs6xX0FhMLWt1Q4+KZTmiyd0U6WxOLlIgjHPGsWlV85 hmgw6FspzF11GU1WSRScb6aXg651K+t9aZComuAQL9vnemcKvSWuhaC/T/k9nCvnYmyu txdw== X-Gm-Message-State: AOJu0Yw9wJ6qCVhxBvGEte6yBjBjt/exoAVCfzE87gj7Cd7TFy86Zioo 4UKhWZHmBvGuUibFk+6bjpSg10HJLm2jinSX75F0iVecoRwosRZm8v7iOp58ASA/oi6VWkip729 o/O3kEMmTYZIkegImfc683QGT3y5nsNotOJi3vg== X-Google-Smtp-Source: AGHT+IHhjIJ/eici5/7j/bsLaQTfwFjCt4rTpp+Oear5hKgsrU8Prts7z5jAgrgZLW6Fp6jtLillEucCzMPux0j3kwk= X-Received: by 2002:a05:6830:2b12:b0:6e4:ec4a:7785 with SMTP id l18-20020a0568302b1200b006e4ec4a7785mr1846043otv.9.1709568058654; Mon, 04 Mar 2024 08:00:58 -0800 (PST) MIME-Version: 1.0 References: <48cbd146-0645-1075-17fc-978f845c3e5a@crazy-compilers.com> In-Reply-To: <48cbd146-0645-1075-17fc-978f845c3e5a@crazy-compilers.com> From: Greg Hogan Date: Mon, 4 Mar 2024 11:00:46 -0500 Message-ID: Subject: Re: cmake-build-system: build tests only if #:tests? is true? To: Hartmut Goebel Cc: Guix-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: none client-ip=2607:f8b0:4864:20::334; envelope-from=code@greghogan.com; helo=mail-ot1-x334.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.34 X-Spam-Score: -6.34 X-Migadu-Queue-Id: 6DF5762212 X-TUID: UpnOVqmKimTO On Sat, Mar 2, 2024 at 4:17=E2=80=AFPM Hartmut Goebel wrote: > > Hi, > > I found an old and unfinished patch in my pile. It optimizes building > with cmake by not building the test if "#:tests?" is false. (Basically > it passes -DBUILD_TESTING=3DOFF/ON" depending on "#:tests?".) > > Is this of interest? Then I would take my time and finish the patch. Hi Hartmut, I have been testing a set of patches (since last summer) based on the following mailing list discussion (from 2021) to rewrite the cmake-build-system build, check, and install functions to use cmake utilities rather than depend on the gnu-build-system. This allows for parallel tests and a package-defined #:generator. https://lists.gnu.org/archive/html/guix-devel/2021-10/msg00055.html I will submit a patchset shortly for review and if accepted we can look to combine all the cmake patches for the large rebuild. Perhaps a version update for cmake-bootstrap (v3.24 released August 2022) at the same time? Greg