From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id AM9vBw85Ume+yQAA62LTzQ:P1 (envelope-from ) for ; Thu, 05 Dec 2024 23:36:47 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id AM9vBw85Ume+yQAA62LTzQ (envelope-from ) for ; Fri, 06 Dec 2024 00:36:47 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=greghogan-com.20230601.gappssmtp.com header.s=20230601 header.b="WYEyMW/d"; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733441806; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=l0GPH6zlqMTgUGoQfx8/VAiriQlZJFmW0yEZtb/hqII=; b=aRrR7BuO9iKQp5SizcfTh6+wuE4/2fExw9B0H9pbM7j7Bq69H9NNTZbLuc6oRuTBBR8RXC ht1MlXXJx3PRV3sS7/I7DBFfVJoN6guypUoLBCqDLqXifSLv/29bonC6cTHNtSaWAkwmlv C8BKzP9pVhUnVAsicaQrXqGVMdIuCl6m2Ktkg/GuYlQ9jDu0UsPPLXM7CsyqnRpka7QfYP RgGI2ugwZqQNeqkaDa6OovG15I8DxzkZo4zRXFPvkfCvvnvN+57lZYR4B/Gs6ylWiXCJkX Zuc8qMS1a5wb0LJbuWHSGw8nXVqfEwEeBdWbAgpM3k71x6jQPg9oMtK5gwBQGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=greghogan-com.20230601.gappssmtp.com header.s=20230601 header.b="WYEyMW/d"; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733441806; a=rsa-sha256; cv=none; b=b6ws0Y8A5tcI4/WZpnVBxQTb+TRTEwXJBjOMZKWpwu6Eniz6Inan8Sw7M1aAQk4krOB+Yl nl4vmHlwqHSUwvMpsJ3e3pDHBltgmgQP+CiFVhvswvyZLQIRsM48oxfbkhQbakHHVpZiWu CplKMft/hAfaWaW1XoJy5HcTOvzrnLOrDDy3RD6U4JdDEq5w0RSWhUr3Lx6ehquwGL5qqS xGu7jmHlFmeuQn52fcRvnGuaiuk1cir4Jeysq+UAmYtnRL2sySmYADoo8sQ2dQHj/2sM2D OWo6YEvq1WPjmWm32LH0TQb5IHfOfyYk9T7xZYbKUgFD/+OE+g+QbaETEV3hGg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FECF4514F for ; Fri, 06 Dec 2024 00:36:45 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJLO3-0002Ip-6N; Thu, 05 Dec 2024 18:35:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJLO0-0002FY-5t for guix-devel@gnu.org; Thu, 05 Dec 2024 18:35:56 -0500 Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJLNx-0007C9-V1 for guix-devel@gnu.org; Thu, 05 Dec 2024 18:35:55 -0500 Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-29e6399b009so714602fac.1 for ; Thu, 05 Dec 2024 15:35:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1733441751; x=1734046551; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=l0GPH6zlqMTgUGoQfx8/VAiriQlZJFmW0yEZtb/hqII=; b=WYEyMW/dgabRNWeFC8XEEmPVniPdUtxcdUu0dZVoFpQdOyrGt6rjqOoW15kVUFYpTy O/d4Yl5H9WyxBgUVrkcbBPo53brJNByDVta7FdLHUQBb3m4RsmOaOQoQK7uz3Xz5PviA 1zzRmzG1i4IxByriBhgHXR1oXMcgCSSmhF4VG1AtHh9J3+g6INHly1YyBsKZ+mtskr9e mge+XVxzUlhG7EBMa+X0AKdInh09AtgIs1VavltO4VALNo4+ruo+9ZHAWxXUNjC4mZpR JpAGN8DznoQ6RosjFbvSpxq0CCSsnWUuFd2b6pViAvlMepzhcyB1X4L8Nt0okLRsqJrs PTXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733441751; x=1734046551; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l0GPH6zlqMTgUGoQfx8/VAiriQlZJFmW0yEZtb/hqII=; b=Hg1g0nCXMepeCyvA5o2WPxR22lN4iMGvvwqT0mG90RWNxNXV2LURZG1jfjsOMkTgfB pBpWxX6N2+TANolc5HwLvIO2Y6dzwTY3AEZUKHERkAxZFpwnRvFFoEliUfNzFLi1/5ST oW/52JRufe/Z2GVT9JO6Cv7sT27qsiN/EwnQK6XNq1ZnF406+uonuW9GF6dS9RJ7tf67 ZkqDgg0lPRen9eSMHHAZivgKc+q3MyXaLDvI4jwpLY603b4mcNwuS3rtghjq+VSr6x1H zQNKivVJ+cIBvxQRN6g5UZyI4z9df2Y2wylEEfGWY0+3DkSSJke7ufmP/P7a8S2hljAm YiiQ== X-Gm-Message-State: AOJu0YwGvr5kLhmPRQdHuTWJI1qcajyDR2kBQiYjbsLyFOaCH6Co9itE 2OGsVvGsVYMLhyYuAd7lgN5Pc05NtUi4PsZrpXPuf5Qk/EUsXxRyzUM//isXbgxSR01bMcSkBwa S+eIsGtPsZAdEA9oEIx6d4nGgUFFim5KSBQ6Kh003OvQxVj8tahU= X-Gm-Gg: ASbGnctiRXvWmloE3X3T2ZriLWnKkdKpxLUuOORLIdO1uHPUGFYZMbAHjjAkMRZ/XZQ STjU5hoqHlc8m7GuaBYReLZsbHjcSqMU= X-Google-Smtp-Source: AGHT+IF1j0de5hEqd5Y6q9FwjlXIeMd4oINilodpKsOIA1iDEvF8kcDI8MmT5JfDzaK5FNnzr/1hDxPM+5NjdbmFk+I= X-Received: by 2002:a05:6870:2c91:b0:29e:2caf:8cc with SMTP id 586e51a60fabf-29f73707265mr496509fac.37.1733441751508; Thu, 05 Dec 2024 15:35:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Greg Hogan Date: Thu, 5 Dec 2024 18:35:40 -0500 Message-ID: Subject: Re: Creating a C/C++ team? To: Liliana Marie Prikler Cc: guix-devel , Efraim Flashner , =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: none client-ip=2001:4860:4864:20::30; envelope-from=code@greghogan.com; helo=mail-oa1-x30.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 0.48 X-Spam-Score: 0.48 X-Migadu-Queue-Id: 6FECF4514F X-TUID: ZRtJU/P1nAmV On Fri, Nov 29, 2024 at 4:35=E2=80=AFAM Liliana Marie Prikler wrote: > > Hi Greg, > > Am Montag, dem 25.11.2024 um 13:27 -0500 schrieb Greg Hogan: > > Guix, > > > > Should we have a C++ team? I think project contributions regarding C > > and C++ compilers, libraries, tools, and programs would benefit from > > a tag to flag, discuss, and triage issues and a team branch to > > manage, test, and pre-build patches. > > > > This team would of course be distinct from the core-packages team, > > which manages the most fundamental packages and challenging updates. > I think there is a risk that this still overlaps with core-packages on > the account of GCC being our main C/C++ toolchain. The core-packages team scope includes commencement.scm, gcc.scm, and gnu-build-system so contributors using etc/teams.scm will be properly directed. I do share this concern, but I also think there is enough delay in collecting and building patches on a team branch that someone would flag a patchset needing core-packages handling and review. > Note: while I'm already swamped with work on gnome and emacs, I would > be interested in joining a hypothetical c++ team. Excellent! > > diff --git a/etc/teams.scm b/etc/teams.scm > > index fe3291f914..e257650a04 100755 > > --- a/etc/teams.scm > > +++ b/etc/teams.scm > > @@ -611,0 +612,14 @@ (define-team zig > > +(define-team c++ > > + (team 'c++ > > + #:name "C/C++ team" > > + #:description > > + "C and C++ compilers, libraries, tools, and programs" > I would limit the scope to "libraries and tools". That programs happen > to be written in C/C++ is almost always incidental :) > > > + #:scope (list "gnu/packages/c.scm" > > + "gnu/packages/cpp.scm" > Of course. > > > + "gnu/packages/llvm.scm" > > + "gnu/packages/llvm-meta.scm" > Not sure about these two. Since our main use for LLVM is in > Rust/Zig/Mesa, all of which have their own teams, maybe we should leave > a broader LLVM team with members from all of that open for folks who > are not necessarily interested in the rest of C/C++. > > > + "gnu/packages/ninja.scm" > > + "gnu/packages/valgrind.scm" > If we add these, I would also suggest adding build-tools.scm, > check.scm, debug.scm etc. > > > + "gnu/build/cmake-build-system.scm" > > + "gnu/build-system/cmake.scm"))) > These are under guix/ and belong to the core team IIRC. > > Cheers v2 below. Removed compiler (llvm[-meta].scm) scope and removed "compilers" from description. +1 to an LLVM team or llvm[-meta].scm in the core-packages scope. I think cmake-build-system belongs in the C++ team scope. Our use of cmake is rather simple, even with the enhancements collected in #70031 (which began with a desire to parallelize tests). We should keep cmake up-to-date without bothering core-packages. ninja.scm and valgrind.scm are essentially single package modules. The suggested build-tools.scm, check.scm, and debug.scm are a mix. For example, check.scm includes python-pytest among other python packages. Not sure why these are not in python-check.scm unless there would be circular dependencies. Given the success of the teams workflow, should we look to divide these mixed modules by team rather than grouping by theme? $ ./etc/teams.scm show c++ id: c++ name: C/C++ team description: C and C++ libraries and tools and the CMake build system. + Note that updates to fundamental packages are the competency of the + core-packages team. scope: + gnu/build-system/cmake.scm + gnu/build/cmake-build-system.scm + gnu/packages/c.scm + gnu/packages/cmake.scm + gnu/packages/cpp.scm + gnu/packages/ninja.scm + gnu/packages/valgrind.scm