From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Soo Subject: Re: rust-build-system: Unvendor *-sys libraries in phase? Date: Sat, 25 Jan 2020 11:01:31 -0800 Message-ID: References: <20200125184959.GM1603@E5400> Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:35804) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivQgZ-00065f-OJ for guix-devel@gnu.org; Sat, 25 Jan 2020 14:01:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivQgY-0004HS-2O for guix-devel@gnu.org; Sat, 25 Jan 2020 14:01:34 -0500 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]:39414) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivQgX-0004At-MG for guix-devel@gnu.org; Sat, 25 Jan 2020 14:01:34 -0500 Received: by mail-ot1-x32f.google.com with SMTP id 77so4782120oty.6 for ; Sat, 25 Jan 2020 11:01:33 -0800 (PST) In-Reply-To: <20200125184959.GM1603@E5400> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: Guix-devel Hi Efraim, > IMO the correct way to do it would be in the crate source that we > download. We regularly add snippets to remove vendored code, this should > be no different. Totally agree. It seems like a challenge to me to do the other required work= since all the building happens only when building the top level package. I w= ill totally defer to you here, since you have the knowledge and experience.=20= > The only real difference is that right now the > cargo-build-system is "too smart" and checks the #:cargo-inputs to make > sure they actually are crates before untarring them and putting them in > the guix-vendor dor. Currently the 'patch-and-rezip phase always uses xz > for compression, and crates always use gzip, so we cannot use patches or > snippets on crates. Can that be fixed in any way? I actually have no idea.=20 > Then the only thing left is to set certain environment variables, some > of which can probably be moved to the cargo-build-system if they don't > require an actual path. Ahh right. I hadn=E2=80=99t realized that restriction. Though couldn=E2=80=99= t end variables with paths be thunked or g-expressions or be done through pr= opagated paths? I=E2=80=99m not sure, just thinking aloud. Thanks for your maintenance, as always. John=