unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Soo <jsoo1@asu.edu>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: rust-build-system: Unvendor *-sys libraries in phase?
Date: Sat, 25 Jan 2020 11:01:31 -0800	[thread overview]
Message-ID: <BE519F52-C1B9-4257-92FB-92D61CD5BD02@asu.edu> (raw)
In-Reply-To: <20200125184959.GM1603@E5400>


Hi Efraim,


> IMO the correct way to do it would be in the crate source that we
> download. We regularly add snippets to remove vendored code, this should
> be no different.

Totally agree. It seems like a challenge to me to do the other required work since all the building happens only when building the top level package. I will totally defer to you here, since you have the knowledge and experience. 

> The only real difference is that right now the
> cargo-build-system is "too smart" and checks the #:cargo-inputs to make
> sure they actually are crates before untarring them and putting them in
> the guix-vendor dor. Currently the 'patch-and-rezip phase always uses xz
> for compression, and crates always use gzip, so we cannot use patches or
> snippets on crates.

Can that be fixed in any way? I actually have no idea. 

> Then the only thing left is to set certain environment variables, some
> of which can probably be moved to the cargo-build-system if they don't
> require an actual path.

Ahh right. I hadn’t realized that restriction. Though couldn’t end variables with paths be thunked or g-expressions or be done through propagated paths?  I’m not sure, just thinking aloud.

Thanks for your maintenance, as always.

John

  reply	other threads:[~2020-01-25 19:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24 21:49 rust-build-system: Unvendor *-sys libraries in phase? John Soo
2020-01-25 18:49 ` Efraim Flashner
2020-01-25 19:01   ` John Soo [this message]
2020-01-25 19:36     ` Efraim Flashner
2020-01-27 14:44       ` John Soo
2020-01-27 16:36         ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE519F52-C1B9-4257-92FB-92D61CD5BD02@asu.edu \
    --to=jsoo1@asu.edu \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).