From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 2/2] gnu: Add gnome-mpv. Date: Thu, 07 Jul 2016 12:07:01 -0500 Message-ID: References: <1467849895.1613559.659003001.5BC78E49@webmail.messagingengine.com> <87k2gxzzxt.fsf@mdc-berlin.de> <1467902388.677813.659579777.62341118@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLClU-0003oH-Kn for guix-devel@gnu.org; Thu, 07 Jul 2016 13:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLClP-0000Gj-9R for guix-devel@gnu.org; Thu, 07 Jul 2016 13:07:03 -0400 Received: from mail.openmailbox.org ([62.4.1.34]:53101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLClO-0000Gb-VR for guix-devel@gnu.org; Thu, 07 Jul 2016 13:06:59 -0400 In-Reply-To: <1467902388.677813.659579777.62341118@webmail.messagingengine.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Griffin , Ricardo Wurmus Cc: guix-devel@gnu.org On July 7, 2016 9:39:48 AM CDT, Alex Griffin wrote: >On Thu, Jul 7, 2016, at 02:10 AM, Ricardo Wurmus wrote: >> > + (uri (string-append >"https://github.com/gnome-mpv/gnome-mpv/releases/download/v" >> > + version "/gnome-mpv-" version >".tar.xz")) >>=20 >> This line looks a bit long to me. Have you checked with =E2=80=9Cguix= lint >> gnome-mpv=E2=80=9D? > >Actually, yes I did, and it didn't catch it. Maybe there's a bug in the >linter? The linter is slightly tolerant and will accept lines under 90 characters= IIRC.=20 >Anyway, here's an updated patch. In addition to correcting the long >line, I also tweaked the synopsis and description to make clear that >this is a media player, for the benefit of anyone who hasn't heard of >mpv. --=20 Sent from my Android device with K-9 Mail. Please excuse my brevity.