From: Julien Lepiller <julien@lepiller.eu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/6] Error reporting and hints for missing modules
Date: Sat, 11 Nov 2017 00:01:28 +0100 [thread overview]
Message-ID: <B399C460-1996-4D00-A425-7777F4305F95@lepiller.eu> (raw)
In-Reply-To: <86shdmtcl2.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2727 bytes --]
Le 10 novembre 2017 15:47:37 GMT+01:00, myglc2 <myglc2@gmail.com> a écrit :
>On 11/10/2017 at 00:04 Ludovic Courtès writes:
>>
>> Thrilled by this idea, I pushed an unbound-variable handler that can
>> provide hints, such as:
>>
>> configuration.scm:88:19: zip: unbound variable
>> hint: Try adding `(use-modules (gnu packages compression))'.
>>
>> Feedback welcome!
>
>I built and played with this. If I follow some of the hints literally
>they lead me astray. Here are some suggested hint rewording.
>
>Note: You can reproduce the errors/hints below with the attached files.
>
>HTH - George
>
>HINT REWORDING SUGGESTIONS:
>
>*** test2: "NON EXISTANT PACKAGE MODULE (qemu) for qemu PACKAGE
>SPECIFIED"
>
>The error messages ...
>
>/root/ctest/test2:4:0: error: module (gnu packages qemu) not found
>hint: Try adding `(use-package-modules virtualization)'.
>
>... are followed literally in test2.fix, which does not fix the
>problem because the stale and non-existant 'qemu' package module
>reference also needs to be removed.
>
>Maybe a better hint would be ...
>
>hint: Remove the reference to the pachage module that was not
>hint: found and add `(use-package-modules virtualization)'.
>
> *** test3: 'NON EXISTANT (openssh) SERVICE MODULE specified'
>
>This has the same conceptual problem as test2 above.
>
>The error messages ...
>
>/root/ctest/test3:3:0: error: module (gnu services openssh) not found
>hint: Try adding `(use-service-modules ssh)'.
>
>... are followed literally in test3.fix, which does not fix the
>problem because the non-existant 'openssh' service module
>reference also needs to be removed.
>
>Maybe a better hint would be ...
>
>hint: Remove the reference to the service module that was not
>hint: found and add `(use-service-modules ssh)'.
>
>*** test4: "SERVICE MODULE (ssh) for openssh-service-type SERVICE
>MISSING"
>
>A more helpful hint here ...
>
>/root/ctest/test4:46:19: /root/ctest/test4:46:19: openssh-service-type:
>unbound variable
>hint: Did you forget a `use-modules' form?
>
>... would be ...
>
>hint: Try adding `(use-service-modules ssh)'.
>
> ***
>
>VERSION INFO:
>
>74bea6a03 gnu: linux-libre: Update to 4.13.12.
>
>make check failed as reported in bug#29245 but I don't think those
>errors affect what I am seeing here.
>
>TEST FILES:
I saw that last hint today buveuse I misspelled a type name (dovecot-configurtation). I understand the hint is great when you forget to import a service module, but it's not so great when the error is misspelling. Maybe the solution would be: if the unbound variable is the name of a service, propose using that module, otherwise don't show any hint.
[-- Attachment #2: Type: text/html, Size: 3366 bytes --]
next prev parent reply other threads:[~2017-11-10 23:03 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 20:12 The usability of Guix configurations myglc2
2017-11-06 22:16 ` Leo Famulari
2017-11-06 23:26 ` myglc2
2017-11-07 1:56 ` myglc2
2017-11-07 11:05 ` julien lepiller
2017-11-07 12:52 ` Hartmut Goebel
2017-11-07 13:13 ` julien lepiller
2017-11-07 14:11 ` myglc2
2017-11-07 14:52 ` julien lepiller
2017-11-07 15:59 ` myglc2
2017-11-07 16:25 ` [PATCH] " julien lepiller
[not found] ` <867ev2t13i.fsf@gmail.com>
2017-11-07 21:27 ` Julien Lepiller
2017-11-07 22:56 ` myglc2
2017-11-07 22:47 ` Reporting module errors Ludovic Courtès
2017-11-08 1:26 ` myglc2
2017-11-08 10:52 ` Hartmut Goebel
2017-11-08 14:02 ` Ludovic Courtès
2017-11-08 13:09 ` [PATCH 0/6] Error reporting and hints for missing modules Ludovic Courtès
2017-11-08 13:09 ` [PATCH 1/6] ui: Introduce (guix i18n) Ludovic Courtès
2017-11-08 13:09 ` [PATCH 2/6] ui: Define and honor '&error-location' and '&fix-hint' conditions Ludovic Courtès
2017-11-08 13:09 ` [PATCH 3/6] services: 'fold-service-types' honors its seed Ludovic Courtès
2017-11-08 13:09 ` [PATCH 4/6] services: 'fold-service-types' includes (gnu services) Ludovic Courtès
2017-11-08 13:09 ` [PATCH 5/6] services: Add 'lookup-service-types' Ludovic Courtès
2017-11-08 13:09 ` [PATCH 6/6] gnu: Improve error reporting of the use-.*modules macros Ludovic Courtès
2017-11-11 2:02 ` Chris Marusich
2017-11-11 13:56 ` Ludovic Courtès
2017-11-11 17:00 ` Chris Marusich
2017-11-08 15:33 ` [PATCH 0/6] Error reporting and hints for missing modules julien lepiller
2017-11-08 17:42 ` myglc2
2017-11-08 19:07 ` myglc2
2017-11-08 21:42 ` Ludovic Courtès
2017-11-09 23:04 ` Ludovic Courtès
2017-11-10 14:47 ` myglc2
2017-11-10 23:01 ` Julien Lepiller [this message]
2017-11-11 22:00 ` Ludovic Courtès
2017-11-11 22:02 ` Ludovic Courtès
2017-11-14 1:12 ` myglc2
2017-11-30 10:44 ` Ludovic Courtès
2017-11-07 14:45 ` The usability of Guix configurations Hartmut Goebel
2017-11-07 2:30 ` myglc2
2017-11-07 3:03 ` myglc2
2017-11-07 2:59 ` myglc2
2017-11-07 20:54 ` myglc2
2017-11-07 10:23 ` Ludovic Courtès
2017-11-08 19:40 ` myglc2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B399C460-1996-4D00-A425-7777F4305F95@lepiller.eu \
--to=julien@lepiller.eu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).