From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0. Date: Mon, 23 Jan 2017 14:26:34 +1000 Message-ID: <9f559f47-67a2-8a58-79c3-df959d9ac30d@uq.edu.au> References: <20161229204925.E8B3B2201C9@vcs.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------7BC0B7B66D125A67A003A06D" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVWDS-0004bv-JH for guix-devel@gnu.org; Sun, 22 Jan 2017 23:26:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVWDP-0001IQ-Eo for guix-devel@gnu.org; Sun, 22 Jan 2017 23:26:50 -0500 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:55473 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVWDO-0001Hh-Ry for guix-devel@gnu.org; Sun, 22 Jan 2017 23:26:47 -0500 Received: from smtp1.soe.uq.edu.au (smtp1.soe.uq.edu.au [10.138.113.40]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id v0N4QbgY038475 for ; Mon, 23 Jan 2017 14:26:39 +1000 Received: from [192.168.1.105] (static.customers.nuskope.com.au [103.25.181.216] (may be forged)) (authenticated bits=0) by smtp1.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id v0N4QYjo060784 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 23 Jan 2017 14:26:36 +1000 In-Reply-To: <20161229204925.E8B3B2201C9@vcs.savannah.gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: "guix-devel@gnu.org" This is a multi-part message in MIME format. --------------7BC0B7B66D125A67A003A06D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Ricardo, > -------- Forwarded Message -------- > Subject: 16/35: gnu: r-ggplot2: Update to 2.2.0. > Date: Thu, 29 Dec 2016 20:49:25 +0000 (UTC) > From: Ricardo Wurmus > Reply-To: Ricardo Wurmus > To: guix-commits@gnu.org > > > > rekado pushed a commit to branch master > in repository guix. > > commit ab01f1cdb11520f0d56249719bcf627cad802bc2 > Author: Ricardo Wurmus > Date: Thu Dec 29 20:51:26 2016 +0100 > > gnu: r-ggplot2: Update to 2.2.0. > > * gnu/packages/statistics.scm (r-ggplot2): Update to 2.2.0. > [propagated-inputs]: Remove r-proto and r-svglite; add r-lazyeval and > r-tibble. Is there are particular reason why svglite was removed from propagated-inputs? In response I'm now unable to save SVG files with "ggsave", unless I install r-svglite separately. Perhaps this is a consequence of the updater suggesting some inputs can be removed? Thanks, ben. --------------7BC0B7B66D125A67A003A06D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi Ricardo,


-------- Forwarded Message --------
Subject: 16/35: gnu: r-ggplot2: Update to 2.2.0.
Date: Thu, 29 Dec 2016 20:49:25 +0000 (UTC)
From: Ricardo Wurmus <rekado@elephly.net>
Reply-To: Ricardo Wurmus <rekado@elephly.net>
To: guix-commits@gnu.org


rekado pushed a commit to branch master
in repository guix.

commit ab01f1cdb11520f0d56249719bcf627cad802bc2
Author: Ricardo Wurmus <rekado@elephly.net>
Date:   Thu Dec 29 20:51:26 2016 +0100

    gnu: r-ggplot2: Update to 2.2.0.
    
    * gnu/packages/statistics.scm (r-ggplot2): Update to 2.2.0.
    [propagated-inputs]: Remove r-proto and r-svglite; add r-lazyeval and
    r-tibble.
Is there are particular reason why svglite was removed from propagated-inputs? In response I'm now unable to save SVG files with "ggsave", unless I install r-svglite separately.

Perhaps this is a consequence of the updater suggesting some inputs can be removed?

Thanks, ben.
--------------7BC0B7B66D125A67A003A06D-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0. Date: Mon, 23 Jan 2017 09:57:12 +0100 Message-ID: <87ziiiyx07.fsf@elephly.net> References: <20161229204925.E8B3B2201C9@vcs.savannah.gnu.org> <9f559f47-67a2-8a58-79c3-df959d9ac30d@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVaRL-0007b3-VE for guix-devel@gnu.org; Mon, 23 Jan 2017 03:57:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVaRH-0003on-4I for guix-devel@gnu.org; Mon, 23 Jan 2017 03:57:28 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:21061) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cVaRG-0003nh-SG for guix-devel@gnu.org; Mon, 23 Jan 2017 03:57:23 -0500 In-reply-to: <9f559f47-67a2-8a58-79c3-df959d9ac30d@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: "guix-devel@gnu.org" Ben Woodcroft writes: >> -------- Forwarded Message -------- >> Subject: 16/35: gnu: r-ggplot2: Update to 2.2.0. >> Date: Thu, 29 Dec 2016 20:49:25 +0000 (UTC) >> From: Ricardo Wurmus >> Reply-To: Ricardo Wurmus >> To: guix-commits@gnu.org >> >> >> >> rekado pushed a commit to branch master >> in repository guix. >> >> commit ab01f1cdb11520f0d56249719bcf627cad802bc2 >> Author: Ricardo Wurmus >> Date: Thu Dec 29 20:51:26 2016 +0100 >> >> gnu: r-ggplot2: Update to 2.2.0. >> >> * gnu/packages/statistics.scm (r-ggplot2): Update to 2.2.0. >> [propagated-inputs]: Remove r-proto and r-svglite; add r-lazyeval and >> r-tibble. > > Is there are particular reason why svglite was removed from propagated-inputs? In response I'm now unable to save SVG files with "ggsave", unless I install r-svglite separately. > > Perhaps this is a consequence of the updater suggesting some inputs can be removed? It is. My apologies! “r-svglite” is optional and was reported by my modified updater, which compares the current inputs with the inputs a fresh import would suggest. If optional inputs are added it would be good to comment on why they were added. I probably wouldn’t have removed them in that case. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0. Date: Mon, 23 Jan 2017 21:28:21 +1000 Message-ID: References: <20161229204925.E8B3B2201C9@vcs.savannah.gnu.org> <9f559f47-67a2-8a58-79c3-df959d9ac30d@uq.edu.au> <87ziiiyx07.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVcnf-0007Ro-F8 for guix-devel@gnu.org; Mon, 23 Jan 2017 06:28:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVcna-0005E7-Mb for guix-devel@gnu.org; Mon, 23 Jan 2017 06:28:39 -0500 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:39990 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVcna-0005DF-4C for guix-devel@gnu.org; Mon, 23 Jan 2017 06:28:34 -0500 In-Reply-To: <87ziiiyx07.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: "guix-devel@gnu.org" On 23/01/17 18:57, Ricardo Wurmus wrote: > Ben Woodcroft writes: > >>> -------- Forwarded Message -------- >>> Subject: 16/35: gnu: r-ggplot2: Update to 2.2.0. >>> Date: Thu, 29 Dec 2016 20:49:25 +0000 (UTC) >>> From: Ricardo Wurmus >>> Reply-To: Ricardo Wurmus >>> To: guix-commits@gnu.org >>> >>> >>> >>> rekado pushed a commit to branch master >>> in repository guix. >>> >>> commit ab01f1cdb11520f0d56249719bcf627cad802bc2 >>> Author: Ricardo Wurmus >>> Date: Thu Dec 29 20:51:26 2016 +0100 >>> >>> gnu: r-ggplot2: Update to 2.2.0. >>> >>> * gnu/packages/statistics.scm (r-ggplot2): Update to 2.2.0. >>> [propagated-inputs]: Remove r-proto and r-svglite; add r-lazyev= al and >>> r-tibble. >> Is there are particular reason why svglite was removed from propagated= -inputs? In response I'm now unable to save SVG files with "ggsave", unle= ss I install r-svglite separately. >> >> Perhaps this is a consequence of the updater suggesting some inputs ca= n be removed? > It is. My apologies! > > =E2=80=9Cr-svglite=E2=80=9D is optional and was reported by my modified= updater, which > compares the current inputs with the inputs a fresh import would > suggest. If optional inputs are added it would be good to comment on > why they were added. I probably wouldn=E2=80=99t have removed them in = that > case. OK, np, pushed as e4b6c565beef27a1ce2203a9bc119e84a126e5e0. I wonder if the importer could import the previous version again and=20 compare to those, rather than just the current definition to avoid other=20 situations like this. ben From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0. Date: Mon, 23 Jan 2017 12:42:22 +0100 Message-ID: <87wpdmypcx.fsf@elephly.net> References: <20161229204925.E8B3B2201C9@vcs.savannah.gnu.org> <9f559f47-67a2-8a58-79c3-df959d9ac30d@uq.edu.au> <87ziiiyx07.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVd1C-0004Cp-Kt for guix-devel@gnu.org; Mon, 23 Jan 2017 06:42:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVd19-0000Up-Gu for guix-devel@gnu.org; Mon, 23 Jan 2017 06:42:38 -0500 Received: from sender163-mail.zoho.com ([74.201.84.163]:21062) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cVd19-0000UH-7Y for guix-devel@gnu.org; Mon, 23 Jan 2017 06:42:35 -0500 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: "guix-devel@gnu.org" Ben Woodcroft writes: >> “r-svglite” is optional and was reported by my modified updater, which >> compares the current inputs with the inputs a fresh import would >> suggest. If optional inputs are added it would be good to comment on >> why they were added. I probably wouldn’t have removed them in that >> case. > > OK, np, pushed as e4b6c565beef27a1ce2203a9bc119e84a126e5e0. Thanks! > I wonder if the importer could import the previous version again and > compare to those, rather than just the current definition to avoid other > situations like this. Would this have helped in this instance? Did the previous version *depend* on r-svglite? If it did, how could an editor like me have known that it was still valuable as an optional input? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: Fwd: 16/35: gnu: r-ggplot2: Update to 2.2.0. Date: Mon, 23 Jan 2017 21:48:17 +1000 Message-ID: References: <20161229204925.E8B3B2201C9@vcs.savannah.gnu.org> <9f559f47-67a2-8a58-79c3-df959d9ac30d@uq.edu.au> <87ziiiyx07.fsf@elephly.net> <87wpdmypcx.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVd6s-0004mL-5u for guix-devel@gnu.org; Mon, 23 Jan 2017 06:48:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVd6o-000370-U8 for guix-devel@gnu.org; Mon, 23 Jan 2017 06:48:30 -0500 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:48833 helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVd6o-00036J-98 for guix-devel@gnu.org; Mon, 23 Jan 2017 06:48:26 -0500 In-Reply-To: <87wpdmypcx.fsf@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: "guix-devel@gnu.org" On 23/01/17 21:42, Ricardo Wurmus wrote: > Ben Woodcroft writes: > [..] >> I wonder if the importer could import the previous version again and >> compare to those, rather than just the current definition to avoid other >> situations like this. > Would this have helped in this instance? Did the previous version > *depend* on r-svglite? If it did, how could an editor like me have > known that it was still valuable as an optional input? AIUI, it has always been optional. But I take your point anyway - a comment the first time would have been best. ben