From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Jonathan Brielmaier <jonathan.brielmaier@web.de>,
Guix-devel <guix-devel@gnu.org>
Subject: Re: [core-updates-frozen] Blockers for working system
Date: Sat, 11 Sep 2021 12:11:21 +0200 [thread overview]
Message-ID: <9a29f3ccf36f046ba6b4e40a1a96ee3c9c16d0a3.camel@gmail.com> (raw)
In-Reply-To: <fe6acd5d-0163-028b-c862-304feb2e3a1a@web.de>
Hi Jonathan,
Am Samstag, den 11.09.2021, 00:16 +0200 schrieb Jonathan Brielmaier:
> /gnu/store/2p3lw0dy8b3b34xfn2xlwg9ngrw493v7-gnome-maps-3.38.5.drv
> Fails in testsuite with:
> JS ERROR: Error: Expected 1,001 m (string) but was 1001 m (string)
> I have no clue why, maybe something is "wrangled" with LC_ALL or LANG
> variables. Or it has to do with our mozjs-78 (used by gjs), where I
> assume comes the `toLocaleString` function from...
There is a phase called "fix-broken-tests" in gnome-maps which patches
exactly those strings to add a comma. gnome-maps expects the new
behaviour (exactly the one you're observing), but building against an
old mozjs probably borked those tests at the time. The obvious fix is
to drop that phase as it's no longer needed.
Happy hacking!
prev parent reply other threads:[~2021-09-11 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 22:16 [core-updates-frozen] Blockers for working system Jonathan Brielmaier
2021-09-11 9:01 ` Guillaume Le Vaillant
2021-09-11 10:11 ` Liliana Marie Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a29f3ccf36f046ba6b4e40a1a96ee3c9c16d0a3.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=guix-devel@gnu.org \
--cc=jonathan.brielmaier@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).