From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KEgTIsY+Z1++DQAA0tVLHw (envelope-from ) for ; Sun, 20 Sep 2020 11:36:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aMgGHsY+Z1+CRAAAbx9fmQ (envelope-from ) for ; Sun, 20 Sep 2020 11:36:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1DA7E940238 for ; Sun, 20 Sep 2020 11:36:38 +0000 (UTC) Received: from localhost ([::1]:47124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJxe0-0000QB-Ui for larch@yhetil.org; Sun, 20 Sep 2020 07:36:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJxda-0000O3-7U for guix-devel@gnu.org; Sun, 20 Sep 2020 07:36:10 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:39860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJxdS-0007qH-QU for guix-devel@gnu.org; Sun, 20 Sep 2020 07:36:09 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 6f23ef5c; Sun, 20 Sep 2020 11:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:from:message-id; s=dkim; bh=79QzYxw2fsaQ0zw8VTaR7i0FXIHjUbnq/RurxtH3blU=; b=fn47nGd/zDZj 3/r/gkqkoy4rai0u89Ggy9GPbrSUc3t6DHO0U/3oLwaEXJQfjY9Mii2gt12wWbr0 kteiQH7xicweevOGtIqTKKYlXFAC4+IzTnuz8HlROWe54usH1TXCXgAGvkuDggx0 52D723fH24xmEvz5Cb8GI08OZai4JR74wt8l2hOh4eMpNlES0qc6YHEidWsahAWE i7oOpL9SCZ4ghX4vdnXg6ko9pfU74aWXQjCW152vUBapARQP+2mdM7BcNezwdmou gSYOfUWZpnTXP8PSQfFhEY8ZW3FF3jK8wlyRhbeH7U2cDWZXSUDeIuohW65ks9sn gzviw1SRdg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id db57c8a3 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 20 Sep 2020 11:35:56 +0000 (UTC) Date: Sun, 20 Sep 2020 07:35:44 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20200920105555.7a95f05f@alma-ubu> References: <20200920105555.7a95f05f@alma-ubu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: Testing the maven build system: Symlink error on duplicate inputs To: =?ISO-8859-1?Q?Bj=F6rn_H=F6fling?= , guix-devel From: Julien Lepiller Message-ID: <96845022-97FD-4F69-9C3B-39144BD68C7F@lepiller.eu> Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=lepiller.eu header.s=dkim header.b=fn47nGd/; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: o4A7tSMtgD7Z Le 20 septembre 2020 04:55:55 GMT-04:00, "Bj=C3=B6rn H=C3=B6fling" a =C3=A9crit : >Hi Julien, >Hi Guix, > >thanks for adding the maven-build-system to Guix! This week I found the >time to look over it and tested it=2E It works great! > >First I head a problem with symlinks when I tried out your example from >your git: > > [=E2=80=A6] > >Then I noticed that the configure phase has duplicate inputs and that >lead to the failure=2E After removing all native-inputs from the example, >I was able to successfully build this Hello-World example=2E Yes, that package was made for a slightly different version of tge build s= ysten than what I pushed, so it's not too surprising that it doesn't work a= s-is :) > >Would that maybe cause real problems when the same two inputs come from >different dependencies in real-world examples? > >I quickly tried to find a real-world problem to play with like slf4j or >Apache Commons, but all had either direct dependencies or >plugin-dependencies=2E > >Does someone have plans to add real-world packages that make use of the >maven-build-system? Next, an automated importer with >dependency-resolution would be nice :-) The issue with the importer is that maven doesn't record source informatio= n=2E We could have dependency resolution, but the resulting packages will l= ack any source (and for most packages also homepage and description)=2E One thing we have to decide on is what to do with maven build dependencies= =2E Currently, things like test dependencies of dependencies are in the gra= ph below maven, which means we have a lot of packages that cannot use the m= aven-build-system=2E There are two possibilities: we can change the bootstrap path to maven to = be minimal and only include runtime dependencies, and eventually rebuild ma= ven with the maven-build-system=2E The other possibility is to keep it as i= s, and convert packages to install to lib/m2 as needed=2E I tend to prefer the first solution, but that's also a lot of work=2E Our = current maven package has bugs that are probably due to the way we build it= (it doesn't honor user config, the build and test targets are mixed togeth= er, so are dependencies=E2=80=A6)=2E Building a proper maven with a minimal= maven could help ensure it's built in the intended way, so these bugs coul= d go away=2E wdyt? > >Thanks Julien for working on this, > >Bj=C3=B6rn Thanks for your interest :)