From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 00/14] Change python-build-system (fixes bug 20765) Date: Sun, 02 Oct 2016 20:25:57 +0100 Message-ID: <95811D11-8B25-49A5-B796-EE3A7937E1A9@fastmail.com> References: <1475071107-10765-1-git-send-email-h.goebel@crazy-compilers.com> <57EBCD98.9020407@goebel-consult.de> <87mvism34v.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <57EC008A.4030006@crazy-compilers.com> <87bmz5ih9u.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <87wphqesmc.fsf@gnu.org> <57F14455.8060506@crazy-compilers.com> <20161002180138.GB22791@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqmOw-0002Oy-S1 for guix-devel@gnu.org; Sun, 02 Oct 2016 15:26:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqmOs-0008Fx-L0 for guix-devel@gnu.org; Sun, 02 Oct 2016 15:26:17 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:52883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqmOq-0008Db-9p for guix-devel@gnu.org; Sun, 02 Oct 2016 15:26:14 -0400 In-Reply-To: <20161002180138.GB22791@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari , Hartmut Goebel Cc: guix-devel@gnu.org On 2 October 2016 19:01:38 BST, Leo Famulari wrote: >On Sun, Oct 02, 2016 at 07:31:01PM +0200, Hartmut Goebel wrote: >> Am 02.10.2016 um 16:24 schrieb Ludovic Courtès: >> > >> >> Subject: [PATCH 2/2] guix: python-build-system: Import setuptools >before >> >> calling `setup.py'. >> >> >> >> This is needed for packages using "distutils" instead of >"setuptools" >> >> since the former does not understand the >> >> "--single-version-externally-managed" flag. Also export __file__ >since >> >> it will be unset when setup.py is called from python "exec". >> > Please move this explanation as a comment right above the >newly-added >> > code. >> >> @marius: I already added this comment, see the fixups on my branch at >> gitlab (which I'm going to clean up when we all agree on the result). > >Let us know when the two of you think the code is ready to be tested on >Hydra, and I will set it up. Just FYI: I will be offline for a couple of days while waiting for a newly ordered ARM chromebook (Asus C201). If anyone wants to work on core/libreboot meanwhile that would be great ;-) I'll address the points raised Thursday or so. It makes sense to either apply these on core-updates or wait until it's merged before creating a channel/branch for Hydra IMO. -- Marius