From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iK/SLC8IyF+cOwAA0tVLHw (envelope-from ) for ; Wed, 02 Dec 2020 21:33:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qB28KC8IyF8PbgAAB5/wlQ (envelope-from ) for ; Wed, 02 Dec 2020 21:33:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D64A940253 for ; Wed, 2 Dec 2020 21:33:35 +0000 (UTC) Received: from localhost ([::1]:60292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kkZkk-0000fS-68 for larch@yhetil.org; Wed, 02 Dec 2020 16:33:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkZkT-0000cU-RM for guix-devel@gnu.org; Wed, 02 Dec 2020 16:33:17 -0500 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]:39392) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkZkP-0007Rb-9R for guix-devel@gnu.org; Wed, 02 Dec 2020 16:33:17 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CmXJQ365rz1rsMj for ; Wed, 2 Dec 2020 22:33:10 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CmXJQ2zN9z1qsWd for ; Wed, 2 Dec 2020 22:33:10 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id XIcCjlvCsVBL for ; Wed, 2 Dec 2020 22:33:09 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-188-174-55-73.dynamic.mnet-online.de [188.174.55.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Wed, 2 Dec 2020 22:33:09 +0100 (CET) Received: from thisbe.goebel-consult.de (hermia.goebel-consult.de [192.168.110.7]) by hermia.goebel-consult.de (Postfix) with ESMTP id 2176260013 for ; Wed, 2 Dec 2020 22:33:12 +0100 (CET) Subject: Re: Questionable "cosmetic changes" commits To: guix-devel@gnu.org References: <87mtywf35o.fsf@netris.org> From: Hartmut Goebel Organization: crazy-compilers.com Message-ID: <94edc9ea-2534-6673-719e-8d67cf446453@crazy-compilers.com> Date: Wed, 2 Dec 2020 22:33:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <87mtywf35o.fsf@netris.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: none client-ip=2001:a60:0:28:0:1:25:1; envelope-from=h.goebel@crazy-compilers.com; helo=mail-out.m-online.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.28 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 4D64A940253 X-Spam-Score: -2.28 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: dzE1Lo+NnyHJ Hi Martin, Am 02.12.20 um 19:55 schrieb Mark H Weaver: > I think that commits like this are best avoided for several reasons. […] > Should I change those things back the next time I update that package? My main project (PyInstaller) has the policy to not accept any white-space changes and reformatting, except this is done due to functional change. I'm very picky about this, since digging through a pile of cosmetic changes to find the cause of a functional change is cumbersome. For guix packages, finding the cause of a functional change is less of an issue. Anyhow, each change contributes to the load of data to be transferred. This not only is an issue for people with low bandwidths, but also contributes to climate change. The later is especially true, since "guix pull" pulls all changes on all machines using guix - so each single change will be downloaded many thousand time for next 10 years. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |