From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KEMwBWpDX2CScgAAgWs5BA (envelope-from ) for ; Sat, 27 Mar 2021 15:38:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OPW6OmlDX2A1agAA1q6Kng (envelope-from ) for ; Sat, 27 Mar 2021 14:38:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AA0971E1DB for ; Sat, 27 Mar 2021 15:38:33 +0100 (CET) Received: from localhost ([::1]:46774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQA5A-0005gM-9N for larch@yhetil.org; Sat, 27 Mar 2021 10:38:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQA38-0003SY-NW for guix-devel@gnu.org; Sat, 27 Mar 2021 10:36:27 -0400 Received: from xavier.telenet-ops.be ([2a02:1800:120:4::f00:14]:41176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQA36-0004WO-3S for guix-devel@gnu.org; Sat, 27 Mar 2021 10:36:26 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by xavier.telenet-ops.be with bizsmtp id lScG2400Q0mfAB401ScGwT; Sat, 27 Mar 2021 15:36:17 +0100 Message-ID: <927d66ccc760afacdb88485c5158731458d52dd6.camel@telenet.be> Subject: Re: [PATCHES] ImageMagick security updates without grafting From: Maxime Devos To: Mark H Weaver , guix-devel@gnu.org Date: Sat, 27 Mar 2021 15:36:07 +0100 In-Reply-To: <878s68zqsd.fsf@netris.org> References: <878s68zqsd.fsf@netris.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-J1Y0qnwdhyWj8dDy9HdT" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1616855777; bh=BuDzVeizM3eHsFO+kaqf3J5iChxVNzc+IvF9lgaigto=; h=Subject:From:To:Date:In-Reply-To:References; b=LonY8UgLjXbfnEncwMrVTRNkfCt0vNbJ0XtVyJlvuBgJ9x/vTrYBdhhkLAZNkOmjp 7hrG1NzcIBIp3S8S/T6yPZfoQhFn07PBtz+wqez2xbkGsW7DnsiQsNNnWXXQpfwO0/ QsMq/edVFb/T5JdapsbHO3FUdPx8uEyIs/hVLjNno3UbJhiOsymXzN7oMuT4Tfnbyx YurVg/3BAGDlBM6SrC82WIDIkTedOYPtdTP+9ao/mB1DKOdfZAvwDBu8p3pqDCTKmU BcSeuV+G7oDv23glZfW2XSub/hjuPVAJUKn2toNBmharVq6xzOGdOU7FnL7nVHNi4q eitn9xSlz4qwQ== Received-SPF: pass client-ip=2a02:1800:120:4::f00:14; envelope-from=maximedevos@telenet.be; helo=xavier.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616855913; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BuDzVeizM3eHsFO+kaqf3J5iChxVNzc+IvF9lgaigto=; b=khhyomfNJdg7pBadHG39cy2vOn++B1+J/z60HYAJ16gTDO4LrF8Y0b7SPOwkRmRG8k24mo Sg/dpmIUGTetxjLgSyGRugI0VGmA4q2oU/QHYJPj5L3T5NxVb6qZ3ZI3WUCGFlUmmJUqaM K2HN8EVX1jIIAVSQSs2JACaXLzI7i9SXOpza0zHC8jA7PCu6hx+RwHoEDn+rra2vRpT0uU 3AVQ34loxFCCa2fjyqIxFjfwlNtjXHIR5QPR5IYIguQzyc6sNB15s/1JtsVqVNQ6yLqsaY 2PJ4o2Jwo2uyRj/ykhk1HcZ4cpzOmv0WmMv8FURpJLvDL6w+PPpduembYu9JPA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616855913; a=rsa-sha256; cv=none; b=iviFVC1vskFwgmduSuWEnyCyogDkqTc6/MN6mh4LvG1rNszAtBStWgJQZPLAxVJKUIuvUD bHR53pkx2x/UiT90Lc0RJjqIP65MyX6x+w2lbSPyDf0lWblkBeNDMsp1kvcX75/9OyGUHc Jv9d7XAySsQ/KA6i768yZBJ45iRqboEP6HGHurynaCquE2ewlPz12HC5QSwEBHkmvgOGqd prKbEI/yd/uqc82DjcOiAgq/Hp/Xavvwc0OquMprOcAjQIbPUdueAulzedWAArcGzbKtyE U8OhH5eWBj6nCja7h78YEuy+a4SuX52wO9kQnDapcHNLeiYq5zBwRlgBstluTQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=LonY8UgL; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.72 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r21 header.b=LonY8UgL; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: AA0971E1DB X-Spam-Score: -3.72 X-Migadu-Scanner: scn0.migadu.com X-TUID: locZK2wdsGM3 --=-J1Y0qnwdhyWj8dDy9HdT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-03-27 at 09:09 -0400, Mark H Weaver wrote: > Hello Guix, >=20 > Here's a proposed patch set that will henceforth enable us to freely > update ImageMagick (and dblatex, and gtk-doc) on our 'master' branch > without grafts. This is done by adding variables 'imagemagick/stable', > 'dblatex/stable', and 'gtk-doc/stable', which are then used as > 'native-inputs' in selected packages. >=20 > The idea here is that the overwhelming majority of dependencies on > 'imagemagick' are via references to 'gtk-doc' in the 'native-inputs' of > GNOME libraries. The risk of running buggy imagemagick code within Guix > build containers is presumably quite limited, and in any case, grafting > is no better in this regard. This approach (& patches) look good to me. > [...] > Are there any comments or objections to this approach? What does =E2=80=98guix refresh --list-dependent imagemagick@6.9.11-48=E2= =80=99 output now? If it there are many dependent packages, could some of them use imagemagick/stable, dblatex/stable or gtk-doc/stable as well? Maybe add a comment to imagemagick/stable on why there is a=20 /stable variant, for future reference. Perhaps something along the lines of: ;; This is a variant of the 'imagemagick' package that is not ;; updated often. Where possible, use this variant instead of ;; the updated 'imagemagick' package to avoid large rebuilds ;; each time 'imagemagick' is updated (e.g. with security fixes), ;; unless this causes security issues. ;; ;; Normally the grafts mechanism would be used instead, but ;; imagemagick is a complicated package to graft. See ;; . > Mark >=20 > Note: I haven't yet fully tested these commits. Note: I haven't tested your patches. Greetings, Maxime. --=-J1Y0qnwdhyWj8dDy9HdT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYF9C2RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7oVmAQC28d012nMrb8zWvwminbx9z209 HAuwe79g/7tozUy8/wD9EIs9QNgknHKoFnTzw226H0LfxycaA6qX5gSExZuRwwo= =S5uR -----END PGP SIGNATURE----- --=-J1Y0qnwdhyWj8dDy9HdT--