unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] gnu: Add sshuttle.
Date: Wed, 7 Dec 2016 10:44:36 +0100	[thread overview]
Message-ID: <91b2d294-8b8e-e004-e2b9-6692d062b8a1@crazy-compilers.com> (raw)
In-Reply-To: <20161207032000.8120-1-me@tobias.gr>

Am 07.12.2016 um 04:19 schrieb Tobias Geerinckx-Rice:
> +    (native-inputs
> +     `(("python-pytest-runner" ,python-pytest-runner)
> +       ("python-setuptools-scm" ,python-setuptools-scm)
> +
> +       ;; For tests only.
> +       ("python-mock" ,python-mock)
> +       ("python-pytest" ,python-pytest)))

I wonder why pytest-runner in not below the comment "For tests only"?

Also I'd not put an empty line in front of the comment.

Please check the license. The LICENCE file says LGPL 2.1+ as you said,
but https://pypi.python.org/pypi/sshuttle/ says it is GPL2+. Can you
please verify which one is correct. Thanks.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

  parent reply	other threads:[~2016-12-07  9:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  3:19 [PATCH 1/3] gnu: Add sshuttle Tobias Geerinckx-Rice
2016-12-07  3:19 ` [PATCH 2/3] gnu: Add python-argcomplete Tobias Geerinckx-Rice
2016-12-07  3:22   ` Tobias Geerinckx-Rice
2016-12-07 17:19     ` Danny Milosavljevic
2016-12-07 21:16       ` Tobias Geerinckx-Rice
2016-12-07  3:20 ` [PATCH 3/3] gnu: Add sshoot Tobias Geerinckx-Rice
2016-12-07  3:25 ` [PATCH 1/3] gnu: Add sshuttle Tobias Geerinckx-Rice
2016-12-07  9:44 ` Hartmut Goebel [this message]
2016-12-07 16:26   ` Tobias Geerinckx-Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91b2d294-8b8e-e004-e2b9-6692d062b8a1@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).