From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodger Fox Subject: Re: [PATCH] gnu: Add lmms Date: Thu, 23 Feb 2017 08:38:48 -0800 Message-ID: <919256a73d38269b563e10e31545fbc8@openmailbox.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgwQ1-0007Jr-Ht for guix-devel@gnu.org; Thu, 23 Feb 2017 11:39:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgwPw-0005PD-Qc for guix-devel@gnu.org; Thu, 23 Feb 2017 11:39:01 -0500 Received: from lb1.openmailbox.org ([5.79.108.160]:60528 helo=mail.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cgwPw-0005N3-HV for guix-devel@gnu.org; Thu, 23 Feb 2017 11:38:56 -0500 Received: from www.openmailbox.org (unknown [10.0.0.4]) by mail.openmailbox.org (Postfix) with ESMTP id ED3FD51AF57 for ; Thu, 23 Feb 2017 17:38:48 +0100 (CET) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org > The message is correct, but it lacks returns between "Add lmms." and "* > gnu/packages". Have a look at git log for some examples. Yeah, that's weird. It's actually inconsistent with my commit log. Although, mine has only one line break instead of two, which I noticed after you mentioned this. Either way I'm wrong, but I'm not sure why the format-patch dropped it. I will figure that out and fix it. >> + (sha256 >> + (base32 >> + "1g76z7ha3hd53vbqaq9n1qg6s3lw8zzaw51iny6y2bz0j1xqwcsr")))) > There's a tab in the indentation, please use spaces. > >> + (build-system cmake-build-system) >> + (arguments `(#:tests? #f ; No tests to run. >> + #:validate-runpath? #f)) > There's a tab here too, and it should rather look like this: > (arguments > `(#:tests? #f > #:validate-runpath? #f)) > > Why do you need to disable runpath validation? The build was failing on the validate runpath phase, but I noticed that the package did exist in the store and was working. The failure was something to do with a library in a subdirectory of /lib being dependent on another library in its same directory. But it seems only /lib itself is in the runpath. I guess the libraries can still find each other, but they are not in the runpath. I actually meant to ask about this, so I'm glad you caught it. Is there a better fix for this situation? I guess I should at least put a comment in there to explain it. >> + (native-inputs >> + `(("pkg-config" ,pkg-config))) >> + (inputs > Indentation is off by one (inputs should be aligned with > native-inputs). > >> + (description "LMMS is a digital audio workstation. It includes >> tools for sequencing melodies and beats and for mixing and arranging >> songs. It includes instruments based on audio samples and various soft >> sythesizers. It can receive input from a MIDI keyboard.") > This line is way too long, please break it. Also please use two spaces > between sentences. I missed the two spaces rule. I'll fix the long line, too. I was having problems with guix lint, but I will be sure get that working before I submit something again. > Ok, this is my first review, I tried to get it right but I probably > forgot something (I still can't get my own patches right on the first > try :p). Running "guix lint lmms" would have saved you the last comment > ;). I can't try it now, but I'll test your patch (or an updated > version) > this evening. I will submit an updated version so you can do that tonight. Thanks for the feedback. -Rodger Fox