Re: [PATCH 1/1] Go: Update to 1.7

[Petter <petter@mykolab.ch>]

On 2016-08-20 02:07, Leo Famulari wrote:
> On Wed, Aug 17, 2016 at 10:54:36AM -0500, Alex Griffin wrote:
>> Thanks for contributing! Your changes work for me, but it looks like
>> your mail client mangled the formatting of your patch. So I produced a
>> good patch with your changes, and added a copyright line and commit
>> message for you. Hopefully that will make it easier for someone with
>> commit access to look it over.
>> 
>> --
>> Alex Griffin
> 
>> From f2f28e088f2a3f833251c2b31de7e6f531bcdf9a Mon Sep 17 00:00:00 2001
>> From: Petter <petter@mykolab.ch>
>> Date: Wed, 17 Aug 2016 10:27:04 -0500
>> Subject: [PATCH] gnu: go: Update to 1.7.
>> 
>> * gnu/packages/golang.scm (go-1.6): Update to 1.7, with corresponding
>>   minor changes to prebuild phase, and rename variable to...
>>   (go-1.7): ...this new variable.
>>   (go): Inherit from new "go-1.7".
> 
> I have a working Syncthing [0] on x86_64 with this patch.
> 

Good, my testing on a couple of small programs have been successful as 
well.

> I noticed this during the test suite:
> 
> ##### ../misc/cgo/testsanitizers
> skipping msan tests: -fsanitize=memory not supported
> gcc: error: -fsanitize=thread linking must be done with -pie or -shared
> skipping tsan tests: -fsanitizer=thread build failed
> 
> I don't know whether or not that's a problem.
> 

Good catch, I did not notice this.

It could be an error by the Go team, ref:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703230

I don't know though if it would be correct for us in that case to add 
-fPIC to this call if that would solve it.

> [0] WIP branch:
> https://github.com/lfam/guix/commits/contrib-syncthing
> 
>>  ;;; Copyright ?? 2016 Matthew Jordan <matthewjordandevops@yandex.com>
>>  ;;; Copyright ?? 2016 Andy Wingo <wingo@igalia.com>
>>  ;;; Copyright ?? 2016 Ludovic Court??s <ludo@gnu.org>
>> +;;; Copyright ?? 2016 Petter <petter@mykolab.ch>
> 
> Petter, I noticed your original patch did not add a line like this.
> Please confirm the name and email address you'd prefer to use.
> Pseudoynms are fine.

Alex got it right, this is the name and e-mail address I want to use.