From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amirouche Boubekki Subject: Re: [PATCH] import: pypi: Detect inputs. Date: Sun, 21 Jun 2015 23:32:45 +0200 Message-ID: <8f074787e9f54c5686a768c0b29cb178@hypermove.net> References: <87d217uvzd.fsf@gnu.org> <1434331554-13170-1-git-send-email-tipecaml@gmail.com> <87ioagpyqk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6mrF-0007vM-NA for guix-devel@gnu.org; Sun, 21 Jun 2015 17:32:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6mrE-0006bW-Od for guix-devel@gnu.org; Sun, 21 Jun 2015 17:32:53 -0400 In-Reply-To: <87ioagpyqk.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: ludo@gnu.org Cc: guix-devel@gnu.org, guix-devel-bounces+amirouche=hypermove.net@gnu.org On 2015-06-21 22:56, ludo@gnu.org wrote: > Amirouche Boubekki skribis: >=20 >> If I'm not mistaken this patch relies only on the presence of >> requirements.txt. This is not a required file in python >> packaging. otherwise said, we miss a lot using this method. I think >> the best way to do that would be to: >>=20 >> - download the package and extract it >> - create an environment (#) >> - create a virtual env with access to system site package of the >> environment (#) >> - enter the venv and install the package >> - use `pip freeze -l` to retrieve the full set of dependencies >=20 > Cyril, WDYT? >=20 > I=E2=80=99m not familiar with the details, but my feeling is that readi= ng > requirements.txt is more lightweight, simpler, and more robust than=20 > what > you propose. >=20 > So I=E2=80=99d be inclined to apply Cyril=E2=80=99s patch ASAP. Yes of course, it super helpful. It's not comprehensive, that's all I=20 liked to say, that is all.