Re: [PATCH 3/6] gnu: gnome-documents

[rennes@openmailbox.org]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

Hi,

On 2016-03-29 14:21, ludo@gnu.org wrote:
> rennes@openmailbox.org skribis:
> 
>> +    (arguments
>> +     '(#:configure-flags '("--enable-nss"))) ; instead of OpenSSL.
> 
> If there’s a particular reason for this choice, could you mention it in
> a comment?
> 
>> +    (synopsis "Collection of POSIX-C functions implementing the OAuth 
>> API")
> 
> s/POSIX-C/C/
> 
>> +    (description
>> +     "Liboauth provides functions to escape and encode stings 
>> according to
>                                                            ^^
> *strings
> 
>> +    (license license:gpl2+))) ; distributed under MIT or GPL.
> 
> “MIT” is probably either the Expat or the X11 license.  Please check 
> the
> license texts at:
> 
>   http://directory.fsf.org/wiki/License:Expat
>   http://directory.fsf.org/wiki/License:X11
> 
> Thanks,
> Ludo’.

I Attached the patch corrected.

Clarifying, nss had used instead of openssl because I saw it as an 
option. But in the subsequentes packages OpenSSL is required.

On the other hand I have two questions:
a) Regarding the copyright in the 'Submitting Patches' section I can not 
find the part that describes it.
b) I can use the 'gnu/packages/gnome.scm' file to generate the patch or 
is indifferent ?

Thank you

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-liboauth.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-liboauth.patch, Size: 1956 bytes --]

From cabbfd0d8a0472d60a250e12b49cb10098419d1c Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Wed, 30 Mar 2016 19:03:57 -0600
Subject: [PATCH] gnu: Add liboauth.

* gnu/packages/gnome.scm (liboauth): New variable.

---
 gnu/packages/liboauth.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 gnu/packages/liboauth.scm

diff --git a/gnu/packages/liboauth.scm b/gnu/packages/liboauth.scm
new file mode 100644
index 0000000..be6c946
--- /dev/null
+++ b/gnu/packages/liboauth.scm
@@ -0,0 +1,37 @@
+;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
+
+(define-module (gnu packages liboauth)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix utils)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages tls))
+
+(define-public liboauth
+  (package
+    (name "liboauth")
+    (version "1.0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/liboauth/"
+                           name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07w1aq8y8wld43wmbk2q8134p3bfkp2vma78mmsfgw2jn1bh3xhd"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("openssl" ,openssl)))
+    (home-page "https://sourceforge.net/projects/liboauth")
+    (synopsis "Collection of s/POSIX-C/C/ functions implementing the OAuth API")
+    (description
+     "Liboauth provides functions to escape and encode strings according to
+OAuth specifications and offers high-level functionality built on top to sign
+requests or verify signatures using either NSS or OpenSSL for calculating
+the hash/signatures.")
+    (license (list license:gpl2+
+                   license:openssl)))) ; OpenSSL library.
-- 
2.6.3