From: "Philip McGrath" <philip@philipmcgrath.com>
To: "Maxime Devos" <maximedevos@telenet.be>,
"Brian Cully" <guix-devel@gnu.org>
Cc: "Julien Lepiller" <julien@lepiller.eu>, "Ludovic Courtès" <ludo@gnu.org>
Subject: Re: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches.
Date: Thu, 04 Aug 2022 23:23:06 -0400 [thread overview]
Message-ID: <8b13e899-eb60-490b-a268-639249698c81@www.fastmail.com> (raw)
In-Reply-To: <c4c0a071-2e03-d4d6-6718-05424d21d146@telenet.be>
On Sun, Jul 24, 2022, at 11:17 PM, Maxime Devos wrote:
> * Patches must not be used to remove non-free files, because a patch by construction contains the non-free file itself so the patch would be non-free, which would not be acceptable to Guix. Likewise, patches should not be used to remove bundled libraries, to avoid large space usage, but this is not an absolute rule unlike as for non-free files.
It is possible to create patches that do not contain the deleted file, e.g. with `git format-patch --irreversible-delete`. That said, I don't know if the version of `patch` we use to patch origins is able to apply such patches—but maybe it would be a useful feature?
-Philip
next prev parent reply other threads:[~2022-08-05 3:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 3:17 A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches Maxime Devos
2022-07-25 5:21 ` Julien Lepiller
2022-07-25 11:18 ` Maxime Devos
2022-07-25 11:37 ` Julien Lepiller
2022-08-04 8:51 ` Ludovic Courtès
2022-08-05 3:23 ` Philip McGrath [this message]
2022-08-05 8:13 ` Maxime Devos
2022-08-05 3:38 ` Philip McGrath
2022-08-05 8:09 ` Maxime Devos
2022-08-05 10:18 ` Maxime Devos
2022-08-05 13:59 ` v2: " Maxime Devos
2022-08-06 6:55 ` [PATCH] doc: Update contribution guidelines on patches, etc Liliana Marie Prikler
2022-08-06 6:55 ` [PATCH v2] " Liliana Marie Prikler
2022-09-02 13:12 ` Ludovic Courtès
2022-09-02 18:05 ` Maxime Devos
2022-09-05 9:47 ` Ludovic Courtès
2022-09-05 13:12 ` Maxime Devos
2022-09-05 16:05 ` Maxime Devos
2022-08-09 16:45 ` [PATCH] " Maxime Devos
2022-08-09 17:05 ` Liliana Marie Prikler
2022-08-09 18:19 ` Maxime Devos
2022-08-09 19:08 ` Liliana Marie Prikler
2022-08-09 20:30 ` Maxime Devos
2022-08-10 4:25 ` Liliana Marie Prikler
2022-08-09 20:40 ` Maxime Devos
2022-08-08 21:51 ` v2: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches Andreas Enge
2022-08-09 15:06 ` Maxime Devos
2022-08-09 17:10 ` Andreas Enge
2022-09-05 13:03 ` Maxime Devos
2022-09-07 12:17 ` Andreas Enge
2022-09-07 18:08 ` Maxime Devos
2022-08-09 18:58 ` david larsson
2022-08-09 20:53 ` Maxime Devos
2022-08-10 11:23 ` david larsson
2022-08-05 16:59 ` blake
2022-08-09 16:30 ` Maxime Devos
2022-09-05 14:06 ` Maxime Devos
2022-08-10 6:10 ` blake
2022-08-10 9:06 ` Maxime Devos
2022-08-10 10:33 ` blake
2022-08-10 10:44 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b13e899-eb60-490b-a268-639249698c81@www.fastmail.com \
--to=philip@philipmcgrath.com \
--cc=guix-devel@gnu.org \
--cc=julien@lepiller.eu \
--cc=ludo@gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).