From: Robert Vollmert <rob@vllmrt.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages)
Date: Thu, 8 Aug 2019 15:42:44 +0200 [thread overview]
Message-ID: <8B6F734E-A186-47BB-A0E4-63DF758853EA@vllmrt.net> (raw)
In-Reply-To: <87mugjiyx0.fsf@devup.no>
On 8. Aug 2019, at 15:12, Marius Bakke <mbakke@fastmail.com> wrote:
> I have one comment about the series: we've disabled tests on some
> packages that have been broken "forever" on i686. It would be better to
> do so selectively on just the affected architectures. I.e.:
>
> #:tests? (if (string-prefix? "i686" (%current-system))
> #f
> #t)
>
> Preferably with a comment about why they need to be disabled. That way,
> we will still notice when something breaks on other architectures. Can
> you try it Rob?
I don’t intend to, because I think the effort is better spent elsewhere.
But do make the change if you like!
The rough plan from my point of view would be to aim for an upgrade of
the haskell packages to build with ghc-8.6 from a recent stackage LTS
set, and reevaluate skipped tests across the set while doing that or
once that’s done.
Cheers
Robert
next prev parent reply other threads:[~2019-08-08 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F5E8BA95-BE79-4579-B881-AE0862B69D3A@vllmrt.net>
[not found] ` <87muh2ckdn.fsf@ngyro.com>
2019-08-01 16:23 ` Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages) Robert Vollmert
2019-08-06 4:29 ` Timothy Sample
2019-08-06 7:04 ` Robert Vollmert
2019-08-08 3:42 ` Timothy Sample
2019-08-06 7:49 ` Robert Vollmert
2019-08-07 11:19 ` Marius Bakke
2019-08-08 3:47 ` Timothy Sample
2019-08-08 13:12 ` Marius Bakke
2019-08-08 13:42 ` Robert Vollmert [this message]
2019-08-08 15:54 ` Timothy Sample
2019-08-08 16:08 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8B6F734E-A186-47BB-A0E4-63DF758853EA@vllmrt.net \
--to=rob@vllmrt.net \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).