PATCH: Detect missing pkg.m4

PATCH: Detect missing pkg.m4

[John Darrington]

[-- Attachment #1.1: Type: text/plain, Size: 523 bytes --]

configure.ac depends on pkg-config 

I try to avoid pkg-config if at all possible.  It is a source of constant aggrevation.

However, if it is absolutely unavoidable I recommend the attached patch.  It detects
pkg-config problems early in the bootstrap process, rather than delaying their discovery
till halfway through the build.

J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #1.2: 0001-configure.ac-Added-macros-to-help-detect-missing-pkg.patch --]
[-- Type: text/x-diff, Size: 782 bytes --]

From ed23edf3a6020c87af7030a722a4705af10e2939 Mon Sep 17 00:00:00 2001
From: John Darrington <john@darrington.wattle.id.au>
Date: Sat, 23 Nov 2013 13:43:33 +0100
Subject: [PATCH] configure.ac: Added macros to help detect missing pkg.m4

---
 configure.ac |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure.ac b/configure.ac
index 7a67efa..2590435 100644
--- a/configure.ac
+++ b/configure.ac
@@ -41,6 +41,9 @@ AC_ARG_ENABLE([daemon],
 guix_localstatedir="`eval echo $localstatedir | sed -e "s|NONE|/usr/local|g"`"
 AC_SUBST([guix_localstatedir])
 
+PKG_PROG_PKG_CONFIG
+m4_pattern_forbid([PKG_CHECK_MODULES])
+
 PKG_CHECK_MODULES([GUILE], [guile-2.0 >= 2.0.5])
 AC_PATH_PROG([GUILE], [guile])
 AC_PATH_PROG([GUILD], [guild])
-- 
1.7.10.4


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: PATCH: Detect missing pkg.m4

[Ludovic Courtès]

Hi John,

John Darrington <john@darrington.wattle.id.au> skribis:

> I try to avoid pkg-config if at all possible.  It is a source of constant aggrevation.

It’s the recommended method to check for Guile.

> +PKG_PROG_PKG_CONFIG

This line is unnecessary because PKG_CHECK_MODULES starts with:

  AC_REQUIRE([PKG_PROG_PKG_CONFIG])

> +m4_pattern_forbid([PKG_CHECK_MODULES])
> +
>  PKG_CHECK_MODULES([GUILE], [guile-2.0 >= 2.0.5])

Indeed, makes sense.

I’ve applied added that line, thanks!

Ludo’.