From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/3] gnu: Add imlib2. Date: Thu, 25 Sep 2014 21:01:37 +0200 Message-ID: <87zjdned7y.fsf@gnu.org> References: <87wq8scc81.fsf@gmail.com> <8761gbluy0.fsf@gnu.org> <87h9zvd2kx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXEIb-0003gN-8n for guix-devel@gnu.org; Thu, 25 Sep 2014 15:02:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXEIS-0007I4-5S for guix-devel@gnu.org; Thu, 25 Sep 2014 15:01:53 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:36398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXEIR-0007H9-Qd for guix-devel@gnu.org; Thu, 25 Sep 2014 15:01:44 -0400 In-Reply-To: <87h9zvd2kx.fsf@gmail.com> (Alex Kost's message of "Thu, 25 Sep 2014 21:36:46 +0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > Many thanks to Andreas for detailed comments about licenses. > > Ludovic Court=C3=A8s (2014-09-25 16:56 +0400) wrote: > >> Alex Kost skribis: >> >>> +(define-public imlib2 >> >> [...] >> >>> + (home-page "http://sourceforge.net/projects/enlightenment/") >>> + (synopsis >>> + "Library for loading, saving, rendering and manipulating image fi= les") >> >> s/Library for// > > Done. Is there any convention about that? Not really. The one above didn=E2=80=99t fit on the line, so I thought it = would make sense to strip a couple of words. :-) We should add a linter making sure the synopsis doesn=E2=80=99t exceed a ce= rtain length, 60 characters, say. > I'm asking because there are several "types" of synopses: > > - Several synopses begin with "Library for" (libuv, fontconfig, > lightning, ...) > > - Few ones begin with "Library to" (cloog, petsc, ...) > > - Some packages have the following synopsis structure: > > , a library ... > > Some of them begin with a capital letter (libjpeg, libgpg-error, > freetype, ...), and some with a small one (fpill, libogg, libpaper, ...) > > - Many synopses end with "library" (libsamplerate, clucene, libgcrypt, ..= .) Synopses starting with the package name are definitely frowned upon (we should add a linter for that.) The others listed above may or may not be OK, depending. > Also (as I'm writing about synopses): is there a convention to begin a > synopsis with a capital letter? Yes. Another linter needed! > Also there are 2 packages with synopses beginning with an article: > =E2=80=9Cpkg-config=E2=80=9D and =E2=80=9Cid3lib=E2=80=9D, but it's a low= er-case article (perhaps "guix > lint" should be adjusted for this case). Yes. >> Actually this should probably go to (gnu packages image), which is home >> for all its friends. > > OK, initially I wanted to put it there, but then I found that =E2=80=9Cgi= flib=E2=80=9D > is in a separate file, so I thought that maybe "image.scm" contains some > special image libraries. > > If =E2=80=9Cgiflib=E2=80=9D also should be put in "image.scm", please don= 't move it > there before I push these imlib2/giblib commits :-) Fine. :-) > From 11c8f170a0f3c8f5f4ed4730681224de46745d62 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Thu, 25 Sep 2014 12:27:25 +0400 > Subject: [PATCH 1/3] gnu: Add imlib2. > > * gnu/packages/image.scm (imlib2): New variable. Perfect! Thanks for tolerating and even encouraging nitpicking. ;-) Ludo=E2=80=99.