unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] build: Add ruby build system.
Date: Sun, 28 Sep 2014 17:50:28 +0200	[thread overview]
Message-ID: <87zjdjagmz.fsf@gnu.org> (raw)
In-Reply-To: <1411917760-28557-2-git-send-email-dthompson2@worcester.edu> (David Thompson's message of "Sun, 28 Sep 2014 11:22:39 -0400")

David Thompson <dthompson2@worcester.edu> skribis:

> * guix/build-system/ruby.scm: New file.
> * guix/build/ruby-build-system: New file.
> * Makefile.am (MODULES): Add new files.

Nice!  Some comments:

> +(define build
> +  (lambda _
> +    (system "ls -la")

Debugging leftover?

> +    (let ((gemspec (car (find-files "." "\\.gemspec$"))))
> +      (zero? (system* "gem" "build" gemspec)))))

Rather (match (find-files ...) ...).

> +(define* (install #:key source inputs outputs #:allow-other-keys)
> +  (let* ((ruby-version
> +          (match:substring (string-match "ruby-(.*)$"
> +                                         (assoc-ref inputs "ruby"))
> +                           1))
> +         (gem-home (string-append (assoc-ref outputs "out")
> +                                  "/lib/ruby/gems/"
> +                                  ruby-version)))
> +    (setenv "GEM_HOME" gem-home)
> +    (mkdir-p gem-home)
> +    (let ((gem (car (find-files "." "\\.gem$"))))
> +      (zero? (system* "gem" "install" "--local" gem)))))

Ditto.  Might be worth defining ‘first-gem-file’ for that.

Could you also add a few lines in guix.texi under “Build Systems”?

Thanks,
Ludo’.

  parent reply	other threads:[~2014-09-28 15:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28 15:22 [PATCH 1/3] gnu: Add ruby David Thompson
2014-09-28 15:22 ` [PATCH 2/3] build: Add ruby build system David Thompson
2014-09-28 15:41   ` David Thompson
2014-09-28 15:50   ` Ludovic Courtès [this message]
2014-09-28 16:25     ` David Thompson
2014-09-28 18:59       ` Ludovic Courtès
2014-09-28 15:22 ` [PATCH 3/3] gnu: Add ruby-i18n David Thompson
2014-09-28 15:50   ` Ludovic Courtès
2014-10-01 19:28   ` Ludovic Courtès
2014-10-01 19:49     ` Thompson, David
2014-10-02  8:35       ` Ludovic Courtès
2014-09-28 15:46 ` [PATCH 1/3] gnu: Add ruby Ludovic Courtès
2014-09-28 19:24 ` David Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjdjagmz.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).