unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] gnu: add feh
Date: Sun, 05 Oct 2014 14:31:53 +0200	[thread overview]
Message-ID: <87zjdaelza.fsf@gnu.org> (raw)
In-Reply-To: <87lhovj5el.fsf@gmail.com> (Alex Kost's message of "Sun, 05 Oct 2014 12:18:42 +0400")

I agree with Alex’s comments.  Ian, could you post an updated patch?

Alex Kost <alezost@gmail.com> skribis:

> Ian Denhardt (2014-10-05 07:32 +0400) wrote:

>> +    (description (string-append
>> +                   "feh is an X11 image viewer aimed mostly at console users. "
>> +                   "Unlike most other viewers, it does not have a fancy GUI, "
>> +                   "but simply displays images. It is controlled via "
>> +                   "commandline arguments and configurable key/mouse actions."))
>
> This will make a long one-line description, which is not preferable.

Indeed.  In addition, it’s important for the description and synopsis to
be a string literal so that it can be picked up by xgettext and subject
to translation.

Ludo’.

  reply	other threads:[~2014-10-05 12:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-05  6:04 [PATCH 0/1] gnu: add feh Ian Denhardt
2014-10-05  3:32 ` [PATCH 1/1] " Ian Denhardt
2014-10-05  8:18   ` Alex Kost
2014-10-05 12:31     ` Ludovic Courtès [this message]
2014-10-05 16:06       ` [PATCH 0/1] (updated) " Ian Denhardt
2014-10-05  3:32         ` [PATCH 1/1] " Ian Denhardt
2014-10-06  7:59           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjdaelza.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).