unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Thompson <dthompson2@worcester.edu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add freeimage.
Date: Sun, 02 Nov 2014 12:35:52 -0500	[thread overview]
Message-ID: <87zjc9v72f.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87mw89ms2p.fsf@gnu.org>

Ludovic Courtès <ludo@gnu.org> writes:

> David Thompson <dthompson2@worcester.edu> skribis:
>
>> Andreas Enge <andreas@enge.fr> writes:
>
> [...]
>
>>>> +                'unpack
>>>> +                (lambda* (#:key source #:allow-other-keys)
>>>> +                  (and (zero? (system* "unzip" source))
>>>> +                       (chdir "FreeImage")))
>>>
>>> I wonder if this should not be moved to the standard unpack phase. Can we
>>> determine the file format and use the appropriate tool, unzip or tar,
>>> automatically? (Assuming that there are no .tar.zip out there, of
>>> course.)
>>
>> I've been thinking about this, too.  I don't think I would like the GNU
>> build system to depend on unzip since very few packages require it and
>> it's not a format that GNU uses, but maybe a procedure that replaced the
>> standard unpack phase with one that uses unzip would be nice.  I think
>> that work could/should be saved for a future patch.
>
> I think we could change ‘unpack’ in gnu-build-system.scm to invoke unzip
> when the file name ends in .zip, while letting it the user’s
> responsibility to add unzip as an input when needed (as is already the
> case for lzip.)
>
> But yes, this would be for core-updates.

Okay, that does sound like a good idea.

>> From 2972e6e41d7c13dd619f0dd7fbda7b2a4ec0c6cc Mon Sep 17 00:00:00 2001
>> From: David Thompson <dthompson2@worcester.edu>
>> Date: Wed, 25 Jun 2014 19:50:30 -0400
>> Subject: [PATCH] gnu: Add freeimage.
>>
>> * gnu/packages/image.scm (freeimage): New variable.
>
> LGTM, OK to push!

Pushed.  Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

  reply	other threads:[~2014-11-02 17:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-01 15:48 [PATCH] gnu: Add freeimage David Thompson
2014-11-01 16:59 ` Andreas Enge
2014-11-01 17:21   ` David Thompson
2014-11-02 17:26     ` Ludovic Courtès
2014-11-02 17:35       ` David Thompson [this message]
2014-11-02 17:46     ` Andreas Enge
2014-11-02 17:55       ` David Thompson
2014-11-02 21:10         ` Andreas Enge
2014-11-02 21:38           ` David Thompson
2014-11-03  9:00           ` Ludovic Courtès
2014-11-03  9:29             ` Andreas Enge
2014-11-03 20:28               ` Ludovic Courtès
2014-11-03 23:29           ` David Thompson
2014-11-04  9:50             ` Ludovic Courtès
2014-11-05  3:12               ` David Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjc9v72f.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me \
    --to=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).