From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add bedtools
Date: Sat, 13 Dec 2014 00:00:28 +0100
Message-ID: <87zjaspj77.fsf@gnu.org>
References: <idj388lkwih.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XzZCR-0003lB-13
	for guix-devel@gnu.org; Fri, 12 Dec 2014 18:00:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XzZCJ-0005re-A4
	for guix-devel@gnu.org; Fri, 12 Dec 2014 18:00:38 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:47053)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XzZCJ-0005rO-3W
	for guix-devel@gnu.org; Fri, 12 Dec 2014 18:00:31 -0500
In-Reply-To: <idj388lkwih.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Fri, 12 Dec 2014 11:11:50 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> Since there is no install phase in the Makefile I had to write a
> replacement to copy all tools from the build bin/ directory to the
> output /bin/ directory.  I don't know if it is better to explicitly list
> the tools to copy or if this should rather be done with a glob pattern.

Is a glob pattern really needed, or is it that bin/* must be copied?

If the latter, you could use =E2=80=98scandir=E2=80=99 to obtain the list o=
f files in
that directory, or (find-files "build/bin" ".*") where the 2nd argument
is a regexp, not a glob pattern.

> Another source of ugliness in the recipe is the
> patch-makefile-SHELL-definition phase which is really just
> patch-makefile-SHELL but working on ":=3D" definitions rather than
> "=3D" assignments.  Augmenting patch-makefile-SHELL to handle definitions
> as well would result in a cleaner package recipe.

Yeah; let=E2=80=99s fix that in core-updates.

> +       (alist-cons-after
> +        'unpack 'patch-makefile-SHELL-definition
> +                (lambda _

Please align =E2=80=98(lambda=E2=80=99 with =E2=80=98'unpack=E2=80=99.

> +                  (define (find-shell name)
> +                    (let ((shell
> +                           (search-path (search-path-as-string->list (ge=
tenv "PATH"))
> +                                        name)))
> +                      (unless shell
> +                        (format (current-error-port)
> +                                "patch-makefile-SHELL: warning: no binar=
y for shell `~a' found in $PATH~%"
> +                                name))
> +                      shell))

=E2=80=98find-shell=E2=80=99 is not needed: just use the procedure called =
=E2=80=98which=E2=80=99.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.