unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: "Tomáš Čech" <sleep_walker@suse.cz>
Cc: guix-devel@gnu.org, enlightenment-devel@lists.sourceforge.net
Subject: Re: [PATCH] gnu: luajit: don't require ldconfig
Date: Sun, 01 Feb 2015 20:07:02 +0100	[thread overview]
Message-ID: <87zj8xh2nd.fsf@gnu.org> (raw)
In-Reply-To: <1422801817-20547-1-git-send-email-sleep_walker@suse.cz> ("Tomáš	Čech"'s message of "Sun, 1 Feb 2015 15:43:37 +0100")

Hi again!  :-)

Tomáš Čech <sleep_walker@suse.cz> skribis:

> * gnu/packages/lua.scm (luajit)[arguments]: Add "LDCONFIG=true" to make
>   command line

[...]

> --- a/gnu/packages/lua.scm
> +++ b/gnu/packages/lua.scm
> @@ -92,7 +92,7 @@ for configuration, scripting, and rapid prototyping.")
>      (arguments
>       '(#:tests? #f                      ;luajit is distributed without tests
>         #:phases (alist-delete 'configure %standard-phases)
> -       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out")))))
> +       #:make-flags (list "LDCONFIG=true" (string-append "PREFIX=" (assoc-ref %outputs "out")))))
>      (home-page "http://www.luajit.org/")

LGTM, but could you just add a comment above with the explanation you
gave?

TIA,
Ludo’.

PS: If you don’t have commit access yet, please let me know what your
    Savannah account is.

      reply	other threads:[~2015-02-01 19:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15 22:52 [PATCH] gnu: luajit: Add -fPIC into CFLAGS Tomáš Čech
2014-12-16 17:08 ` Ludovic Courtès
2014-12-16 19:28   ` Tomas Cech
2014-12-16 21:08     ` Ludovic Courtès
2014-12-16 21:42       ` Tomas Cech
2014-12-16 22:15         ` Ludovic Courtès
2014-12-27 12:08           ` Tomas Cech
2015-01-07 20:14             ` Ludovic Courtès
2015-01-28 20:31               ` Tomas Cech
2015-02-01 14:43                 ` [PATCH] gnu: luajit: don't require ldconfig Tomáš Čech
2015-02-01 19:07                   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj8xh2nd.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=enlightenment-devel@lists.sourceforge.net \
    --cc=guix-devel@gnu.org \
    --cc=sleep_walker@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).