unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] services: slim: Allow non-absolute path to be used as session command.
Date: Thu, 12 Mar 2015 21:15:04 +0100	[thread overview]
Message-ID: <87zj7i2cs7.fsf@gnu.org> (raw)
In-Reply-To: <1425993803-446-1-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Tue, 10 Mar 2015 21:23:22 +0800")

宋文武 <iyzsong@gmail.com> skribis:

> * gnu/services/xorg.scm (xinitrc)[builder]: Don't check the existence
>   of COMMAND.  Only run ~/.xsession when it exists.

[...]

> +        (let* ((home (getenv "HOME"))
> +               (xsession-file (string-append home "/.xsession"))
> +               (session (match (command-line)
> +                          ((_ x) x)
> +                          (_     #$fallback-session))))

Could you align the right-hand sides of the ‘let*’?

> +          (if (file-exists? xsession-file)
> +              ;; Run ~/.xsession when it exists.
> +              (exec-from-login-shell xsession-file)

This will fail if ~/.xsession is not executable.  It could use
‘executable-file?’ from (guix build utils), but OTOH it may be better to
just fail in this case since it’s most likely a user error.

Thoughts?

Thanks,
Ludo’.

  parent reply	other threads:[~2015-03-12 20:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 13:23 [PATCH 1/2] services: slim: Allow non-absolute path to be used as session command 宋文武
2015-03-10 13:23 ` [PATCH 2/2] services: slim: Pass SESSION to ~/.xsession as "$1" 宋文武
2015-03-12 20:15   ` Ludovic Courtès
2015-03-12 20:15 ` Ludovic Courtès [this message]
2015-03-13 14:59   ` [PATCH 1/2] services: slim: Allow non-absolute path to be used as session command 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj7i2cs7.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).