From: ludo@gnu.org (Ludovic Courtès)
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent
Date: Fri, 29 May 2015 23:07:42 +0200 [thread overview]
Message-ID: <87zj4n9joh.fsf@gnu.org> (raw)
In-Reply-To: <87382hsayu.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Wed, 27 May 2015 22:16:25 -0400")
David Thompson <dthompson2@worcester.edu> skribis:
> 'git send-email' isn't working for me on GuixSD, so below are 6 patches
> for adding some new Ruby packages. Sorry for the unideal email
> workflow.
ISTR that 宋文武 has a trick to “make it work.” 宋文武?
> From c077e0fa5d4a42748ad4e282c413e24ced124dcc Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Wed, 27 May 2015 21:33:17 -0400
> Subject: [PATCH 1/6] gnu: Add ruby-rspec-core.
>
> * gnu/packages/ruby.scm (ruby-rspec-support, ruby-rspec-core): New variables.
[...]
> +;; RSpec is the dominant testing library for Ruby projects. Even RSpec's
> +;; dependencies use RSpec for their test suites! To avoid these circular
> +;; dependencies, we disable tests for all of the RSpec-related packages.
Heh, makes sense.
OK.
> From 8218ac9aa4a7134d9f2f19ae3ff16a1f40989136 Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Wed, 27 May 2015 21:34:47 -0400
> Subject: [PATCH 2/6] gnu: Add ruby-rspec-expectations.
>
> * gnu/packages/ruby.scm (ruby-diff-lcs-for-rspec, ruby-rspec-expectations):
> New variables.
OK.
> From 23771fa86be95cbb1c6ac66fd22a26705d1b6d0e Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Wed, 27 May 2015 21:35:43 -0400
> Subject: [PATCH 3/6] gnu: Add ruby-rspec-mocks.
>
> * gnu/packages/ruby.scm (ruby-rspec-mocks): New variable.
OK.
> From 6bfb4946d819e9771ac1fa5879f01f3362dfcee6 Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Wed, 27 May 2015 21:36:24 -0400
> Subject: [PATCH 4/6] gnu: Add ruby-rspec.
>
> * gnu/packages/ruby.scm (ruby-rspec): New variable.
OK.
> From 2cc36edb761976fcd4c2a5f5c076fc2d12512cbd Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Wed, 27 May 2015 21:37:06 -0400
> Subject: [PATCH 5/6] gnu: Add bundler.
>
> * gnu/packages/ruby.scm (bundler): New variable.
OK.
> +;; Bundler is yet another source of circular dependencies, so we must disable
> +;; its test suite as well.
Is it also because its dependencies depend on it?
> From 7d1eb9189646aa9e206c5f6e8c4a4151ad727072 Mon Sep 17 00:00:00 2001
> From: David Thompson <davet@gnu.org>
> Date: Wed, 27 May 2015 21:38:28 -0400
> Subject: [PATCH 6/6] gnu: Add ruby-useragent.
>
Missing log. Otherwise LGTM.
Thanks!
Ludo’.
next prev parent reply other threads:[~2015-05-29 21:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 2:16 [PATCHES] Add ruby-rspec, bundler, and ruby-useragent David Thompson
2015-05-29 21:07 ` Ludovic Courtès [this message]
2015-05-30 0:27 ` Thompson, David
2015-05-30 21:02 ` Pjotr Prins
2015-05-30 21:57 ` Thompson, David
2015-05-30 22:23 ` Pjotr Prins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj4n9joh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).