From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/2] gnu: Make 'mount' interface in static Guile consistent with Guix API. Date: Fri, 19 Jun 2015 13:42:03 +0200 Message-ID: <87zj3vzzzo.fsf@gnu.org> References: <87r3p8il2o.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5ugU-0007hX-T9 for guix-devel@gnu.org; Fri, 19 Jun 2015 07:42:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5ugQ-0007E2-6I for guix-devel@gnu.org; Fri, 19 Jun 2015 07:42:10 -0400 In-Reply-To: <87r3p8il2o.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (David Thompson's message of "Thu, 18 Jun 2015 20:43:59 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Thompson Cc: guix-devel@gnu.org David Thompson skribis: > From 6efe8e786674d40e01df48c7df9a952107831ad9 Mon Sep 17 00:00:00 2001 > From: David Thompson > Date: Thu, 18 Jun 2015 20:21:41 -0400 > Subject: [PATCH 1/2] gnu: Make 'mount' interface in static Guile consiste= nt > with Guix API. > > Rather than expecting a pointer, the version of 'mount' in > guile-static-stripped now takes a string for the 'options' argument, just= like > the 'mount' procedure in (guix build syscalls). > > * gnu/packages/patches/guile-linux-syscalls.patch (mount): Expect a strin= g or > #f for 'options' argument. > * gnu/build/file-systems.scm (mount-file-system): Use new 'mount' interfa= ce. LGTM! Please make sure there are no remaining calls to =E2=80=98mount=E2=80=99 th= at use pointers instead of strings, if you haven=E2=80=99t already. Thanks, Ludo=E2=80=99.