From: Mark H Weaver <mhw@netris.org>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: guix-devel@gnu.org, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] Add FastTree
Date: Sat, 20 Jun 2015 13:17:40 -0400 [thread overview]
Message-ID: <87zj3u9u4r.fsf@netris.org> (raw)
In-Reply-To: <5584FAF9.8090902@uq.edu.au> (Ben Woodcroft's message of "Sat, 20 Jun 2015 15:32:41 +1000")
Hi Ben,
Instead of using 'trivial-build-system' for this, it would be better to
use 'gnu-build-system' and remove/replace the phases that aren't
appropriate. So, you'll probably want to remove the 'configure' phase
and replace the 'build' and 'install' phases.
Even so, there are many important phases and implicit inputs in
'gnu-build-system', notably setting the environment variables before the
build, and checking for missing rpaths in the installed binaries.
As you have it now, since you used bare 'binutils' and not our
'ld-wrapper' package, and you didn't add explicit rpaths options to the
linker, I guess that the produced executable won't be able to find the
specific shared libraries it was linked against without more help.
Mark
next prev parent reply other threads:[~2015-06-20 17:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 7:24 [PATCH] Add FastTree Ben Woodcroft
2015-06-19 10:13 ` Alex Kost
2015-06-19 22:30 ` Ben Woodcroft
2015-06-20 5:32 ` Ben Woodcroft
2015-06-20 17:17 ` Mark H Weaver [this message]
2015-06-20 23:12 ` Ben Woodcroft
2015-06-21 4:41 ` Mark H Weaver
2015-06-21 6:52 ` Ben Woodcroft
2015-06-21 7:32 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj3u9u4r.fsf@netris.org \
--to=mhw@netris.org \
--cc=alezost@gmail.com \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).