From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add manaplus.
Date: Mon, 12 Oct 2015 18:35:53 +0200 [thread overview]
Message-ID: <87zizoavti.fsf@gnu.org> (raw)
In-Reply-To: <87a8rocvq7.fsf@gmail.com> (Alex Kost's message of "Mon, 12 Oct 2015 11:54:56 +0300")
Alex Kost <alezost@gmail.com> skribis:
> Ludovic Courtès (2015-10-11 19:52 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> Ludovic Courtès (2015-10-09 15:40 +0300) wrote:
>>
>> [...]
>>
>>>> Can’t ‘sdl-union’ be used here? I think it was created specifically to
>>>> solve this problem. (Currently it’s private to (gnu packages sdl) but
>>>> you can export it.)
>>>
>>> Oh, great, I didn't know about it, thanks! It will reduce the workaround.
>>>
>>> However, just using this package cannot solve the problem: 'sdl-config'
>>> points directly to "/gnu/store/…-sdl-1.2.15", so you need to modify a
>>> package anyway to make it find "/gnu/store/…-sdl-union-1.2.15/include/SDL"
>>> (that's why 'guile-sdl' specifies "--with-sdl-prefix=").
>>
>> Oh. :-/ Then I guess you can go with the original patch, which LGTM.
>
> Actually, I think it will be more clear to use 'sdl-union' here, because
> the workaround is more concise, WDYT?
Indeed.
> From 2ace868aa60b36eb134ac155f79cee6d2f402970 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Sun, 4 Oct 2015 20:34:48 +0300
> Subject: [PATCH] gnu: Add manaplus.
>
> * gnu/packages/games.scm (manaplus): New variable.
OK!
Ludo’.
next prev parent reply other threads:[~2015-10-12 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 19:16 [PATCH 2/2] gnu: Add manaplus Alex Kost
2015-10-09 12:40 ` Ludovic Courtès
2015-10-09 16:56 ` Thompson, David
2015-10-09 21:56 ` Ludovic Courtès
2015-10-10 8:48 ` [PATCH] gnu: sdl-union: Wrap into a procedure and export it Alex Kost
2015-10-11 16:50 ` Ludovic Courtès
2015-10-12 8:54 ` Alex Kost
2015-10-10 8:48 ` [PATCH 2/2] gnu: Add manaplus Alex Kost
2015-10-11 16:52 ` Ludovic Courtès
2015-10-12 8:54 ` Alex Kost
2015-10-12 16:35 ` Ludovic Courtès [this message]
2015-10-13 10:34 ` [PATCH] gnu: abbaye: Use 'sdl-union' Alex Kost
2015-10-13 14:01 ` Thompson, David
2015-10-14 16:23 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zizoavti.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).